On Fri, Oct 27, 2017 at 4:31 PM, Eric Wheeler wrote:
>> Seems like something that's a lot of effort for little gain. It'll
>> only help when A) everything you need isn't dirty, and
>
> Indeed!
>
>> B) all the associated btree nodes are in memory.
>
> Is the dirty key map not memory resident?
The
On Fri, 27 Oct 2017, Michael Lyle wrote:
> On Fri, Oct 27, 2017 at 2:13 PM, Eric Wheeler
> wrote:
> [snip]
> >> > Can KEY_DIRTY facilitate this?
> >>
> >> Don't we only have the metadata to know if the key is dirty on the
> >> cache if we have the cache device? ;)
> >
> > Certainly if this is fo
On Fri, Oct 27, 2017 at 2:13 PM, Eric Wheeler wrote:
[snip]
>> > Can KEY_DIRTY facilitate this?
>>
>> Don't we only have the metadata to know if the key is dirty on the
>> cache if we have the cache device? ;)
>
> Certainly if this is for removal or a missing cache (perhaps I missed
> that).
>
> H
On Fri, 27 Oct 2017, Michael Lyle wrote:
> On Fri, Oct 27, 2017 at 12:57 PM, Eric Wheeler
> wrote:
> > Can this be relaxed to only error when the key failing to read is dirty?
> > The liklihood of a 100% clean cache in writeback on a busy system seems
> > unlikely.
> >
> > Can KEY_DIRTY facilitat
On Fri, Oct 27, 2017 at 12:57 PM, Eric Wheeler
wrote:
> Can this be relaxed to only error when the key failing to read is dirty?
> The liklihood of a 100% clean cache in writeback on a busy system seems
> unlikely.
>
> Can KEY_DIRTY facilitate this?
Don't we only have the metadata to know if the
On Tue, 17 Oct 2017, Coly Li wrote:
> When bcache does read I/Os, for example in writeback or writethrough mode,
> if a read request on cache device is failed, bcache will try to recovery
> the request by reading from cached device. If the data on cached device is
> not synced with cache device, t
When bcache does read I/Os, for example in writeback or writethrough mode,
if a read request on cache device is failed, bcache will try to recovery
the request by reading from cached device. If the data on cached device is
not synced with cache device, then requester will get a stale data.
For cri
