Re: [PATCHv4 4/4] block/sed: Embed function data into the function sequence

2017-02-22 Thread Keith Busch
On Wed, Feb 22, 2017 at 09:47:53AM -0700, Jens Axboe wrote: > I see, I found it now. Guys, let's get this process streamlined a bit > more. This whole thing has been a flurry of patches and patchseries, > posted by either you or Jon. Previous patch series was 1-4 patches > posted by you, and then

Re: [PATCHv4 4/4] block/sed: Embed function data into the function sequence

2017-02-22 Thread Jens Axboe
On 02/22/2017 12:13 AM, Christoph Hellwig wrote: >> +if (!lock_held) >> +mutex_lock(>dev_lock); > > No conditional locking, please. I guess I causesd this by asking you > to remove __opal_lock_unlock, but it seems we'd either need to keep it > in the end. > > Except for that the

Re: [PATCHv4 4/4] block/sed: Embed function data into the function sequence

2017-02-22 Thread Jon Derrick
On 02/22/2017 12:13 AM, Christoph Hellwig wrote: >> +if (!lock_held) >> +mutex_lock(>dev_lock); > > No conditional locking, please. I guess I causesd this by asking you > to remove __opal_lock_unlock, but it seems we'd either need to keep it > in the end. > > Except for that the

Re: [PATCHv4 4/4] block/sed: Embed function data into the function sequence

2017-02-21 Thread Christoph Hellwig
> + if (!lock_held) > + mutex_lock(>dev_lock); No conditional locking, please. I guess I causesd this by asking you to remove __opal_lock_unlock, but it seems we'd either need to keep it in the end. Except for that the series looks fine to me. Jens: given that 1-3 are the

Re: [PATCHv4 4/4] block/sed: Embed function data into the function sequence

2017-02-21 Thread Scott Bauer
On Tue, Feb 21, 2017 at 11:59:16AM -0700, Jon Derrick wrote: > By embedding the function data with the function sequence, we can > eliminate the external function data and state variable code. It also > made obvious some other small cleanups. > > Signed-off-by: Jon Derrick

[PATCHv4 4/4] block/sed: Embed function data into the function sequence

2017-02-21 Thread Jon Derrick
By embedding the function data with the function sequence, we can eliminate the external function data and state variable code. It also made obvious some other small cleanups. Signed-off-by: Jon Derrick --- block/sed-opal.c | 428