Re: [RFC PATCH v2] block: add io timeout to sysfs

2018-11-28 Thread Jens Axboe
On 11/28/18 9:13 AM, Bart Van Assche wrote: > On Mon, 2018-11-19 at 22:11 +0800, Weiping Zhang wrote: >> Give a interface to adjust io timeout by device. >> >> Signed-off-by: Weiping Zhang >> --- >> >> Changes since v1: >> * make sure timeout > 0 >> >> block/blk-sysfs.c | 27

Re: [RFC PATCH v2] block: add io timeout to sysfs

2018-11-28 Thread Bart Van Assche
On Mon, 2018-11-19 at 22:11 +0800, Weiping Zhang wrote: > Give a interface to adjust io timeout by device. > > Signed-off-by: Weiping Zhang > --- > > Changes since v1: > * make sure timeout > 0 > > block/blk-sysfs.c | 27 +++ > 1 file changed, 27 insertions(+)

Re: [RFC PATCH v2] block: add io timeout to sysfs

2018-11-28 Thread Jens Axboe
On 11/28/18 7:52 AM, Weiping Zhang wrote: > Hi Jens, > > It's useful if user want a short timeout when a disk doesn't work normally. > Would you give some comments for this patch, I'm fine with the patch, in fact I've posted a similar/identical one in the past but just never got around to

Re: [RFC PATCH v2] block: add io timeout to sysfs

2018-11-28 Thread Weiping Zhang
Hi Jens, It's useful if user want a short timeout when a disk doesn't work normally. Would you give some comments for this patch, Thanks a lot Weiping Zhang 于2018年11月19日周一 下午10:30写道: > > Give a interface to adjust io timeout by device. > > Signed-off-by: Weiping Zhang > --- > > Changes since

[RFC PATCH v2] block: add io timeout to sysfs

2018-11-19 Thread Weiping Zhang
Give a interface to adjust io timeout by device. Signed-off-by: Weiping Zhang --- Changes since v1: * make sure timeout > 0 block/blk-sysfs.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index 80eef48fddc8..90a927514d30