Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, 2018-01-15 at 18:13 -0500, Mike Snitzer wrote: > On Mon, Jan 15 2018 at 6:10P -0500, > Mike Snitzer wrote: > > > On Mon, Jan 15 2018 at 5:51pm -0500, > > Bart Van Assche wrote: > > > > > On Mon, 2018-01-15 at 17:15 -0500, Mike Snitzer

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Tue, Jan 16, 2018 at 7:13 AM, Mike Snitzer wrote: > On Mon, Jan 15 2018 at 6:10P -0500, > Mike Snitzer wrote: > >> On Mon, Jan 15 2018 at 5:51pm -0500, >> Bart Van Assche wrote: >> >> > On Mon, 2018-01-15 at 17:15 -0500, Mike

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, Jan 15 2018 at 6:10P -0500, Mike Snitzer wrote: > On Mon, Jan 15 2018 at 5:51pm -0500, > Bart Van Assche wrote: > > > On Mon, 2018-01-15 at 17:15 -0500, Mike Snitzer wrote: > > > sysfs write op calls kernfs_fop_write which takes: > > >

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, Jan 15 2018 at 5:51pm -0500, Bart Van Assche wrote: > On Mon, 2018-01-15 at 17:15 -0500, Mike Snitzer wrote: > > sysfs write op calls kernfs_fop_write which takes: > > of->mutex then kn->count#213 (no idea what that is) > > then q->sysfs_lock (via

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, 2018-01-15 at 17:15 -0500, Mike Snitzer wrote: > sysfs write op calls kernfs_fop_write which takes: > of->mutex then kn->count#213 (no idea what that is) > then q->sysfs_lock (via queue_attr_store) > > vs > > blk_unregister_queue takes: > q->sysfs_lock then > kernfs_mutex (via

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, Jan 15 2018 at 12:16pm -0500, Bart Van Assche wrote: > On Fri, 2018-01-12 at 10:06 -0500, Mike Snitzer wrote: > > I'm submitting this v5 with more feeling now ;) > > Hello Mike, > > Have these patches been tested with lockdep enabled? The following appeared in >

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, Jan 15 2018 at 12:51pm -0500, Bart Van Assche wrote: > On Mon, 2018-01-15 at 12:48 -0500, Mike Snitzer wrote: > > Do I need to do something more to enable lockdep aside from set > > CONFIG_LOCKDEP_SUPPORT=y ? > > Hello Mike, > > I think you also need to set

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, 2018-01-15 at 12:48 -0500, Mike Snitzer wrote: > Do I need to do something more to enable lockdep aside from set > CONFIG_LOCKDEP_SUPPORT=y ? Hello Mike, I think you also need to set CONFIG_PROVE_LOCKING=y. Bart.

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, Jan 15 2018 at 12:36pm -0500, Bart Van Assche wrote: > On Mon, 2018-01-15 at 12:29 -0500, Mike Snitzer wrote: > > So you replied to v5, I emailed a v6 out for the relevant patch. Just > > want to make sure you're testing with either Jens' latest tree or are > >

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, 2018-01-15 at 12:29 -0500, Mike Snitzer wrote: > So you replied to v5, I emailed a v6 out for the relevant patch. Just > want to make sure you're testing with either Jens' latest tree or are > using my v6 that fixed blk_mq_unregister_dev() to require caller holds > q->sysfs_lock ? Hello

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Mon, Jan 15 2018 at 12:16pm -0500, Bart Van Assche wrote: > On Fri, 2018-01-12 at 10:06 -0500, Mike Snitzer wrote: > > I'm submitting this v5 with more feeling now ;) > > Hello Mike, > > Have these patches been tested with lockdep enabled? The following appeared in >

Re: [for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

On Fri, 2018-01-12 at 10:06 -0500, Mike Snitzer wrote: > I'm submitting this v5 with more feeling now ;) Hello Mike, Have these patches been tested with lockdep enabled? The following appeared in the kernel log when after I started testing Jens' for-next tree of this morning:

[for-4.16 PATCH v5 0/4] block/dm: allow DM to defer blk_register_queue() until ready

Hi Jens, I'm submitting this v5 with more feeling now ;) I've distilled the changes down to be quite minimal. Hopefully this will help you and others review. I've also done a dry-run of applying 4.16 block changes and then merging dm-4.16; no merge conflicts: