Re: [rfc] weirdness in bio_map_user_iov()

2016-09-23 Thread Sagi Grimberg
Hey Al, What happens if we feed it a 3-element iovec array, one page in each? AFAICS, bio_add_pc_page() is called for each of those pages, even if the previous calls have failed - break is only out of the inner loop. Sure, failure due to exceeded request size means that everything after that

[rfc] weirdness in bio_map_user_iov()

2016-09-21 Thread Al Viro
What happens if we feed it a 3-element iovec array, one page in each? AFAICS, bio_add_pc_page() is called for each of those pages, even if the previous calls have failed - break is only out of the inner loop. Sure, failure due to exceeded request size means that everything after that one will