Re: [PATCH] Fix loop device flush before configure v3

On 06/08/2017 12:52 AM, James Wang wrote: > While installing SLES-12 (based on v4.4), I found that the installer > will stall for 60+ seconds during LVM disk scan. The root cause was > determined to be the removal of a bound device check in loop_flush() > by commit b5dd2f6047ca ("block: loop:

Re: [PATCH] Fix loop device flush before configure v3

On 06/08/2017 03:53 PM, Johannes Thumshirn wrote: > On 06/08/2017 08:52 AM, James Wang wrote: >> Test method: >> modprobe loop max_loop=64 >> dd if=/dev/zero of=disk bs=512 count=200K >> for((i=0;i<4;i++))do losetup -f disk; done >> mkfs.ext4 -F /dev/loop0 >> for((i=0;i<4;i++))do mkdir t$i;

Re: [PATCH] Fix loop device flush before configure v3

On 06/08/2017 08:52 AM, James Wang wrote: > Test method: > modprobe loop max_loop=64 > dd if=/dev/zero of=disk bs=512 count=200K > for((i=0;i<4;i++))do losetup -f disk; done > mkfs.ext4 -F /dev/loop0 > for((i=0;i<4;i++))do mkdir t$i; mount /dev/loop$i t$i;done > for f in `ls /dev/loop[0-9]*|sort`;

Re: [PATCH] Fix loop device flush before configure

On 06/08/2017 02:56 PM, Christoph Hellwig wrote: > On Thu, Jun 08, 2017 at 08:45:31AM +0800, James Wang wrote: >> Ok I got it blktests is a suite. I'd like to contribute something. If you >> need, we adapt you,;-)! >> But I have to learn some how to do that, need time. > I haven't added test

Re: [PATCH] Fix loop device flush before configure

On Thu, Jun 08, 2017 at 08:45:31AM +0800, James Wang wrote: > Ok I got it blktests is a suite. I'd like to contribute something. If you > need, we adapt you,;-)! > But I have to learn some how to do that, need time. I haven't added test myself to blktests yet either, so I'd have to learn it as

Re: [PATCH] Fix loop device flush before configure v2

On 06/08/2017 01:06 PM, Mike Galbraith wrote: > On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: >> This condition check was exist at before commit b5dd2f6047ca ("block: loop: >> improve performance via blk-mq") When add MQ support to loop device, it be >> removed because the member of

Re: [PATCH] Fix loop device flush before configure v2

On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add

Re: [PATCH] Fix loop device flush before configure

Ok I got it blktests is a suite. I'd like to contribute something. If you need, we adapt you,;-)! But I have to learn some how to do that, need time. James >From subway. 在 2017年6月7日，21:17，Christoph Hellwig 写道： >> Testing steps are following: >> modprobe loop max_loop=64

Re: [PATCH] Fix loop device flush before configure

> Testing steps are following: > modprobe loop max_loop=64 > dd if=/dev/zero of=disk bs=512 count=200K > for((i=0;i<4;i++))do losetup -f disk; done > mkfs.ext4 -F /dev/loop0 > for((i=0;i<4;i++))do mkdir t$i; mount /dev/loop$i t$i;done > for f in `ls /dev/loop[0-9]*|sort`; do \ > echo $f; dd

答复： Re: [PATCH] Fix loop device flush before configure

>>> Ming Lei 2017-6-7 下午 17:26 >>> On Wed, Jun 07, 2017 at 05:01:04PM +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the

Re: [PATCH] Fix loop device flush before configure

On Wed, Jun 07, 2017 at 05:01:04PM +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add