Re: Re: [PATCH] bcache: fix error count in memory shrink

2018-03-05 Thread tang . junhui
Hi Mike--- >>Hi Tang Junhui--- >> >>I'm not really sure about this one. It changes the semantics of the >>amount of work done-- nr_to_scan now means number of things to free >>instead of the number to check. >> >The code seems to be designed as that, sc->nr_to_scan marks how much btree >nodes to

Re: [PATCH] bcache: fix error count in memory shrink

2018-03-05 Thread tang . junhui
Hi Mike--- >Hi Tang Junhui--- > >I'm not really sure about this one. It changes the semantics of the >amount of work done-- nr_to_scan now means number of things to free >instead of the number to check. > The code seems to be designed as that, sc->nr_to_scan marks how much btree nodes to scan in

Re: [PATCH] bcache: fix error count in memory shrink

2018-03-05 Thread Michael Lyle
Hi Tang Junhui--- I'm not really sure about this one. It changes the semantics of the amount of work done-- nr_to_scan now means number of things to free instead of the number to check. If the system is under severe memory pressure, and most of the cache is essential/actively used, this could