Re: [PATCH] blk-mq: Make sure that the affected zone is unlocked if a request times out

2018-02-27 Thread Ming Lei
Hi Damien, On Wed, Feb 28, 2018 at 02:21:49AM +, Damien Le Moal wrote: > Ming, > > On 2018/02/27 17:35, Ming Lei wrote: > > On Tue, Feb 27, 2018 at 04:28:30PM -0800, Bart Van Assche wrote: > >> If a request times out the .completed_request() method is not called > > > > If BLK_EH_HANDLED is

Re: [PATCH] blk-mq: Make sure that the affected zone is unlocked if a request times out

2018-02-27 Thread Damien Le Moal
Ming, On 2018/02/27 17:35, Ming Lei wrote: > On Tue, Feb 27, 2018 at 04:28:30PM -0800, Bart Van Assche wrote: >> If a request times out the .completed_request() method is not called > > If BLK_EH_HANDLED is returned from .timeout(), __blk_mq_complete_request() > should have called

Re: [PATCH] blk-mq: Make sure that the affected zone is unlocked if a request times out

2018-02-27 Thread Ming Lei
On Tue, Feb 27, 2018 at 04:28:30PM -0800, Bart Van Assche wrote: > If a request times out the .completed_request() method is not called If BLK_EH_HANDLED is returned from .timeout(), __blk_mq_complete_request() should have called .completed_request(). Otherwise, somewhere may be wrong about