Re: [PATCH] blk-mq: improve tag waiting setup for non-shared tags

2017-12-01 Thread Bart Van Assche
On Thu, 2017-11-09 at 16:00 -0700, Jens Axboe wrote: > + spin_lock(&this_hctx->lock); > + if (!list_empty(&wait->entry)) { > + spin_unlock(&this_hctx->lock); > + return false; > + } > > - ws = bt_wait_ptr(&this_hctx->

Re: [PATCH] blk-mq: improve tag waiting setup for non-shared tags

2017-11-10 Thread Omar Sandoval
On Thu, Nov 09, 2017 at 04:00:09PM -0700, Jens Axboe wrote: > If we run out of driver tags, we currently treat shared and non-shared > tags the same - both cases hook into the tag waitqueue. This is a bit > more costly than it needs to be on unshared tags, since we have to both > grab the hctx lock