Re: [PATCH] jsflash: fix compilation

2018-05-15 Thread Jens Axboe
On 5/15/18 1:51 PM, David Miller wrote: > From: Jens Axboe > Date: Tue, 15 May 2018 13:00:36 -0600 > >> On 5/15/18 12:58 PM, David Miller wrote: >>> From: Jens Axboe >>> Date: Tue, 15 May 2018 12:51:20 -0600 >>> On 5/15/18 12:32 PM, Christoph Hellwig

Re: [PATCH] jsflash: fix compilation

2018-05-15 Thread David Miller
From: Jens Axboe Date: Tue, 15 May 2018 13:00:36 -0600 > On 5/15/18 12:58 PM, David Miller wrote: >> From: Jens Axboe >> Date: Tue, 15 May 2018 12:51:20 -0600 >> >>> On 5/15/18 12:32 PM, Christoph Hellwig wrote: No bio in this whole function, use req->bio

Re: [PATCH] jsflash: fix compilation

2018-05-15 Thread Jens Axboe
On 5/15/18 12:58 PM, David Miller wrote: > From: Jens Axboe > Date: Tue, 15 May 2018 12:51:20 -0600 > >> On 5/15/18 12:32 PM, Christoph Hellwig wrote: >>> No bio in this whole function, use req->bio instead. >> >> Applied. >> >>> Looks like no one except for Guenters build bot

Re: [PATCH] jsflash: fix compilation

2018-05-15 Thread David Miller
From: Jens Axboe Date: Tue, 15 May 2018 12:51:20 -0600 > On 5/15/18 12:32 PM, Christoph Hellwig wrote: >> No bio in this whole function, use req->bio instead. > > Applied. > >> Looks like no one except for Guenters build bot cared. I wonder if we >> should just get rid of the

Re: [PATCH] jsflash: fix compilation

2018-05-15 Thread Jens Axboe
On 5/15/18 12:32 PM, Christoph Hellwig wrote: > No bio in this whole function, use req->bio instead. Applied. > Looks like no one except for Guenters build bot cared. I wonder if we > should just get rid of the driver given that it doesn't look in a good > shape at all based on his build logs