Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-15 Thread Ulf Hansson
On 15 November 2017 at 14:07, Adrian Hunter wrote: > On 15/11/17 12:55, Ulf Hansson wrote: >> Linus, Adrian, >> >> Apologize for sidetracking the discussion, just wanted to add some >> minor comments. >> >> [...] >> >>> > But what I think is nice in doing it around

Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-15 Thread Adrian Hunter
On 15/11/17 12:55, Ulf Hansson wrote: > Linus, Adrian, > > Apologize for sidetracking the discussion, just wanted to add some > minor comments. > > [...] > >> But what I think is nice in doing it around each request is that since mmc_put_card() calls mmc_release_host() contains

Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-15 Thread Ulf Hansson
Linus, Adrian, Apologize for sidetracking the discussion, just wanted to add some minor comments. [...] > >>> But what I think is nice in doing it around >>> each request is that since mmc_put_card() calls mmc_release_host() >>> contains this: >>> >>> if (--host->claim_cnt) { (...) >>> >>> So

Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-14 Thread Linus Walleij
Hi Adrian! Thanks for the helpful and productive tone in the recent mail, it is very helpful and improves my work environment. >> The block layer maintainers most definately think MQ is ready >> but you seem to disagree. Why? > > I meant when the mmc conversion to blk-mq is ready. We don't need

Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-14 Thread Adrian Hunter
On 09/11/17 17:52, Linus Walleij wrote: > On Thu, Nov 9, 2017 at 11:42 AM, Adrian Hunter > wrote: >> On 08/11/17 10:54, Linus Walleij wrote: >>> On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter >>> wrote: > >>> At least you could do what I did

Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-10 Thread Linus Walleij
Following up on this: On Thu, Nov 9, 2017 at 4:52 PM, Linus Walleij wrote: >> No one has ever suggested that the legacy API will remain. Once blk-mq is >> ready the old code gets deleted. > > The block layer maintainers most definately think MQ is ready > but you seem

Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-09 Thread Linus Walleij
On Thu, Nov 9, 2017 at 11:42 AM, Adrian Hunter wrote: > On 08/11/17 10:54, Linus Walleij wrote: >> On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter >> wrote: >> At least you could do what I did and break out a helper like >> this: >> >> /* >> *

Re: [PATCH V13 03/10] mmc: block: Add blk-mq support

2017-11-08 Thread Linus Walleij
On Fri, Nov 3, 2017 at 2:20 PM, Adrian Hunter wrote: > Define and use a blk-mq queue. Discards and flushes are processed > synchronously, but reads and writes asynchronously. In order to support > slow DMA unmapping, DMA unmapping is not done until after the next request