Re: [PATCH V2 5/5] nvme: pci: simplify timeout handling

2018-05-02 Thread Ming Lei
On Wed, May 02, 2018 at 01:12:57PM +0800, jianchao.wang wrote: > Hi Ming > > On 05/02/2018 12:54 PM, Ming Lei wrote: > >> We need to return BLK_EH_RESET_TIMER in nvme_timeout then: > >> 1. defer the completion. we can't unmap the io request before close the > >> controller totally, so not

Re: [PATCH V2 5/5] nvme: pci: simplify timeout handling

2018-05-01 Thread jianchao.wang
Hi Ming On 05/02/2018 12:54 PM, Ming Lei wrote: >> We need to return BLK_EH_RESET_TIMER in nvme_timeout then: >> 1. defer the completion. we can't unmap the io request before close the >> controller totally, so not BLK_EH_HANDLED. >> 2. nvme_cancel_request could complete it.

Re: [PATCH V2 5/5] nvme: pci: simplify timeout handling

2018-05-01 Thread Ming Lei
On Wed, May 02, 2018 at 10:23:20AM +0800, jianchao.wang wrote: > Hi Ming > > On 04/29/2018 11:41 PM, Ming Lei wrote: > > + > > static enum blk_eh_timer_return nvme_timeout(struct request *req, bool > > reserved) > > { > > struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > > @@ -1197,8 +1297,7

Re: [PATCH V2 5/5] nvme: pci: simplify timeout handling

2018-05-01 Thread jianchao.wang
Hi Ming On 04/29/2018 11:41 PM, Ming Lei wrote: > + > static enum blk_eh_timer_return nvme_timeout(struct request *req, bool > reserved) > { > struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > @@ -1197,8 +1297,7 @@ static enum blk_eh_timer_return nvme_timeout(struct > request *req, bool