Re: dm-crypt: Fix error with too large bios

2016-08-31 Thread Mike Snitzer
On Wed, Aug 31 2016 at 2:26am -0400, Milan Broz wrote: > On 08/31/2016 12:27 AM, Mikulas Patocka wrote: > > ... > > > > Drop that "#ifdef CONFIG_BCACHE". Anyone should be allowed to create a big > > bio, not just bcache. > > Yes. Please, do not hide it behind #ifdef. >

Re: dm-crypt: Fix error with too large bios

2016-08-31 Thread Milan Broz
ate: Tue, 30 Aug 2016 16:38:42 -0400 >> Subject: [PATCH] dm crypt: fix error with too large bcache bios >> >> When dm-crypt processes writes, it allocates a new bio in >> crypt_alloc_buffer(). The bio is allocated from a bio set and it can >> have at most BIO_MA

Re: dm-crypt: Fix error with too large bios

2016-08-30 Thread Mikulas Patocka
GFP_NOIO, nr_iovecs, cc->bs); > > > > So, if io->base_bio->bi_iter.bi_size <= BIO_MAX_SIZE, then nr_iovecs will > > be less or equal than BIO_MAX_PAGES and the function bio_alloc_bioset will > > succeed. > > > > (BTW. BIO_MAX_SIZE was removed in th

Re: dm-crypt: Fix error with too large bios

2016-08-29 Thread Mikulas Patocka
On Mon, 29 Aug 2016, Mike Snitzer wrote: > On Sat, Aug 27 2016 at 11:09am -0400, > Mikulas Patocka wrote: > > > > > > > On Fri, 26 Aug 2016, Mike Snitzer wrote: > > > > > On Thu, Aug 25 2016 at 4:13pm -0400, > > > Jens Axboe wrote: > > > > > > > On

Re: dm-crypt: Fix error with too large bios

2016-08-29 Thread Mike Snitzer
On Sat, Aug 27 2016 at 11:09am -0400, Mikulas Patocka wrote: > > > On Fri, 26 Aug 2016, Mike Snitzer wrote: > > > On Thu, Aug 25 2016 at 4:13pm -0400, > > Jens Axboe wrote: > > > > > On 08/25/2016 12:34 PM, Mikulas Patocka wrote: > > > > > > > >Device

Re: dm-crypt: Fix error with too large bios

2016-08-26 Thread Mike Snitzer
On Thu, Aug 25 2016 at 4:13pm -0400, Jens Axboe wrote: > On 08/25/2016 12:34 PM, Mikulas Patocka wrote: > > > >Device mapper can't split the bio in generic_make_request - it frees the > >md->queue->bio_split bioset, to save one kernel thread per device. Device > >mapper uses

Re: [dm-devel] dm-crypt: Fix error with too large bios

2016-08-25 Thread Jens Axboe
On 08/25/2016 12:34 PM, Mikulas Patocka wrote: On Thu, 18 Aug 2016, Eric Wheeler wrote: On Wed, Jun 01 2016 at 9:44am -0400, Christoph Hellwig wrote: be dm-crypt.c. Maybe you've identified some indirect use of BIO_MAX_SIZE? I mean the recently introduced

Re: [dm-devel] dm-crypt: Fix error with too large bios

2016-08-25 Thread Mikulas Patocka
On Thu, 18 Aug 2016, Eric Wheeler wrote: > > On Wed, Jun 01 2016 at 9:44am -0400, Christoph Hellwig > > wrote: > > > > > > > be dm-crypt.c. Maybe you've identified some indirect use of > > > > > BIO_MAX_SIZE? > > > > > > > > I mean the recently introduced BIO_MAX_SIZE