Re: [dm-devel] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2017-03-10 Thread Eric Wheeler
On Thu, 5 Jan 2017, Mike Snitzer wrote: > On Thu, Dec 29 2016 at 11:08pm -0500, > Eric Wheeler wrote: > > > On Sat, 17 Dec 2016, Mike Snitzer wrote: > > > On Fri, Dec 16 2016 at 5:29pm -0500, > > > Eric Wheeler wrote: > > > > On Wed,

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-29 Thread Eric Wheeler
On Sat, 17 Dec 2016, Mike Snitzer wrote: > On Fri, Dec 16 2016 at 5:29pm -0500, > Eric Wheeler wrote: > > On Wed, 14 Dec 2016, Eric Wheeler wrote: > > > Since dm-crypt queues writes (and sometimes reads) to a different kernel > > > thread (workqueue), the bios will

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-18 Thread Kent Overstreet
On Sun, Dec 18, 2016 at 06:17:55PM -0500, Mike Snitzer wrote: > Spinning it as a pure bugfix is a reach (as Eric's header documents the > patch, the case is weak for cc'ing stable). Reality is the change is > needed to enable a new bcache feature. I'm not going to rush > feature-enabling change

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-18 Thread Mike Snitzer
On Sun, Dec 18 2016 at 5:54pm -0500, Kent Overstreet wrote: > On Sat, Dec 17, 2016 at 10:58:00AM -0500, Mike Snitzer wrote: > > The time for 4.10 inclusion has passed. This needs to wait until 4.11. > > > > It also needs more review, testing and possible re-working.

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-18 Thread Kent Overstreet
On Sat, Dec 17, 2016 at 10:58:00AM -0500, Mike Snitzer wrote: > The time for 4.10 inclusion has passed. This needs to wait until 4.11. > > It also needs more review, testing and possible re-working. Each DM > target shouldn't have to worry about these details (though I do grant > that

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-17 Thread Mike Snitzer
On Fri, Dec 16 2016 at 5:29pm -0500, Eric Wheeler wrote: > On Wed, 14 Dec 2016, Eric Wheeler wrote: > > Since dm-crypt queues writes (and sometimes reads) to a different kernel > > thread (workqueue), the bios will dispatch from tasks with different > >

Re: [dm-devel] [PATCH] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-16 Thread Eric Wheeler
On Wed, 14 Dec 2016, Eric Wheeler wrote: > Since dm-crypt queues writes (and sometimes reads) to a different kernel > thread (workqueue), the bios will dispatch from tasks with different > io_context->ioprio settings than the submitting task, thus giving > incorrect ioprio hints to the io