Re: [Nbd] [PATCH][V3] nbd: add multi-connection support

2016-09-29 Thread Josef Bacik
On 09/29/2016 05:52 AM, Wouter Verhelst wrote: Hi Josef, On Wed, Sep 28, 2016 at 04:01:32PM -0400, Josef Bacik wrote: NBD can become contended on its single connection. We have to serialize all writes and we can only process one read response at a time. Fix this by allowing userspace to

Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

2016-09-29 Thread Brian King
Thanks Christoph. Very nice. As I was reviewing the patch, I noticed the additional PCI_IRQ_AFFINITY flag, which is currently not being set in this patch. Is the intention to set that globally by default, or should I follow up with a one liner to add that to the ipr driver in the next patch set I

Re: [Nbd] [PATCH][V3] nbd: add multi-connection support

2016-09-29 Thread Wouter Verhelst
On Thu, Sep 29, 2016 at 10:03:50AM -0400, Josef Bacik wrote: > So think of it like normal disks with multiple channels. We don't send > flushes > down all the hwq's to make sure they are clear, we leave that decision up to > the > application (usually a FS of course). Well, when I asked

[PATCH v5 6/7] sd: Implement support for ZBC devices

2016-09-29 Thread Damien Le Moal
From: Hannes Reinecke Implement ZBC support functions to setup zoned disks, both host-managed and host-aware models. Only zoned disks that satisfy the following conditions are supported: 1) All zones are the same size, with the exception of an eventual last smaller runt zone. 2)

[PATCH v5 7/7] blk-zoned: implement ioctls

2016-09-29 Thread Damien Le Moal
From: Shaun Tancheff Adds the new BLKREPORTZONE and BLKRESETZONE ioctls for respectively obtaining the zone configuration of a zoned block device and resetting the write pointer of sequential zones of a zoned block device. The BLKREPORTZONE ioctl maps directly to a single

[PATCH v5 5/7] block: Implement support for zoned block devices

2016-09-29 Thread Damien Le Moal
From: Hannes Reinecke Implement zoned block device zone information reporting and reset. Zone information are reported as struct blk_zone. This implementation does not differentiate between host-aware and host-managed device models and is valid for both. Two functions are provided:

[PATCH v5 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

2016-09-29 Thread Damien Le Moal
From: Hannes Reinecke The queue limits already have a 'chunk_sectors' setting, so we should be presenting it via sysfs. Signed-off-by: Hannes Reinecke [Damien: Updated Documentation/ABI/testing/sysfs-block] Signed-off-by: Damien Le Moal

[PATCH v5 1/7] block: Add 'zoned' queue limit

2016-09-29 Thread Damien Le Moal
Add the zoned queue limit to indicate the zoning model of a block device. Defined values are 0 (BLK_ZONED_NONE) for regular block devices, 1 (BLK_ZONED_HA) for host-aware zone block devices and 2 (BLK_ZONED_HM) for host-managed zone block devices. The standards defined drive managed model is not

[PATCH v5 0/7] ZBC / Zoned block device support

2016-09-29 Thread Damien Le Moal
This series introduces support for zoned block devices. It integrates earlier submissions by Hannes Reinecke and Shaun Tancheff. Compared to the previous series version, the code was significantly simplified by limiting support to zoned devices satisfying the following conditions: 1) All zones of

Re: [PATCH v4 6/7] sd: Implement support for ZBC devices

2016-09-29 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Damien, Almost there! And A-OK on the read capacity changes. However: @@ -844,6 +850,13 @@ static int sd_setup_write_same_cmnd(struct scsi_cmnd *cmd) BUG_ON(bio_offset(bio) || bio_iovec(bio).bv_len !=

Re: [PATCH 5/6] genwqe: use pci_irq_allocate_vectors

2016-09-29 Thread Gabriel Krisman Bertazi
Christoph Hellwig writes: > On Thu, Sep 29, 2016 at 03:45:29PM -0300, Gabriel Krisman Bertazi wrote: >> I'm stepping up to assist with the genwqe_card driver just now, since we >> (ibm) missed some of the last patches that went in. I'll add myself to >> maintainers file. > > Can

Re: [PATCH 3/6] skd: use pci_alloc_irq_vectors

2016-09-29 Thread Christoph Hellwig
On Sun, Sep 11, 2016 at 03:31:25PM +0200, Christoph Hellwig wrote: > Switch the skd driver to use pci_alloc_irq_vectors. We need to two calls to > pci_alloc_irq_vectors as skd only supports multiple MSI-X vectors, but not > multiple MSI vectors. > > Otherwise this cleans up a lot of cruft and

Re: [PATCH 5/6] genwqe: use pci_irq_allocate_vectors

2016-09-29 Thread Christoph Hellwig
On Thu, Sep 29, 2016 at 03:45:29PM -0300, Gabriel Krisman Bertazi wrote: > I'm stepping up to assist with the genwqe_card driver just now, since we > (ibm) missed some of the last patches that went in. I'll add myself to > maintainers file. Can your forward it to Greg together with whatever

Re: [Nbd] [PATCH][V3] nbd: add multi-connection support

2016-09-29 Thread Josef Bacik
On 09/29/2016 12:41 PM, Wouter Verhelst wrote: On Thu, Sep 29, 2016 at 10:03:50AM -0400, Josef Bacik wrote: So think of it like normal disks with multiple channels. We don't send flushes down all the hwq's to make sure they are clear, we leave that decision up to the application (usually a FS

Re: [PATCH 5/6] genwqe: use pci_irq_allocate_vectors

2016-09-29 Thread Gabriel Krisman Bertazi
Christoph Hellwig writes: > On Thu, Sep 29, 2016 at 03:28:02PM -0300, Gabriel Krisman Bertazi wrote: >> Christoph Hellwig writes: >> >> > Simply the interrupt setup by using the new PCI layer helpers. >> >> Good clean up. Tested and: >> >> Acked-by: Gabriel Krisman

Re: [PATCH 4/6] vfio_pci: use pci_irq_allocate_vectors

2016-09-29 Thread Alex Williamson
On Thu, 29 Sep 2016 21:24:04 +0200 Christoph Hellwig wrote: > On Thu, Sep 29, 2016 at 01:21:01PM -0600, Alex Williamson wrote: > > Sorry for the delay, slipped by me. Overall a really nice cleanup. > > One tiny nit, the commit log mis-names the function as > >

Re: [PATCH v2 4/7] blk-mq: Introduce blk_quiesce_queue() and blk_resume_queue()

2016-09-29 Thread Ming Lei
On Thu, Sep 29, 2016 at 7:59 AM, Bart Van Assche wrote: > blk_quiesce_queue() prevents that new queue_rq() invocations blk_mq_quiesce_queue() > occur and waits until ongoing invocations have finished. This > function does *not* wait until all outstanding requests

[PATCH 3/3] block: implement (some of) fallocate for block devices

2016-09-29 Thread Darrick J. Wong
After much discussion, it seems that the fallocate feature flag FALLOC_FL_ZERO_RANGE maps nicely to SCSI WRITE SAME; and the feature FALLOC_FL_PUNCH_HOLE maps nicely to the devices that have been whitelisted for zeroing SCSI UNMAP. Punch still requires that FALLOC_FL_KEEP_SIZE is set. A length

Re: [PATCH 4/6] vfio_pci: use pci_irq_allocate_vectors

2016-09-29 Thread Christoph Hellwig
On Thu, Sep 29, 2016 at 01:21:01PM -0600, Alex Williamson wrote: > Sorry for the delay, slipped by me. Overall a really nice cleanup. > One tiny nit, the commit log mis-names the function as > pci_irq_allocate_vectors instead of pci_alloc_irq_vectors. With that, > > Acked-by: Alex Williamson

Re: [PATCH 1/3] block: Add iocontext priority to request

2016-09-29 Thread Tejun Heo
Hello, On Tue, Sep 27, 2016 at 11:14:54AM -0700, Adam Manzanares wrote: > Patch adds association between iocontext and a request. > > Signed-off-by: Adam Manzanares Can you please describe how this may impact existing usages? Thanks. -- tejun -- To unsubscribe from

Re: [Nbd] [PATCH][V3] nbd: add multi-connection support

2016-09-29 Thread Wouter Verhelst
Hi Josef, On Wed, Sep 28, 2016 at 04:01:32PM -0400, Josef Bacik wrote: > NBD can become contended on its single connection. We have to serialize all > writes and we can only process one read response at a time. Fix this by > allowing userspace to provide multiple connections to a single nbd

Re: [PATCH v2 3/3] block: implement (some of) fallocate for block devices

2016-09-29 Thread Darrick J. Wong
On Thu, Sep 29, 2016 at 01:08:57PM -0700, Bart Van Assche wrote: > On 09/28/2016 07:19 PM, Darrick J. Wong wrote: > >After much discussion, it seems that the fallocate feature flag > >FALLOC_FL_ZERO_RANGE maps nicely to SCSI WRITE SAME; and the feature > >FALLOC_FL_PUNCH_HOLE maps nicely to the

Re: [PATCH v4 1/7] block: Add 'zoned' queue limit

2016-09-29 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Damien> Add the zoned queue limit to indicate the zoning model of a Damien> block device. Defined values are 0 (BLK_ZONED_NONE) for regular Damien> block devices, 1 (BLK_ZONED_HA) for host-aware zone block Damien> devices and 2

Re: [PATCH v4 3/7] block: update chunk_sectors in blk_stack_limits()

2016-09-29 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to

Re: [PATCH v4 5/7] block: Implement support for zoned block devices

2016-09-29 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Damien> Implement zoned block device zone information reporting and Damien> reset. Zone information are reported as struct blk_zone. This Damien> implementation does not differentiate between host-aware and Damien> host-managed