Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread Mike Galbraith
On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add

Re: [PATCH] Fix loop device flush before configure v2

2017-06-07 Thread James Wang
On 06/08/2017 01:06 PM, Mike Galbraith wrote: > On Thu, 2017-06-08 at 10:17 +0800, James Wang wrote: >> This condition check was exist at before commit b5dd2f6047ca ("block: loop: >> improve performance via blk-mq") When add MQ support to loop device, it be >> removed because the member of

Re: [PATCH] blk-throttle: set default latency baseline for harddisk

2017-06-07 Thread Jens Axboe
On 06/06/2017 04:11 PM, Shaohua Li wrote: > On Tue, Jun 06, 2017 at 03:12:12PM -0600, Jens Axboe wrote: >> On 06/06/2017 01:40 PM, Shaohua Li wrote: >>> From: Shaohua Li >>> >>> hard disk IO latency varies a lot depending on spindle move. The latency >>> range could be from several

Re: [PATCH blktests v2 0/3] Add SCSI generic test group

2017-06-07 Thread Johannes Thumshirn
On 06/07/2017 08:44 AM, Omar Sandoval wrote: > Sorry for the delay, I was chasing down a few Btrfs bugs for the last > couple of weeks. I applied these with some small changes. I stuck with > running syzkaller on the scsi-debug device like you had here, we can > revisit that for future tests if it

Re: [PATCH blktests v2 0/3] Add SCSI generic test group

2017-06-07 Thread Omar Sandoval
On Fri, May 19, 2017 at 03:55:28PM +0200, Johannes Thumshirn wrote: > Add a test group for the SCSI generic driver and one syzcaller > reproducer for this group. > > The reprodcuer is distributed as a C program, so the makefile is > amended to build C files to be used in the test. > > Changes to

Re: [PATCH 7/8] blk-mq: create hctx for each present CPU

2017-06-07 Thread Christoph Hellwig
On Wed, Jun 07, 2017 at 05:10:46PM +0800, Ming Lei wrote: > One thing not sure is that we may need to handle new CPU hotplug > after initialization. Without the CPU hotplug handler, system may > not scale well when more CPUs are added to sockets. Adding physical CPUs to sockets is a very rare

Re: [PATCHv7 2/2] loop: support 4k physical blocksize

2017-06-07 Thread Omar Sandoval
On Fri, Apr 07, 2017 at 10:59:29PM +0800, Ming Lei wrote: > On Fri, Apr 07, 2017 at 12:50:57PM +0200, Hannes Reinecke wrote: > > When generating bootable VM images certain systems (most notably > > s390x) require devices with 4k blocksize. This patch implements > > a new flag 'LO_FLAGS_BLOCKSIZE'

[PATCH] Fix loop device flush before configure

2017-06-07 Thread James Wang
This condition check was exist at before commit b5dd2f6047ca ("block: loop: improve performance via blk-mq") When add MQ support to loop device, it be removed because the member of '->lo_thread' be removed. And then upstream add '->worker_task', I think they forget add it to here. When I install

Re: [PATCH] Fix loop device flush before configure

2017-06-07 Thread Ming Lei
On Wed, Jun 07, 2017 at 05:01:04PM +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the member of '->lo_thread' be removed. And then upstream > add

Re: [PATCH 7/8] blk-mq: create hctx for each present CPU

2017-06-07 Thread Ming Lei
On Sat, Jun 03, 2017 at 04:04:02PM +0200, Christoph Hellwig wrote: > Currently we only create hctx for online CPUs, which can lead to a lot > of churn due to frequent soft offline / online operations. Instead > allocate one for each present CPU to avoid this and dramatically simplify > the code.

答复: Re: [PATCH] Fix loop device flush before configure

2017-06-07 Thread Jin Nan Wang
>>> Ming Lei 2017-6-7 下午 17:26 >>> On Wed, Jun 07, 2017 at 05:01:04PM +0800, James Wang wrote: > This condition check was exist at before commit b5dd2f6047ca ("block: loop: > improve performance via blk-mq") When add MQ support to loop device, it be > removed because the

Re: [PATCH 7/8] blk-mq: create hctx for each present CPU

2017-06-07 Thread Omar Sandoval
On Sat, Jun 03, 2017 at 04:04:02PM +0200, Christoph Hellwig wrote: > Currently we only create hctx for online CPUs, which can lead to a lot > of churn due to frequent soft offline / online operations. Instead > allocate one for each present CPU to avoid this and dramatically simplify > the code.

Re: [PATCH] Fix loop device flush before configure

2017-06-07 Thread James Wang
Ok I got it blktests is a suite. I'd like to contribute something. If you need, we adapt you,;-)! But I have to learn some how to do that, need time. James >From subway. 在 2017年6月7日,21:17,Christoph Hellwig 写道: >> Testing steps are following: >> modprobe loop max_loop=64

[PATCH] Fix loop device flush before configure v2

2017-06-07 Thread James Wang
This condition check was exist at before commit b5dd2f6047ca ("block: loop: improve performance via blk-mq") When add MQ support to loop device, it be removed because the member of '->lo_thread' be removed. And then upstream add '->worker_task', I think they forget add it to here. When I install

Re: [PATCH] blk-throttle: fix NULL pointer dereference in throtl_schedule_pending_timer

2017-06-07 Thread Jens Axboe
On 06/06/2017 09:36 PM, Joseph Qi wrote: > From: Joseph Qi > > I have encountered a NULL pointer dereference in > throtl_schedule_pending_timer: > [ 413.735396] BUG: unable to handle kernel NULL pointer dereference at > 0038 > [ 413.735535] IP: []

Re: [PATCH] Fix loop device flush before configure

2017-06-07 Thread Christoph Hellwig
> Testing steps are following: > modprobe loop max_loop=64 > dd if=/dev/zero of=disk bs=512 count=200K > for((i=0;i<4;i++))do losetup -f disk; done > mkfs.ext4 -F /dev/loop0 > for((i=0;i<4;i++))do mkdir t$i; mount /dev/loop$i t$i;done > for f in `ls /dev/loop[0-9]*|sort`; do \ > echo $f; dd