Re: [PATCH] bcache: fix race in setting bdev state

Tang--- On 10/09/2017 11:51 PM, tang.jun...@zte.com.cn wrote: [snip] > Yes, It's true. but it's hard to resolve it by holding writeback lock, > since not all codes in bch_writeback_thread() are held in writeback lock, > actually in a previous patch I have resolved it by changing schedule() to

Re: [ANNOUNCE] fsperf: a simple fs/block performance testing framework

On Tue, Oct 10, 2017 at 08:09:20AM +1100, Dave Chinner wrote: > > I'd _like_ to expand fio for cases we come up with that aren't possible, as > > there's already a ton of measurements that are taken, especially around > > latencies. > > To be properly useful it needs to support more than just fio

Re: [PATCH v6 9/9] block, scsi: Make SCSI device suspend and resume work reliably

On Mon, Oct 09, 2017 at 09:16:53PM +, Bart Van Assche wrote: > On Sat, 2017-10-07 at 12:33 +0800, Ming Lei wrote: > > On Wed, Oct 04, 2017 at 05:01:10PM -0700, Bart Van Assche wrote: > > > It is essential during suspend and resume that neither the filesystem > > > state nor the filesystem

Re: [PATCH v7 9/9] block, scsi: Make SCSI quiesce and resume work reliably

Bart Van Assche - 09.10.17, 16:14: > The contexts from which a SCSI device can be quiesced or resumed are: > * Writing into /sys/class/scsi_device/*/device/state. > * SCSI parallel (SPI) domain validation. > * The SCSI device power management methods. See also scsi_bus_pm_ops. > > It is essential

Re: [PATCH v7 9/9] block, scsi: Make SCSI quiesce and resume work reliably

On Mon, Oct 09, 2017 at 04:14:00PM -0700, Bart Van Assche wrote: > The contexts from which a SCSI device can be quiesced or resumed are: > * Writing into /sys/class/scsi_device/*/device/state. > * SCSI parallel (SPI) domain validation. > * The SCSI device power management methods. See also

Re: false positive lockdep splat with loop device

On Tue, Oct 10, 2017 at 11:16 AM, Ilya Dryomov wrote: > On Thu, Oct 5, 2017 at 6:33 PM, Christoph Hellwig wrote: >> Does the patch below fix the warning for you? >> >> -- >> From 28aae7104425433d39e6142adcd5b88dc5b0ad5f Mon Sep 17 00:00:00 2001 >> From:

Re: [PATCH V2] writeback: merge try_to_writeback_inodes_sb_nr() into caller

Hi Jens, On Mon, Oct 09, 2017 at 02:00:29PM +0200, Jan Kara wrote: > On Mon 09-10-17 13:34:41, Rakesh Pandit wrote: > > Since commit 925a6efb8ff0c ("Btrfs: stop using > > try_to_writeback_inodes_sb_nr to flush delalloc") this function hasn't > > been used outside so stop exporting it. > > > > In

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

> Il giorno 10 ott 2017, alle ore 14:34, Johannes Thumshirn > ha scritto: > > Hi John, > > On Tue, Oct 10, 2017 at 01:24:52PM +0100, John Garry wrote: >> It's using cfq (for non-mq) and mq-deadline (obviously for mq). > > Please be aware that cfq and mq-deadline are _not_

Re: [PATCH V8 00/14] mmc: Add Command Queue support

On 10/10/17 16:08, Ulf Hansson wrote: > [...] > > > I have also run some test on my ux500 board and enabling the blkmq > path via the new MMC Kconfig option. My idea was to run some iozone > comparisons between the legacy path and the new blkmq path, but I just > couldn't get

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

On Tue, Oct 10, 2017 at 01:24:52PM +0100, John Garry wrote: > On 10/10/2017 02:46, Ming Lei wrote: > > > > > > I tested this series for the SAS controller on HiSilicon hip07 > > > > > > platform as I > > > > > > am interested in enabling MQ for this driver. Driver is > > > > > >

Re: [PATCH V8 00/14] mmc: Add Command Queue support

On 10/10/17 15:12, Ulf Hansson wrote: > On 21 September 2017 at 11:44, Adrian Hunter wrote: >> On 21/09/17 12:01, Ulf Hansson wrote: >>> On 13 September 2017 at 13:40, Adrian Hunter >>> wrote: Hi Here is V8 of the hardware command

Re: [PATCH V2] writeback: merge try_to_writeback_inodes_sb_nr() into caller

On 10/10/2017 03:43 AM, Rakesh Pandit wrote: > Hi Jens, > > On Mon, Oct 09, 2017 at 02:00:29PM +0200, Jan Kara wrote: >> On Mon 09-10-17 13:34:41, Rakesh Pandit wrote: >>> Since commit 925a6efb8ff0c ("Btrfs: stop using >>> try_to_writeback_inodes_sb_nr to flush delalloc") this function hasn't >>>

Re: [PATCH V8 00/14] mmc: Add Command Queue support

[...] I have also run some test on my ux500 board and enabling the blkmq path via the new MMC Kconfig option. My idea was to run some iozone comparisons between the legacy path and the new blkmq path, but I just couldn't get to that point because of the following errors.

Re: [PATCH V8 00/14] mmc: Add Command Queue support

On 21 September 2017 at 11:44, Adrian Hunter wrote: > On 21/09/17 12:01, Ulf Hansson wrote: >> On 13 September 2017 at 13:40, Adrian Hunter wrote: >>> Hi >>> >>> Here is V8 of the hardware command queue patches without the software >>> command

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

On 10/10/2017 02:46, Ming Lei wrote: > > I tested this series for the SAS controller on HiSilicon hip07 platform as I > > am interested in enabling MQ for this driver. Driver is > > ./drivers/scsi/hisi_sas/. > > > > So I found that that performance is improved when enabling default SCSI_MQ > >

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

Hi John, On Tue, Oct 10, 2017 at 01:24:52PM +0100, John Garry wrote: > It's using cfq (for non-mq) and mq-deadline (obviously for mq). Please be aware that cfq and mq-deadline are _not_ comparable, for a realistic comparasion please use deadline and mq-deadline or cfq and bfq. > root@(none)$

Re: [PATCH V2 3/3] blockcg: export latency info for each cgroup

On Fri, Oct 06, 2017 at 05:56:01PM -0700, Shaohua Li wrote: > From: Shaohua Li > > Export the latency info to user. The latency is a good sign to indicate > if IO is congested or not. User can use the info to make decisions like > adjust cgroup settings. Hi Shaohua, How to check IO

Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

On 10/10/2017 12:13 PM, Shaohua Li wrote: > On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: >> From: Jiufei Xue >> >> A null pointer dereference can occur when blkcg is removed manually >> with writeback IOs inflight. This is caused by the following case: >>

Re: [PATCH V6 3/5] sbitmap: introduce __sbitmap_for_each_set()

On Mon, Oct 09, 2017 at 07:24:22PM +0800, Ming Lei wrote: > We need to iterate ctx starting from any ctx in round robin > way, so introduce this helper. > > Cc: Omar Sandoval Reviewed-by: Omar Sandoval > Signed-off-by: Ming Lei > --- >

Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: > From: Jiufei Xue > > A null pointer dereference can occur when blkcg is removed manually > with writeback IOs inflight. This is caused by the following case: > > Writeback kworker submit the bio and set

Re: [PATCH V6 5/5] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

On Mon, Oct 09, 2017 at 07:24:24PM +0800, Ming Lei wrote: > During dispatching, we moved all requests from hctx->dispatch to > one temporary list, then dispatch them one by one from this list. > Unfortunately during this period, run queue from other contexts > may think the queue is idle, then

Re: [PATCH v7 9/9] block, scsi: Make SCSI quiesce and resume work reliably

On Tue, 2017-10-10 at 18:56 +0800, Ming Lei wrote: > On Mon, Oct 09, 2017 at 04:14:00PM -0700, Bart Van Assche wrote: > > [ ... ] > > int > > scsi_device_quiesce(struct scsi_device *sdev) > > { > > + struct request_queue *q = sdev->request_queue; > > int err; > > > > + /* If the SCSI

Re: [PATCH V2 1/3] blk-stat: delete useless code

On Fri, Oct 06, 2017 at 05:55:59PM -0700, Shaohua Li wrote: > From: Shaohua Li > > Fix two issues: > - the per-cpu stat flush is unnecessary, nobody uses per-cpu stat except > sum it to global stat. We can do the calculation there. The flush just > wastes cpu time. One thing

Re: [PATCH V6 1/5] blk-mq-sched: fix scheduler bad performance

On Mon, Oct 09, 2017 at 07:24:20PM +0800, Ming Lei wrote: > When hw queue is busy, we shouldn't take requests from > scheduler queue any more, otherwise it is difficult to do > IO merge. > > This patch fixes the awful IO performance on some > SCSI devices(lpfc, qla2xxx, ...) when

Re: [PATCH V2 1/3] blk-stat: delete useless code

On 10/06/2017 06:55 PM, Shaohua Li wrote: > From: Shaohua Li > > Fix two issues: > - the per-cpu stat flush is unnecessary, nobody uses per-cpu stat except > sum it to global stat. We can do the calculation there. The flush just > wastes cpu time. > - some fields are signed

Re: [PATCH V6 4/5] blk-mq-sched: improve dispatching from sw queue

On Mon, Oct 09, 2017 at 07:24:23PM +0800, Ming Lei wrote: > SCSI devices use host-wide tagset, and the shared driver tag space is > often quite big. Meantime there is also queue depth for each lun( > .cmd_per_lun), which is often small, for example, on both lpfc and > qla2xxx, .cmd_per_lun is just

Re: [PATCH V2 3/3] blockcg: export latency info for each cgroup

On Wed, Oct 11, 2017 at 01:35:51AM +0800, weiping zhang wrote: > On Fri, Oct 06, 2017 at 05:56:01PM -0700, Shaohua Li wrote: > > From: Shaohua Li > > > > Export the latency info to user. The latency is a good sign to indicate > > if IO is congested or not. User can use the info to

Re: [PATCH] blkcg: check pol->cpd_free_fn before free cpd

On 10/10/2017 08:53 AM, weiping zhang wrote: > check pol->cpd_free_fn() instead of pol->cpd_alloc_fn() when free cpd. In practice this shouldn't make a difference, since if you have an alloc_fn, you better also have a free_fn. I'd argue a better patch would be ensuring that's the case, since the

Re: [PATCH v7 9/9] block, scsi: Make SCSI quiesce and resume work reliably

On Tue, 2017-10-10 at 09:57 +0200, Martin Steigerwald wrote: > Bart Van Assche - 09.10.17, 16:14: > > The contexts from which a SCSI device can be quiesced or resumed are: > > [ ... ] > > Does this as reliably fix the issue as the patches from Ming? I mean in *real > world* scenarios? Or is it

[PATCH] blkcg: check pol->cpd_free_fn before free cpd

check pol->cpd_free_fn() instead of pol->cpd_alloc_fn() when free cpd. Signed-off-by: weiping zhang --- block/blk-cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index d3f56ba..e7ec676 100644

[PATCH] blkcg: add sanity check for blkcg policy operations

blkcg policy should keep cpd/pd's alloc_fn and free_fn in pairs, otherwise policy would register fail. Signed-off-by: weiping zhang --- block/blk-cgroup.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/block/blk-cgroup.c

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

On 10/10/2017 14:45, Ming Lei wrote: Hi John, All change in V6.2 is blk-mq/scsi-mq only, which shouldn't affect non SCSI_MQ, so I suggest you to compare the perf between deadline and mq-deadline, like Johannes mentioned. > > V6.2 series with default SCSI_MQ > read, rw, write IOPS >

Re: [PATCH] blkcg: check pol->cpd_free_fn before free cpd

Good catch, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH] blkcg: check pol->cpd_free_fn before free cpd

On Tue, Oct 10, 2017 at 09:04:39AM -0600, Jens Axboe wrote: > On 10/10/2017 08:53 AM, weiping zhang wrote: > > check pol->cpd_free_fn() instead of pol->cpd_alloc_fn() when free cpd. > > In practice this shouldn't make a difference, since if you have an > alloc_fn, you better also have a free_fn.

Re: [PATCH V2 2/3] block: set request_list for request

On 10/06/2017 06:56 PM, Shaohua Li wrote: > From: Shaohua Li > > Legacy queue sets request's request_list, mq doesn't. This makes mq does > the same thing, so we can find cgroup of a request. Note, we really > only use blkg field of request_list, it's pointless to allocate mempool >

Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

On 10/10/2017 01:05 PM, Shaohua Li wrote: > On Tue, Oct 10, 2017 at 12:48:38PM -0600, Jens Axboe wrote: >> On 10/10/2017 12:13 PM, Shaohua Li wrote: >>> On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: From: Jiufei Xue A null pointer

Re: [PATCH] blk-throttle: fix null pointer dereference while throttling writeback IOs

On Tue, Oct 10, 2017 at 12:48:38PM -0600, Jens Axboe wrote: > On 10/10/2017 12:13 PM, Shaohua Li wrote: > > On Tue, Oct 10, 2017 at 11:13:32AM +0800, xuejiufei wrote: > >> From: Jiufei Xue > >> > >> A null pointer dereference can occur when blkcg is removed manually >

Re: [PATCH] block: add partition uuid into uevent as "PARTUUID"

Hi Konstantin, > On Oct 6, 2017, at 7:42 AM, Konstantin Khlebnikov > wrote: > > Both most common formats have uuid in addition to partition name: > GPT: standard uuid ---- > DOS: 4 byte disk signature and 1 byte partition -xx >

[PATCH v8 09/10] block, scsi: Make SCSI quiesce and resume work reliably

The contexts from which a SCSI device can be quiesced or resumed are: * Writing into /sys/class/scsi_device/*/device/state. * SCSI parallel (SPI) domain validation. * The SCSI device power management methods. See also scsi_bus_pm_ops. It is essential during suspend and resume that neither the

[PATCH v8 05/10] block: Introduce blk_get_request_flags()

A side effect of this patch is that the GFP mask that is passed to several allocation functions in the legacy block layer is changed from GFP_KERNEL into __GFP_DIRECT_RECLAIM. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Ming Lei

[PATCH v8 04/10] block: Make q_usage_counter also track legacy requests

From: Ming Lei This patch makes it possible to pause request allocation for the legacy block layer by calling blk_mq_freeze_queue() and blk_mq_unfreeze_queue(). Signed-off-by: Ming Lei [ bvanassche: Combined two patches into one, edited a comment and

[PATCH v8 03/10] md: Neither resync nor reshape while the system is frozen

Some people use the md driver on laptops and use the suspend and resume functionality. Since it is essential that submitting of new I/O requests stops before a hibernation image is created, interrupt the md resync and reshape actions if the system is being frozen. Note: the resync and reshape will

[PATCH v8 07/10] ide, scsi: Tell the block layer at request allocation time about preempt requests

Convert blk_get_request(q, op, __GFP_RECLAIM) into blk_get_request_flags(q, op, BLK_MQ_PREEMPT). This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Martin K. Petersen Acked-by: David S. Miller

[PATCH v8 00/10] block, scsi, md: Improve suspend and resume

Hello Jens, It is known that during the resume following a hibernate, especially when using an md RAID1 array created on top of SCSI devices, sometimes the system hangs instead of coming up properly. This patch series fixes that problem. These patches have been tested on top of the block layer

[PATCH v8 06/10] block: Introduce BLK_MQ_REQ_PREEMPT

Set RQF_PREEMPT if BLK_MQ_REQ_PREEMPT is passed to blk_get_request_flags(). Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Ming Lei Cc: Hannes Reinecke Cc: Johannes Thumshirn ---

[PATCH v8 02/10] md: Introduce md_stop_all_writes()

Introduce md_stop_all_writes() because the next patch will add a second caller for this function. This patch does not change any functionality. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Cc: Shaohua Li Cc:

[PATCH v8 10/10] block, nvme: Introduce blk_mq_req_flags_t

Several block layer and NVMe core functions accept a combination of BLK_MQ_REQ_* flags through the 'flags' argument but there is no verification at compile time whether the right type of block layer flags is passed. Make it possible for sparse to verify this. This patch does not change any

[PATCH v8 08/10] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag

This flag will be used in the next patch to let the block layer core know whether or not a SCSI request queue has been quiesced. A quiesced SCSI queue namely only processes RQF_PREEMPT requests. Signed-off-by: Bart Van Assche Cc: Ming Lei Cc:

[PATCH v8 01/10] md: Rename md_notifier into md_reboot_notifier

This avoids confusion with the pm notifier that will be added through a later patch. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Cc: Shaohua Li Cc: linux-r...@vger.kernel.org Cc: Ming Lei Cc:

Re: [PATCH v2 0/9] Nowait support for stacked block devices

On Fri, Oct 06, 2017 at 07:01:19AM -0500, Goldwyn Rodrigues wrote: > > > On 10/05/2017 12:19 PM, Shaohua Li wrote: > > On Wed, Oct 04, 2017 at 08:55:02AM -0500, Goldwyn Rodrigues wrote: > >> This is a continuation of the nowait support which was incorporated > >> a while back. We introduced

Re: [PATCH] bcache: fix race in setting bdev state

Tang, On 10/09/2017 10:38 PM, tang.jun...@zte.com.cn wrote: [snip] As Far as now, except this issue, I can't see any more race during detach, so I don't think we need to take a writeback lock. Could you please show me what problem you worried about? Ugh, this is partially my fault for not

Re: [PATCH] [PATCH v3] bcache: gc does not work when triggering by manual

On 2017/10/10 上午10:44, tang.jun...@zte.com.cn wrote: > From: Tang Junhui > > I try to execute the following command to trigger gc thread: > [root@localhost internal]# echo 1 > trigger_gc > But it does not work, I debug the code in gc_should_run(), It works only > if in

Re: [PATCH] bcache: fix race in setting bdev state

From: Tang Junhui Hello Mike: > One race I think I see: we unset the dirty bit before setting ourselves > interruptible. Can bch_writeback_add/queue wake writeback before then > (and then writeback sets itself interruptible and never wakes up)? > bch_writeback_add

Re: [PATCH v7 2/9] md: Introduce md_stop_all_writes()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v7 1/9] md: Rename md_notifier into md_reboot_notifier

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v7 4/9] block: Make q_usage_counter also track legacy requests

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

Re: [PATCH v8 03/10] md: Neither resync nor reshape while the system is frozen

On Tue, Oct 10, 2017 at 02:03:39PM -0700, Bart Van Assche wrote: > Some people use the md driver on laptops and use the suspend and > resume functionality. Since it is essential that submitting of > new I/O requests stops before a hibernation image is created, > interrupt the md resync and reshape

Re: [PATCH v8 03/10] md: Neither resync nor reshape while the system is frozen

On Tue, Oct 10, 2017 at 11:33:06PM +, Bart Van Assche wrote: > On Tue, 2017-10-10 at 15:30 -0700, Shaohua Li wrote: > > On Tue, Oct 10, 2017 at 02:03:39PM -0700, Bart Van Assche wrote: > > > Some people use the md driver on laptops and use the suspend and > > > resume functionality. Since it

Re: [PATCH v8 03/10] md: Neither resync nor reshape while the system is frozen

On Tue, 2017-10-10 at 15:30 -0700, Shaohua Li wrote: > On Tue, Oct 10, 2017 at 02:03:39PM -0700, Bart Van Assche wrote: > > Some people use the md driver on laptops and use the suspend and > > resume functionality. Since it is essential that submitting of > > new I/O requests stops before a