Re: [PATCH 02/11] block: Fix race of bdev open with gendisk shutdown

2017-11-20 Thread Jan Kara
Hi Tao! On Fri 17-11-17 14:51:18, Hou Tao wrote: > On 2017/3/13 23:14, Jan Kara wrote: > > blkdev_open() may race with gendisk shutdown in two different ways. > > Either del_gendisk() has already unhashed block device inode (and thus > > bd_acquire() will end up creating new block device inode)

4.14: can bcc not trace blk-mq?

2017-11-20 Thread Holger Hoffstätte
Sorry if this is a dumb question, but I've started playing with bcc (release 0.4.0) and can trace everything (cpu, xfs, net..) so it works fine - except apparently block traffic. I've tried all the bio* tools and none of them seem to trace/collect anything, despite the fact that they contain

[PATCH] block: early return from blk_queue_split() if q->bio_split is NULL

2017-11-20 Thread Mike Snitzer
DM appears to be the only block driver that doesn't lean on the block core's bio splitting. My hope is to fix that but in the meantime it doesn't make sense for a device that doesn't need blk_queue_split() to go through the associated work. Signed-off-by: Mike Snitzer ---

Re: [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Shaohua Li
On Mon, Nov 20, 2017 at 10:00:27AM +0800, Joseph Qi wrote: > From: Joseph Qi > > dm device set QUEUE_FLAG_NONROT in resume, which is after register > queue. That is to mean, the previous initialization in > blk_throtl_register_queue is wrong in this case. > Fix it by

Re: [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.

2017-11-20 Thread Mike Snitzer
On Sun, Jun 18, 2017 at 5:36 PM, NeilBrown wrote: > On Sun, Jun 18 2017, Jens Axboe wrote: > >> On Sun, Jun 18 2017, NeilBrown wrote: >>> This is a resend of my series of patches working >>> towards removing the bioset work queues. >>> >>> This set is based on for-4.13/block. >>>

Re: [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Shaohua Li
On Mon, Nov 20, 2017 at 04:02:03PM -0500, Mike Snitzer wrote: > On Sun, Nov 19, 2017 at 9:00 PM, Joseph Qi wrote: > > From: Joseph Qi > > > > dm device set QUEUE_FLAG_NONROT in resume, which is after register > > queue. That is to mean, the

Re: 4.14: can bcc not trace blk-mq?

2017-11-20 Thread Holger Hoffstätte
On Mon, 20 Nov 2017 18:19:37 +, Holger Hoffstätte wrote: > Sorry if this is a dumb question, but I've started playing with bcc > (release 0.4.0) and can trace everything (cpu, xfs, net..) so it works > fine - except apparently block traffic. I've tried all the bio* tools > and none of them

Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk

2017-11-20 Thread Jens Axboe
On 11/20/2017 12:29 PM, Christian Borntraeger wrote: > > > On 11/20/2017 08:20 PM, Bart Van Assche wrote: >> On Fri, 2017-11-17 at 15:42 +0100, Christian Borntraeger wrote: >>> This is >>> >>> b7a71e66d (Jens Axboe2017-08-01 09:28:24 -0600 1141) * >>> are mapped to it. >>>

Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk

2017-11-20 Thread Bart Van Assche
On Fri, 2017-11-17 at 15:42 +0100, Christian Borntraeger wrote: > This is > > b7a71e66d (Jens Axboe2017-08-01 09:28:24 -0600 1141) * > are mapped to it. > b7a71e66d (Jens Axboe2017-08-01 09:28:24 -0600 1142) */ > 6a83e74d2 (Bart Van Assche

Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 08:42 PM, Jens Axboe wrote: > On 11/20/2017 12:29 PM, Christian Borntraeger wrote: >> >> >> On 11/20/2017 08:20 PM, Bart Van Assche wrote: >>> On Fri, 2017-11-17 at 15:42 +0100, Christian Borntraeger wrote: This is b7a71e66d (Jens Axboe2017-08-01

Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk

2017-11-20 Thread Christian Borntraeger
On 11/20/2017 08:20 PM, Bart Van Assche wrote: > On Fri, 2017-11-17 at 15:42 +0100, Christian Borntraeger wrote: >> This is >> >> b7a71e66d (Jens Axboe2017-08-01 09:28:24 -0600 1141) * >> are mapped to it. >> b7a71e66d (Jens Axboe2017-08-01 09:28:24 -0600

Re: [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Mike Snitzer
On Sun, Nov 19, 2017 at 9:00 PM, Joseph Qi wrote: > From: Joseph Qi > > dm device set QUEUE_FLAG_NONROT in resume, which is after register > queue. That is to mean, the previous initialization in > blk_throtl_register_queue is wrong in this case.

Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk

2017-11-20 Thread Jens Axboe
On 11/20/2017 01:49 PM, Christian Borntraeger wrote: > > > On 11/20/2017 08:42 PM, Jens Axboe wrote: >> On 11/20/2017 12:29 PM, Christian Borntraeger wrote: >>> >>> >>> On 11/20/2017 08:20 PM, Bart Van Assche wrote: On Fri, 2017-11-17 at 15:42 +0100, Christian Borntraeger wrote: > This

Re: [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Mike Snitzer
On Mon, Nov 20 2017 at 4:23pm -0500, Shaohua Li wrote: > On Mon, Nov 20, 2017 at 04:02:03PM -0500, Mike Snitzer wrote: > > On Sun, Nov 19, 2017 at 9:00 PM, Joseph Qi wrote: > > > From: Joseph Qi > > > > > > dm device set

Re: [PATCH V8 6/7] sd_zbc: Initialize device request queue zoned data

2017-11-20 Thread Martin K. Petersen
Damien, > Initialize the seq_zones_bitmap, seq_zones_wlock and nr_zones fields > of the disk request queue on disk revalidate. As the seq_zones_bitmap > and seq_zones_wlock allocations are identical, introduce the helper > sd_zbc_alloc_zone_bitmap(). Using this helper, reallocate the bitmaps >

Re: [dm-devel] [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.

2017-11-20 Thread NeilBrown
On Mon, Nov 20 2017, Mike Snitzer wrote: > On Sun, Jun 18, 2017 at 5:36 PM, NeilBrown wrote: >> On Sun, Jun 18 2017, Jens Axboe wrote: >> >>> On Sun, Jun 18 2017, NeilBrown wrote: This is a resend of my series of patches working towards removing the bioset work queues.

Re: [PATCH 00/13] block: assorted cleanup for bio splitting and cloning.

2017-11-20 Thread Mike Snitzer
On Mon, Nov 20 2017 at 7:34pm -0500, NeilBrown wrote: > On Mon, Nov 20 2017, Mike Snitzer wrote: > > > On Sun, Jun 18, 2017 at 5:36 PM, NeilBrown wrote: > >> On Sun, Jun 18 2017, Jens Axboe wrote: > >> > >>> On Sun, Jun 18 2017, NeilBrown wrote: > This is

Re: [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Joseph Qi
Hi Mike, On 17/11/21 05:02, Mike Snitzer wrote: > On Sun, Nov 19, 2017 at 9:00 PM, Joseph Qi wrote: >> From: Joseph Qi >> >> dm device set QUEUE_FLAG_NONROT in resume, which is after register >> queue. That is to mean, the previous

Re: [PATCH v2 2/2] blk-throttle: fix wrong initialization in case of dm device

2017-11-20 Thread Joseph Qi
On 17/11/21 01:15, Shaohua Li wrote: > On Mon, Nov 20, 2017 at 10:00:27AM +0800, Joseph Qi wrote: >> From: Joseph Qi >> >> dm device set QUEUE_FLAG_NONROT in resume, which is after register >> queue. That is to mean, the previous initialization in >>

Re: [dm-devel] Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

2017-11-20 Thread Theodore Ts'o
On Thu, Nov 16, 2017 at 03:32:05PM -0700, Chris Murphy wrote: > > XFS by default does metadata csums. But ext4 doesn't use it for either > metadata or the journal by default still, it is still optional. So for > now it mainly benefits XFS. Metadata checksums are enabled by default in the version

Re: [RFC PATCH] blk-throttle: add burst allowance.

2017-11-20 Thread Khazhismel Kumykov
On Fri, Nov 17, 2017 at 11:26 AM, Shaohua Li wrote: > On Thu, Nov 16, 2017 at 08:25:58PM -0800, Khazhismel Kumykov wrote: >> On Thu, Nov 16, 2017 at 8:50 AM, Shaohua Li wrote: >> > On Tue, Nov 14, 2017 at 03:10:22PM -0800, Khazhismel Kumykov wrote: >> >> Allows