Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 9:05 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 08:48:55AM -0700, Jens Axboe wrote: >> On 1/19/18 8:40 AM, Ming Lei wrote: >> Where does the dm STS_RESOURCE error usually come from - what's exact >> resource are we running out of? > > It is from

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 8:20 AM, Bart Van Assche wrote: > On Fri, 2018-01-19 at 15:26 +0800, Ming Lei wrote: >> Please see queue_delayed_work_on(), hctx->run_work is shared by all >> scheduling, once blk_mq_delay_run_hw_queue(100ms) returns, no new >> scheduling can make progress during the 100ms. > > How

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: > On 1/19/18 9:05 AM, Ming Lei wrote: > > On Fri, Jan 19, 2018 at 08:48:55AM -0700, Jens Axboe wrote: > >> On 1/19/18 8:40 AM, Ming Lei wrote: > >> Where does the dm STS_RESOURCE error usually come from - what's exact > >>

[PATCH 3/3] block: Remove kblockd_schedule_delayed_work{,_on}()

The previous patch removed all users of these two functions. Hence also remove the functions themselves. Signed-off-by: Bart Van Assche --- block/blk-core.c | 14 -- include/linux/blkdev.h | 2 -- 2 files changed, 16 deletions(-) diff --git

[PATCH 0/3] Avoid that blk_mq_delay_run_hw_queue() introduces unintended delays

Hello Jens, Earlier today it was agreed that a blk_mq_delay_run_hw_queue() call followed by a blk_mq_run_hw_queue() call should result in an immediate queue run. Hence this patch series. Please consider this patch series for kernel v4.16. Thanks, Bart. Bart Van Assche (3): blk-mq: Rename

[PATCH 2/3] blk-mq: Avoid that blk_mq_delay_run_hw_queue() introduces unintended delays

Make sure that calling blk_mq_run_hw_queue() or blk_mq_kick_requeue_list() triggers a queue run without delay even if blk_mq_delay_run_hw_queue() has been called recently and if its delay has not yet expired. Signed-off-by: Bart Van Assche --- block/blk-mq.c | 7 +++

[PATCH 1/3] blk-mq: Rename blk_mq_request_direct_issue() into blk_mq_request_issue_directly()

Most blk-mq functions have a name that follows the pattern blk_mq_${action}. However, the function name blk_mq_request_direct_issue is an exception. Hence rename this function. This patch does not change any functionality. Signed-off-by: Bart Van Assche ---

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 08:24:06AM -0700, Jens Axboe wrote: > On 1/19/18 12:26 AM, Ming Lei wrote: > > On Thu, Jan 18, 2018 at 09:02:45PM -0700, Jens Axboe wrote: > >> On 1/18/18 7:32 PM, Ming Lei wrote: > >>> On Thu, Jan 18, 2018 at 01:11:01PM -0700, Jens Axboe wrote: > On 1/18/18 11:47 AM,

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 9:37 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: >> On 1/19/18 9:26 AM, Ming Lei wrote: >>> On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: On 1/19/18 9:05 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 08:48:55AM -0700, Jens

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 09:52:32AM -0700, Jens Axboe wrote: > On 1/19/18 9:47 AM, Mike Snitzer wrote: > > On Fri, Jan 19 2018 at 11:41am -0500, > > Jens Axboe wrote: > > > >> On 1/19/18 9:37 AM, Ming Lei wrote: > >>> On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: >

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 08:48:55AM -0700, Jens Axboe wrote: > On 1/19/18 8:40 AM, Ming Lei wrote: > Where does the dm STS_RESOURCE error usually come from - what's exact > resource are we running out of? > >>> > >>> It is from blk_get_request(underlying queue), see > >>>

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 9:26 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: >> On 1/19/18 9:05 AM, Ming Lei wrote: >>> On Fri, Jan 19, 2018 at 08:48:55AM -0700, Jens Axboe wrote: On 1/19/18 8:40 AM, Ming Lei wrote: Where does the dm STS_RESOURCE error usually

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19 2018 at 11:41am -0500, Jens Axboe wrote: > On 1/19/18 9:37 AM, Ming Lei wrote: > > On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: > >> On 1/19/18 9:26 AM, Ming Lei wrote: > >>> On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: > >> > >>

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 8:40 AM, Ming Lei wrote: Where does the dm STS_RESOURCE error usually come from - what's exact resource are we running out of? >>> >>> It is from blk_get_request(underlying queue), see >>> multipath_clone_and_map(). >> >> That's what I thought. So for a low queue depth

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19 2018 at 10:48am -0500, Jens Axboe wrote: > On 1/19/18 8:40 AM, Ming Lei wrote: > Where does the dm STS_RESOURCE error usually come from - what's exact > resource are we running out of? > >>> > >>> It is from blk_get_request(underlying queue), see > >>>

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 9:13 AM, Mike Snitzer wrote: > On Fri, Jan 19 2018 at 10:48am -0500, > Jens Axboe wrote: > >> On 1/19/18 8:40 AM, Ming Lei wrote: >> Where does the dm STS_RESOURCE error usually come from - what's exact >> resource are we running out of? > > It is from

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: > On 1/19/18 9:26 AM, Ming Lei wrote: > > On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: > >> On 1/19/18 9:05 AM, Ming Lei wrote: > >>> On Fri, Jan 19, 2018 at 08:48:55AM -0700, Jens Axboe wrote: > On 1/19/18 8:40 AM,

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 12:26 AM, Ming Lei wrote: > On Thu, Jan 18, 2018 at 09:02:45PM -0700, Jens Axboe wrote: >> On 1/18/18 7:32 PM, Ming Lei wrote: >>> On Thu, Jan 18, 2018 at 01:11:01PM -0700, Jens Axboe wrote: On 1/18/18 11:47 AM, Bart Van Assche wrote: >> This is all very tiresome. > >

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, 2018-01-19 at 23:33 +0800, Ming Lei wrote: > On Fri, Jan 19, 2018 at 03:20:13PM +, Bart Van Assche wrote: > > On Fri, 2018-01-19 at 15:26 +0800, Ming Lei wrote: > > > Please see queue_delayed_work_on(), hctx->run_work is shared by all > > > scheduling, once

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 9:47 AM, Mike Snitzer wrote: > On Fri, Jan 19 2018 at 11:41am -0500, > Jens Axboe wrote: > >> On 1/19/18 9:37 AM, Ming Lei wrote: >>> On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: On 1/19/18 9:26 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 03:20:13PM +, Bart Van Assche wrote: > On Fri, 2018-01-19 at 15:26 +0800, Ming Lei wrote: > > Please see queue_delayed_work_on(), hctx->run_work is shared by all > > scheduling, once blk_mq_delay_run_hw_queue(100ms) returns, no new > > scheduling can make progress

Re: [PATCH v2] bdi: show error log when fail to create bdi debugfs entry

2018-01-11 0:36 GMT+08:00 weiping zhang : > bdi debugfs dir/file may create fail, add error log here. > > Signed-off-by: weiping zhang > --- > V1->V2: > fix indentation and make log message more clear > > mm/backing-dev.c | 4 +++- > 1

Re: [PATCH] lib/scatterlist: Fix chaining support in sgl_alloc_order()

On 1/19/18 12:00 PM, Bart Van Assche wrote: > This patch avoids that workloads with large block sizes (megabytes) > can trigger the following call stack with the ib_srpt driver (that > driver is the only driver that chains scatterlists allocated by > sgl_alloc_order()): > > BUG: Bad page state in

[PATCH] blk-throttle: use queue_is_rq_based

use queue_is_rq_based instead of open code. Signed-off-by: weiping zhang --- block/blk-throttle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 96ad326..457e985 100644 ---

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 10:38:41AM -0700, Jens Axboe wrote: > On 1/19/18 9:37 AM, Ming Lei wrote: > > On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: > >> On 1/19/18 9:26 AM, Ming Lei wrote: > >>> On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: > On 1/19/18 9:05 AM,

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19 2018 at 12:38pm -0500, Jens Axboe wrote: > On 1/19/18 9:37 AM, Ming Lei wrote: > > On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: > >> > >> There are no pending requests for this case, nothing to restart the > >> queue. When you fail that

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 10:09:11AM -0700, Jens Axboe wrote: > On 1/19/18 10:05 AM, Ming Lei wrote: > > On Fri, Jan 19, 2018 at 09:52:32AM -0700, Jens Axboe wrote: > >> On 1/19/18 9:47 AM, Mike Snitzer wrote: > >>> On Fri, Jan 19 2018 at 11:41am -0500, > >>> Jens Axboe wrote: >

Re: [PATCH 2/3] blk-mq: Avoid that blk_mq_delay_run_hw_queue() introduces unintended delays

On Fri, Jan 19 2018 at 11:58am -0500, Bart Van Assche wrote: > Make sure that calling blk_mq_run_hw_queue() or > blk_mq_kick_requeue_list() triggers a queue run without delay even > if blk_mq_delay_run_hw_queue() has been called recently and if its > delay has not yet

Re: [PATCH 1/3] blk-mq: Rename blk_mq_request_direct_issue() into blk_mq_request_issue_directly()

On Fri, Jan 19 2018 at 11:58am -0500, Bart Van Assche wrote: > Most blk-mq functions have a name that follows the pattern blk_mq_${action}. > However, the function name blk_mq_request_direct_issue is an exception. > Hence rename this function. This patch does not change

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 9:37 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: >> On 1/19/18 9:26 AM, Ming Lei wrote: >>> On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: On 1/19/18 9:05 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 08:48:55AM -0700, Jens

[PATCH] lib/scatterlist: Fix chaining support in sgl_alloc_order()

This patch avoids that workloads with large block sizes (megabytes) can trigger the following call stack with the ib_srpt driver (that driver is the only driver that chains scatterlists allocated by sgl_alloc_order()): BUG: Bad page state in process kworker/0:1H pfn:2423a78 page:fb03d08e9e00

[GIT PULL] additional nvme fixes and cleanups for Linux 4.16

The following changes since commit bf9ae8c5325c0070d0ec81a849bba8d156f65993: blk-mq: fix bad clear of RQF_MQ_INFLIGHT in blk_mq_ct_ctx_init() (2018-01-14 10:46:24 -0700) are available in the git repository at: git://git.infradead.org/nvme.git nvme-4.16 for you to fetch changes up to

Re: [PATCH 3/3] block: Remove kblockd_schedule_delayed_work{,_on}()

On Fri, Jan 19 2018 at 11:58am -0500, Bart Van Assche wrote: > The previous patch removed all users of these two functions. Hence > also remove the functions themselves. > > Signed-off-by: Bart Van Assche Reviewed-by: Mike Snitzer

Re: [PATCH] lib/scatterlist: Fix chaining support in sgl_alloc_order()

On Fri, 2018-01-19 at 11:00 -0800, Bart Van Assche wrote: > This patch avoids that workloads with large block sizes (megabytes) > can trigger the following call stack with the ib_srpt driver (that > driver is the only driver that chains scatterlists allocated by > sgl_alloc_order()): > > BUG: Bad

Re: [GIT PULL] additional nvme fixes and cleanups for Linux 4.16

On 1/19/18 12:02 PM, Christoph Hellwig wrote: > The following changes since commit bf9ae8c5325c0070d0ec81a849bba8d156f65993: > > blk-mq: fix bad clear of RQF_MQ_INFLIGHT in blk_mq_ct_ctx_init() > (2018-01-14 10:46:24 -0700) > > are available in the git repository at: > >

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, 2018-01-19 at 15:34 +0800, Ming Lei wrote: > Could you explain a bit when SCSI target replies with BUSY very often? > > Inside initiator, we have limited the max per-LUN requests and per-host > requests already before calling .queue_rq(). That's correct. However, when a SCSI initiator

Hello There

UNSECURED BUSINESS/PERSONAL LOAN BY LOAN CAPITAL FINANCE - NO COLLATERAL - MINIMUM DOCUMENTATION - BUSINESS LOAN UP TO FIVE(5) MILLION US DOLLARS CONTACT US TODAY VIA EMAIL: financecapital...@mail.com --- This email has been checked for viruses by Avast antivirus

Re: [PATCH v2] bdi: show error log when fail to create bdi debugfs entry

On 1/19/18 10:36 AM, weiping zhang wrote: > 2018-01-11 0:36 GMT+08:00 weiping zhang : >> bdi debugfs dir/file may create fail, add error log here. >> >> Signed-off-by: weiping zhang >> --- >> V1->V2: >> fix indentation and make log

Re: [PATCH 0/3] Avoid that blk_mq_delay_run_hw_queue() introduces unintended delays

On 1/19/18 9:58 AM, Bart Van Assche wrote: > Hello Jens, > > Earlier today it was agreed that a blk_mq_delay_run_hw_queue() call followed > by a blk_mq_run_hw_queue() call should result in an immediate queue run. Hence > this patch series. Please consider this patch series for kernel v4.16.

Re: [PATCH] blk-throttle: use queue_is_rq_based

On 1/19/18 10:40 AM, weiping zhang wrote: > use queue_is_rq_based instead of open code. > > Signed-off-by: weiping zhang > --- > block/blk-throttle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-throttle.c

Re: [PATCH v2] bdi: show error log when fail to create bdi debugfs entry

2018-01-20 3:54 GMT+08:00 Jens Axboe : > On 1/19/18 10:36 AM, weiping zhang wrote: >> 2018-01-11 0:36 GMT+08:00 weiping zhang : >>> bdi debugfs dir/file may create fail, add error log here. >>> >>> Signed-off-by: weiping zhang

Re: [PATCH] blk-throttle: use queue_is_rq_based

2018-01-20 3:58 GMT+08:00 Jens Axboe : > On 1/19/18 10:40 AM, weiping zhang wrote: >> use queue_is_rq_based instead of open code. >> >> Signed-off-by: weiping zhang >> --- >> block/blk-throttle.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 10:38:41AM -0700, Jens Axboe wrote: > On 1/19/18 9:37 AM, Ming Lei wrote: > > On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: > >> On 1/19/18 9:26 AM, Ming Lei wrote: > >>> On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens Axboe wrote: > On 1/19/18 9:05 AM,

[PATCH v2] blk-throttle: use queue_is_rq_based

use queue_is_rq_based instead of open code. Signed-off-by: weiping zhang --- block/blk-throttle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index e136f5e..c475f0f 100644 ---

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On Fri, Jan 19, 2018 at 09:23:35AM -0700, Jens Axboe wrote: > On 1/19/18 9:13 AM, Mike Snitzer wrote: > > On Fri, Jan 19 2018 at 10:48am -0500, > > Jens Axboe wrote: > > > >> On 1/19/18 8:40 AM, Ming Lei wrote: > >> Where does the dm STS_RESOURCE error usually come from -

Re: [RFC PATCH] blk-mq: fixup RESTART when queue becomes idle

On 1/19/18 4:52 PM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 10:38:41AM -0700, Jens Axboe wrote: >> On 1/19/18 9:37 AM, Ming Lei wrote: >>> On Fri, Jan 19, 2018 at 09:27:46AM -0700, Jens Axboe wrote: On 1/19/18 9:26 AM, Ming Lei wrote: > On Fri, Jan 19, 2018 at 09:19:24AM -0700, Jens