Re: INFO: task hung in wb_shutdown (2)

On 5/1/18 10:06 AM, Linus Torvalds wrote: > On Tue, May 1, 2018 at 3:27 AM Tetsuo Handa < > penguin-ker...@i-love.sakura.ne.jp> wrote: > >> Can you review this patch? syzbot has hit this bug for nearly 4000 times > but >> is still unable to find a reproducer. Therefore, the only way to test >

Re: INFO: task hung in wb_shutdown (2)

>From 1b90d7f71d60e743c69cdff3ba41edd1f9f86f93 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Wed, 2 May 2018 07:07:55 +0900 Subject: [PATCH v2] bdi: wake up concurrent wb_shutdown() callers. syzbot is reporting hung tasks at wait_on_bit(WB_shutting_down)

Re: [PATCH] bsg referencing bus driver module

Any comments on the new patch (which, I think, addresses the concern about module being stuck in unloadable state forever; if not, there would be a leak in the bsg layer)? Or on dropping a reference to bsg_class_device's parent early before the bsg_class_device itself is gone, to implement James's

Re: [PATCH V2 5/5] nvme: pci: simplify timeout handling

Hi Ming On 05/02/2018 12:54 PM, Ming Lei wrote: >> We need to return BLK_EH_RESET_TIMER in nvme_timeout then: >> 1. defer the completion. we can't unmap the io request before close the >> controller totally, so not BLK_EH_HANDLED. >> 2. nvme_cancel_request could complete it.

Re: [PATCH V2 1/5] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout()

Hi Ming On 05/02/2018 11:33 AM, Ming Lei wrote: > No, there isn't such race, the 'mod_timer' doesn't make a difference > because 'q->timeout_off' will be visible in new work func after > cancel_work_sync() returns. So even the timer is expired, work func > still returns immediately. Yes, you are

Re: [PATCH V2 1/5] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout()

On Wed, May 02, 2018 at 10:23:35AM +0800, jianchao.wang wrote: > Hi ming > > On 04/29/2018 11:41 PM, Ming Lei wrote: > > > > +static void __blk_unquiesce_timeout(struct request_queue *q) > > +{ > > + unsigned long flags; > > + > > + spin_lock_irqsave(q->queue_lock, flags); > > +

Re: [PATCH V2 1/5] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout()

Hi ming On 04/29/2018 11:41 PM, Ming Lei wrote: > > +static void __blk_unquiesce_timeout(struct request_queue *q) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(q->queue_lock, flags); > + q->timeout_off = false; > + spin_unlock_irqrestore(q->queue_lock, flags); > +} > +

Re: [PATCH V2 5/5] nvme: pci: simplify timeout handling

Hi Ming On 04/29/2018 11:41 PM, Ming Lei wrote: > + > static enum blk_eh_timer_return nvme_timeout(struct request *req, bool > reserved) > { > struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > @@ -1197,8 +1297,7 @@ static enum blk_eh_timer_return nvme_timeout(struct > request *req, bool

Re: [PATCH] A tentative patch to bypass REQ_META in blk throttle

Hi Tejun, On Thu, Apr 26, 2018 at 12:01:18PM -0700, Tejun Heo wrote: > Hello, > > On Fri, Apr 20, 2018 at 06:06:01PM +0800, Benlong Zhang wrote: > > One problem with cgwb is how fs should treat metadata bios. > > For example in xfs, the log might be partially stuck in one > > group, leaving

Re: [PATCH 2/2] xfs: add 'discard_sync' mount flag

Jens, > diff --git a/block/blk-wbt.h b/block/blk-wbt.h > index a232c98fbf4d..aec5bc82d580 100644 > --- a/block/blk-wbt.h > +++ b/block/blk-wbt.h > @@ -14,12 +14,17 @@ enum wbt_flags { > WBT_TRACKED = 1,/* write, tracked for throttling */ > WBT_READ= 2,

Re: [PATCH V2 5/5] nvme: pci: simplify timeout handling

On Wed, May 02, 2018 at 10:23:20AM +0800, jianchao.wang wrote: > Hi Ming > > On 04/29/2018 11:41 PM, Ming Lei wrote: > > + > > static enum blk_eh_timer_return nvme_timeout(struct request *req, bool > > reserved) > > { > > struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > > @@ -1197,8 +1297,7

Re: [PATCH 4/4] iomap: Use FUA for pure data O_DSYNC DIO writes

On Tue, Apr 24, 2018 at 10:34:44AM -0700, Christoph Hellwig wrote: > On Sat, Apr 21, 2018 at 02:54:05PM +0200, Jan Kara wrote: > > > - if (iocb->ki_flags & IOCB_DSYNC) > > > + if (iocb->ki_flags & IOCB_DSYNC) { > > > dio->flags |= IOMAP_DIO_NEED_SYNC; > > > +

Re: [PATCH 2/4] iomap: iomap_dio_rw() handles all sync writes

On Sat, Apr 21, 2018 at 03:03:09PM +0200, Jan Kara wrote: > On Wed 18-04-18 14:08:26, Dave Chinner wrote: > > From: Dave Chinner > > > > Currently iomap_dio_rw() only handles (data)sync write completions > > for AIO. This means we can't optimised non-AIO IO to minimise

Re: [Xen-devel] [PATCH 6/6] xen-blkfront: prepare request locally, only then put it on the shared ring

On Tue, May 01, 2018 at 09:22:31AM +0100, Roger Pau Monné wrote: > On Mon, Apr 30, 2018 at 11:01:50PM +0200, Marek Marczykowski-Górecki wrote: > > struct request *req, > > - struct blkif_request **ring_req) > > +

Re: [PATCH 6/6] xen-blkfront: prepare request locally, only then put it on the shared ring

On Mon, Apr 30, 2018 at 11:01:50PM +0200, Marek Marczykowski-Górecki wrote: > Do not reuse data which theoretically might be already modified by the > backend. This is mostly about private copy of the request > (info->shadow[id].req) - make sure the request saved there is really the > one just

Re: [PATCH 2/2] xfs: add 'discard_sync' mount flag

On Tue, May 01, 2018 at 09:23:20AM +1000, Dave Chinner wrote: > On Mon, Apr 30, 2018 at 05:00:14PM -0600, Jens Axboe wrote: > > On 4/30/18 4:40 PM, Jens Axboe wrote: > > > On 4/30/18 4:28 PM, Dave Chinner wrote: > > >> Yes, it does, but so would having the block layer to throttle device > > >>

Re: INFO: task hung in wb_shutdown (2)

Tejun, Jan, Jens, Can you review this patch? syzbot has hit this bug for nearly 4000 times but is still unable to find a reproducer. Therefore, the only way to test would be to apply this patch upstream and test whether the problem is solved. On 2018/04/24 21:19, Tetsuo Handa wrote: >>From

Re: INFO: task hung in wb_shutdown (2)

On Tue, May 1, 2018 at 3:27 AM Tetsuo Handa < penguin-ker...@i-love.sakura.ne.jp> wrote: > Can you review this patch? syzbot has hit this bug for nearly 4000 times but > is still unable to find a reproducer. Therefore, the only way to test would be > to apply this patch upstream and test whether

Re: [PATCH 2/2] xfs: add 'discard_sync' mount flag

On 4/30/18 5:23 PM, Dave Chinner wrote: > On Mon, Apr 30, 2018 at 05:00:14PM -0600, Jens Axboe wrote: >> On 4/30/18 4:40 PM, Jens Axboe wrote: >>> On 4/30/18 4:28 PM, Dave Chinner wrote: Yes, it does, but so would having the block layer to throttle device discard requests in flight to a

Re: INFO: task hung in wb_shutdown (2)

On 5/1/18 4:27 AM, Tetsuo Handa wrote: > Tejun, Jan, Jens, > > Can you review this patch? syzbot has hit this bug for nearly 4000 times but > is still unable to find a reproducer. Therefore, the only way to test would be > to apply this patch upstream and test whether the problem is solved. I'll