[PATCH] blktests: Add '--outdir' to store results in a different directory

2018-07-17 Thread Hannes Reinecke
Adding an option '--outdir' to store results in a different director so as not to clutter the git repository itself. Signed-off-by: Hannes Reinecke --- check | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/check b/check index a635531..42d07f8 100755 ---

[PATCH 1/2] blktests: enable ANA support

2018-07-17 Thread Hannes Reinecke
Update nvme functions to support ANA. Signed-off-by: Hannes Reinecke --- tests/nvme/rc | 49 ++--- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/tests/nvme/rc b/tests/nvme/rc index fb5dbdf..116661d 100644 --- a/tests/nvme/rc +++

[PATCH 0/2] blktests: test ANA base support

2018-07-17 Thread Hannes Reinecke
Hi all, here's a small patchset for testing ANA base support. The test itself requires the ANA patchset from Christoph, plus the fixes I've sent to the mailing list earlier. Hannes Reinecke (2): blktests: enable ANA support blktests: add test for ANA state transition tests/nvme/014 |

[PATCH 2/2] blktests: add test for ANA state transition

2018-07-17 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- tests/nvme/014 | 158 + tests/nvme/014.out | 17 ++ 2 files changed, 175 insertions(+) create mode 100755 tests/nvme/014 create mode 100644 tests/nvme/014.out diff --git a/tests/nvme/014

Re: [PATCH 2/2] blktests: add test for ANA state transition

2018-07-17 Thread Johannes Thumshirn
On Tue, Jul 17, 2018 at 03:31:18PM +0200, Hannes Reinecke wrote: > +requires() { > + _have_program nvme && _have_module nvme-loop && _have_module loop && \ > + _have_configfs && _have_fio > +} this needs '_have_module_param nvme-core multipath' as well. -- Johannes Thumshirn

RE: [PATCH] blk-mq: issue directly if hw queue isn't busy in case of 'none'

2018-07-17 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Tuesday, July 10, 2018 6:34 AM > To: Jens Axboe > Cc: linux-block@vger.kernel.org; Ming Lei; Kashyap Desai; Laurence Oberman; > Omar Sandoval; Christoph Hellwig; Bart Van Assche; Hannes Reinecke > Subject: [PATCH]

Re: [PATCH] blk-mq: issue directly if hw queue isn't busy in case of 'none'

2018-07-17 Thread Jens Axboe
On 7/9/18 7:03 PM, Ming Lei wrote: > In case of 'none' io scheduler, when hw queue isn't busy, it isn't > necessary to enqueue request to sw queue and dequeue it from > sw queue because request may be submitted to hw queue asap without > extra cost, meantime there shouldn't be much request in sw

Re: Silent data corruption in blkdev_direct_IO()

2018-07-17 Thread Martin Wilck
On Mon, 2018-07-16 at 19:45 +0800, Ming Lei wrote: > On Sat, Jul 14, 2018 at 6:29 AM, Martin Wilck > wrote: > > Hi Ming & Jens, > > > > On Fri, 2018-07-13 at 12:54 -0600, Jens Axboe wrote: > > > On 7/12/18 5:29 PM, Ming Lei wrote: > > > > > > > > Maybe you can try the following patch from

Re: Silent data corruption in blkdev_direct_IO()

2018-07-17 Thread Ming Lei
On Wed, Jul 18, 2018 at 02:07:28AM +0200, Martin Wilck wrote: > On Mon, 2018-07-16 at 19:45 +0800, Ming Lei wrote: > > On Sat, Jul 14, 2018 at 6:29 AM, Martin Wilck > > wrote: > > > Hi Ming & Jens, > > > > > > On Fri, 2018-07-13 at 12:54 -0600, Jens Axboe wrote: > > > > On 7/12/18 5:29 PM, Ming

[PATCH 3/3] blk-mq: Enable support for runtime power management

2018-07-17 Thread Bart Van Assche
Now that the blk-mq core processes power management requests (marked with RQF_PREEMPT) in other states than RPM_ACTIVE, enable runtime power management for blk-mq. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Ming Lei Cc: Alan Stern Cc: Johannes Thumshirn --- block/blk-core.c |

[PATCH 0/3] blk-mq: Enable runtime power management

2018-07-17 Thread Bart Van Assche
Hello Jens, This patch series not only enables runtime power management for blk-mq but also simplifies power management for the legacy block layer. Please consider this patch series for kernel v4.19 (I am aware that you are on vacation). Thanks, Bart. Bart Van Assche (3): block: Fix a

[PATCH 2/3] block, scsi: Rework runtime power management

2018-07-17 Thread Bart Van Assche
Instead of allowing requests that are not power management requests to enter the queue in runtime suspended status (RPM_SUSPENDED), make the blk_get_request() caller block. This change fixes a starvation issue: it is now guaranteed that power management requests will be executed no matter how many