Re: [PATCH] blk-mq: provider helper for setting up an SQ queue and tag set

2018-10-16 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH, RFC] ubd: remove use of blk_rq_map_sg

2018-10-16 Thread Richard Weinberger
Am Dienstag, 16. Oktober 2018, 04:19:51 CEST schrieb Jens Axboe: > On 10/15/18 4:44 PM, Richard Weinberger wrote: > > Am Dienstag, 16. Oktober 2018, 00:04:20 CEST schrieb Jens Axboe: > >> On 10/15/18 3:46 PM, Richard Weinberger wrote: > >>> Am Montag, 15. Oktober 2018, 22:55:29 CEST schrieb

Re: [PATCH v2] block: BFQ default for single queue devices

2018-10-16 Thread Jens Axboe
On 10/15/18 1:44 PM, Paolo Valente wrote: > > >> Il giorno 15 ott 2018, alle ore 21:26, Jens Axboe ha >> scritto: >> >> On 10/15/18 12:26 PM, Paolo Valente wrote: >>> >>> Il giorno 15 ott 2018, alle ore 17:39, Jens Axboe ha scritto: On 10/15/18 8:10 AM, Linus Walleij

Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks

2018-10-16 Thread Omar Sandoval
On Tue, Oct 16, 2018 at 01:36:54PM +0200, Jan Kara wrote: > On Wed 10-10-18 14:28:09, Jan Kara wrote: > > On Wed 10-10-18 13:42:27, Johannes Thumshirn wrote: > > > On Wed, Oct 10, 2018 at 07:19:00PM +0900, Tetsuo Handa wrote: > > > > On 2018/10/10 19:04, Jan Kara wrote: > > > > > Hi, > > > > > >

Re: [PATCH v2] block: BFQ default for single queue devices

2018-10-16 Thread Paolo Valente
> Il giorno 16 ott 2018, alle ore 18:14, Federico Motta ha > scritto: > > On 10/15/18 5:02 PM, Bart Van Assche wrote: >> On Mon, 2018-10-15 at 16:10 +0200, Linus Walleij wrote: >>> + * For blk-mq devices, we default to using: >>> + * - "none" for multiqueue devices (nr_hw_queues != 1) >>> +

Re: [PATCH, RFC] ubd: remove use of blk_rq_map_sg

2018-10-16 Thread Richard Weinberger
On Mon, Oct 15, 2018 at 8:56 AM Christoph Hellwig wrote: > > There is no good reason to create a scatterlist in the ubd driver, > it can just iterate the request directly. BTW: Does it make sense to drop blk_rq_map_sq from() drivers/mtd/ubi/block.c too? If so we have to allocate a temporary

Re: [PATCH v2] block: BFQ default for single queue devices

2018-10-16 Thread Paolo Valente
> Il giorno 15 ott 2018, alle ore 20:34, Paolo Valente > ha scritto: > > > >> Il giorno 15 ott 2018, alle ore 17:02, Bart Van Assche >> ha scritto: >> >> On Mon, 2018-10-15 at 16:10 +0200, Linus Walleij wrote: >>> + * For blk-mq devices, we default to using: >>> + * - "none" for

Re: [PATCH v2] block: BFQ default for single queue devices

2018-10-16 Thread Ulf Hansson
On 15 October 2018 at 16:10, Linus Walleij wrote: > This sets BFQ as the default scheduler for single queue > block devices (nr_hw_queues == 1) if it is available. This > affects notably MMC/SD-cards but also UBI and the loopback > device. > > I have been running it for a while without any

Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks

2018-10-16 Thread Jan Kara
On Wed 10-10-18 14:28:09, Jan Kara wrote: > On Wed 10-10-18 13:42:27, Johannes Thumshirn wrote: > > On Wed, Oct 10, 2018 at 07:19:00PM +0900, Tetsuo Handa wrote: > > > On 2018/10/10 19:04, Jan Kara wrote: > > > > Hi, > > > > > > > > this patch series fixes oops and possible deadlocks as reported

Re: [PATCH 0/15 v2] loop: Fix oops and possible deadlocks

2018-10-16 Thread Johannes Thumshirn
On 16/10/18 13:36, Jan Kara wrote: [...] > 2) For the oops (use-after-free) issue I was not able to reproduce that in > my test KVM in couple hours. The race window is rather narrow and syzbot > with KASAN and everything hit it only 11 times. So I'm not sure how useful > that test is. Any

Re: [PATCH, RFC] ubd: remove use of blk_rq_map_sg

2018-10-16 Thread Jens Axboe
On 10/16/18 2:38 AM, Richard Weinberger wrote: > Am Dienstag, 16. Oktober 2018, 04:19:51 CEST schrieb Jens Axboe: >> On 10/15/18 4:44 PM, Richard Weinberger wrote: >>> Am Dienstag, 16. Oktober 2018, 00:04:20 CEST schrieb Jens Axboe: On 10/15/18 3:46 PM, Richard Weinberger wrote: > Am

Re: [PATCH v2] block: BFQ default for single queue devices

2018-10-16 Thread Federico Motta
On 10/15/18 5:02 PM, Bart Van Assche wrote: > On Mon, 2018-10-15 at 16:10 +0200, Linus Walleij wrote: >> + * For blk-mq devices, we default to using: >> + * - "none" for multiqueue devices (nr_hw_queues != 1) >> + * - "bfq", if available, for single queue devices >> + * - "mq-deadline" if "bfq" is