Re: [PATCH 11/13] nvme: switch to use pci_alloc_irq_vectors

2016-09-23 Thread Sagi Grimberg
On 14/09/16 07:18, Christoph Hellwig wrote: Use the new helper to automatically select the right interrupt type, as well as to use the automatic interupt affinity assignment. Patch title and the change description are a little short IMO to describe what is going on here (need the blk-mq side

Re: [PATCH 1/2] blk-mq: get rid of manual run of queue with __blk_mq_run_hw_queue()

2016-09-23 Thread Sagi Grimberg
--- From c69bf02929d9c37d193b004a4c3c85c1142fa996 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 22 Sep 2016 11:38:23 -0700 Subject: blk-mq: remove non-blocking pass in blk_mq_map_request bt_get already does a non-blocking pass as well as running the queue when

Re: [PATCH 1/2] blk-mq: get rid of manual run of queue with __blk_mq_run_hw_queue()

2016-09-23 Thread Sagi Grimberg
Looks good, Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [rfc] weirdness in bio_map_user_iov()

2016-09-23 Thread Sagi Grimberg
Hey Al, What happens if we feed it a 3-element iovec array, one page in each? AFAICS, bio_add_pc_page() is called for each of those pages, even if the previous calls have failed - break is only out of the inner loop. Sure, failure due to exceeded request size means that everything after that

[GIT PULL] Final block fixes for 4.8

2016-09-23 Thread Jens Axboe
Hi Linus, Three fixes, two regressions and one that poses a problem in blk-mq with the new nvmef code. Please pull! git://git.kernel.dk/linux-block.git for-linus Christoph Hellwig (1): blk-mq: skip unmapped queues in

Re: [PATCH] blkcg: Annotate blkg_hint correctly

2016-09-23 Thread Jens Axboe
On 09/23/2016 10:07 AM, Bart Van Assche wrote: Avoid that sparse complains about blkg_hint manipulations. Fixes: a637120e4902 ("blkcg: use radix tree to index blkgs from blkcg") Signed-off-by: Bart Van Assche Cc: Tejun Heo Applied for 4.9,

Re: [PATCH] blkcg: Annotate blkg_hint correctly

2016-09-23 Thread Tejun Heo
On Fri, Sep 23, 2016 at 09:07:56AM -0700, Bart Van Assche wrote: > Avoid that sparse complains about blkg_hint manipulations. > > Fixes: a637120e4902 ("blkcg: use radix tree to index blkgs from blkcg") > Signed-off-by: Bart Van Assche > Cc: Tejun Heo

[PATCH] blk-mq: skip unmapped queues in blk_mq_alloc_request_hctx

2016-09-23 Thread Christoph Hellwig
This provides the caller a feedback that a given hctx is not mapped and thus no command can be sent on it. Signed-off-by: Christoph Hellwig Tested-by: Steve Wise --- block/blk-mq.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-)

[PATCH] blkcg: Annotate blkg_hint correctly

2016-09-23 Thread Bart Van Assche
Avoid that sparse complains about blkg_hint manipulations. Fixes: a637120e4902 ("blkcg: use radix tree to index blkgs from blkcg") Signed-off-by: Bart Van Assche Cc: Tejun Heo --- include/linux/blk-cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] cfq: fix starvation of asynchronous writes

2016-09-23 Thread Jens Axboe
On 09/22/2016 08:10 PM, Jens Axboe wrote: On 09/22/2016 06:59 PM, Glauber Costa wrote: While debugging timeouts happening in my application workload (ScyllaDB), I have observed calls to open() taking a long time, ranging everywhere from 2 seconds - the first ones that are enough to time out my

Re: [PATCH] cfq: fix starvation of asynchronous writes

2016-09-23 Thread Glauber Costa
On Fri, Sep 23, 2016 at 7:28 AM, Glauber Costa wrote: > On Sep 23, 2016 6:22 AM, "Paolo Valente" wrote: >> >> >> > Il giorno 23 set 2016, alle ore 02:59, Glauber Costa >> > ha scritto: >> > >> > While debugging timeouts