Re: [PATCH] block: fix unintended fallthrough in generic_make_request_checks()

Nicolai Stange writes: > --- > Applicable to next-20161202. > > Note that after this patch, I'm seeing a single > EXT4-fs (dm-1): Delayed block allocation failed for inode 2625094 at > logical offset 2032 with max blocks 2 with error 121 > with 121 ==

Re: [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On Mon, Dec 5, 2016 at 10:07 AM, Jens Axboe wrote: > > On 12/05/2016 06:05 AM, Christoph Hellwig wrote: > > On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: > >> No functional changes with this patch, it's just in preparation for > >> supporting legacy schedulers on

Re: [Nbd] [PATCH] nbd: use dev_err_ratelimited in io path

On Mon, Dec 5, 2016 at 4:27 PM, Eric Blake wrote: On 12/05/2016 03:20 PM, Josef Bacik wrote: While doing stress tests we noticed that we'd get a lot of dmesg spam if we suddenly disconnected teh nbd device out of band. Rate limite the s/teh/the/ s/limite/limit/

Re: [PATCH] block: Add missed break in generic_make_request_checks

On 12/05/2016 02:18 PM, Mike Krinkin wrote: > With recent linux-next i started to get this error: > > [ 19.746764] EXT4-fs (sda6): Delayed block allocation failed for inode > 4999023 at logical offset 0 with max blocks 6 with error 95 > [ 19.746767] EXT4-fs (sda6): This should not happen!!

[PATCH] nbd: use dev_err_ratelimited in io path

While doing stress tests we noticed that we'd get a lot of dmesg spam if we suddenly disconnected teh nbd device out of band. Rate limite the messages in the io path in order to deal with this. Signed-off-by: Josef Bacik --- drivers/block/nbd.c | 23 --- 1

[PATCH] block: Add missed break in generic_make_request_checks

With recent linux-next i started to get this error: [ 19.746764] EXT4-fs (sda6): Delayed block allocation failed for inode 4999023 at logical offset 0 with max blocks 6 with error 95 [ 19.746767] EXT4-fs (sda6): This should not happen!! Data will be lost Bisect points at the commit

Re: [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On Tue, Dec 6, 2016 at 1:09 AM, Jens Axboe wrote: > On 12/05/2016 10:00 AM, Ming Lei wrote: >> On Sat, Dec 3, 2016 at 11:15 AM, Jens Axboe wrote: >>> No functional changes with this patch, it's just in preparation for >>> supporting legacy schedulers on blk-mq. >>>

[PATCH 3/7] block: use appropriate queue running functions

Use MQ variants for MQ, legacy ones for legacy. Signed-off-by: Jens Axboe --- block/blk-core.c | 5 - block/blk-exec.c | 10 -- block/blk-flush.c | 14 ++ block/elevator.c | 5 - 4 files changed, 26 insertions(+), 8 deletions(-) diff --git

[PATCH 2/7] cfq-iosched: use appropriate run queue function

For MQ devices, we have to use other functions to run the queue. No functional changes in this patch, just a prep patch for support legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/cfq-iosched.c | 22 +++--- 1 file changed, 19 insertions(+), 3

[PATCH 5/7] blk-mq: add BLK_MQ_F_NO_SCHED flag

Drivers can use this to prevent IO scheduling on a queue. Use this for NVMe, for the admin queue, which doesn't handle file system requests. Signed-off-by: Jens Axboe --- drivers/nvme/host/pci.c | 1 + include/linux/blk-mq.h | 1 + 2 files changed, 2 insertions(+) diff --git

[PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

No functional changes with this patch, it's just in preparation for supporting legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/blk-core.c | 2 +- block/blk-exec.c | 2 +- block/blk-flush.c | 26 ++ block/blk.h | 12 +++- 4

[PATCHSET/RFC v2] Make legacy IO schedulers work with blk-mq

Version 2 of the hack/patchset, that enables blk-mq to use the legacy IO schedulers with single queue devices. Original posting is here: https://marc.info/?l=linux-block=148073493203664=2 You can also found this version in the following git branch: git://git.kernel.dk/linux-block

[PATCH 4/7] blk-mq: blk_account_io_start() takes a bool

Signed-off-by: Jens Axboe Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index bac12caece06..90db5b490df9 100644

[PATCH 7/7] block: drop irq+lock when flushing queue plugs

Not convinced this is a faster approach, and it does look IRQs off longer than otherwise. With mq+scheduling, it's a problem since it forces us to offload the queue running. If we get rid of it, we can run the queue without the queue lock held. Signed-off-by: Jens Axboe ---

Re: [PATCH 3/7] block: use appropriate queue running functions

On 12/05/2016 08:10 AM, Jens Axboe wrote: > On 12/05/2016 06:07 AM, Christoph Hellwig wrote: >> On Fri, Dec 02, 2016 at 08:15:17PM -0700, Jens Axboe wrote: >>> Use MQ variants for MQ, legacy ones for legacy. >>> >>> Signed-off-by: Jens Axboe >>> --- >>> block/blk-core.c | 5 -

Re: [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On Sat, Dec 3, 2016 at 11:15 AM, Jens Axboe wrote: > No functional changes with this patch, it's just in preparation for > supporting legacy schedulers on blk-mq. > > Signed-off-by: Jens Axboe > --- > block/blk-core.c | 2 +- > block/blk-exec.c | 2 +- >

Re: [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On 12/05/2016 08:49 AM, Johannes Thumshirn wrote: > On Mon, Dec 05, 2016 at 08:07:10AM -0700, Jens Axboe wrote: >> On 12/05/2016 06:05 AM, Christoph Hellwig wrote: >>> On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: No functional changes with this patch, it's just in preparation

Re: [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On Mon, Dec 05, 2016 at 08:07:10AM -0700, Jens Axboe wrote: > On 12/05/2016 06:05 AM, Christoph Hellwig wrote: > > On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: > >> No functional changes with this patch, it's just in preparation for > >> supporting legacy schedulers on blk-mq. > >

Re: [PATCH 2/7] cfq-iosched: use appropriate run queue function

On 12/05/2016 06:06 AM, Christoph Hellwig wrote: > On Fri, Dec 02, 2016 at 08:15:16PM -0700, Jens Axboe wrote: >> For MQ devices, we have to use other functions to run the queue. >> No functional changes in this patch, just a prep patch for >> support legacy schedulers on blk-mq. > > I don't

Re: [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On 12/05/2016 06:05 AM, Christoph Hellwig wrote: > On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: >> No functional changes with this patch, it's just in preparation for >> supporting legacy schedulers on blk-mq. > > Ewww. I think without refactoring to clear what 'use_mq_path' >

Re: scsi: use-after-free in bio_copy_from_iter

On Sat, Dec 3, 2016 at 7:19 PM, Johannes Thumshirn wrote: > On Sat, Dec 03, 2016 at 04:22:39PM +0100, Dmitry Vyukov wrote: >> On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn >> wrote: >> > On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote:

Re: [PATCH 3/7] block: use appropriate queue running functions

On Fri, Dec 02, 2016 at 08:15:17PM -0700, Jens Axboe wrote: > Use MQ variants for MQ, legacy ones for legacy. > > Signed-off-by: Jens Axboe > --- > block/blk-core.c | 5 - > block/blk-exec.c | 10 -- > block/blk-flush.c | 14 ++ > block/elevator.c | 5

Re: [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: > No functional changes with this patch, it's just in preparation for > supporting legacy schedulers on blk-mq. Ewww. I think without refactoring to clear what 'use_mq_path' means here and better naming this is a total non-started.

Re: [PATCH 3/7] block: use appropriate queue running functions

On Fri, Dec 02, 2016 at 08:15:17PM -0700, Jens Axboe wrote: > Use MQ variants for MQ, legacy ones for legacy. > > Signed-off-by: Jens Axboe > --- > block/blk-core.c | 5 - > block/blk-exec.c | 10 -- > block/blk-flush.c | 14 ++ > block/elevator.c | 5