Re: [Lsf-pc] [LSF/MM TOPIC] Badblocks checking/representation in filesystems

On Fri 20-01-17 07:42:09, Dan Williams wrote: > On Fri, Jan 20, 2017 at 1:47 AM, Jan Kara wrote: > > On Thu 19-01-17 14:17:19, Vishal Verma wrote: > >> On 01/18, Jan Kara wrote: > >> > On Tue 17-01-17 15:37:05, Vishal Verma wrote: > >> > 2) PMEM is exposed for DAX aware filesystem.

Re: [PATCH 02/16] block: simplify blk_init_allocated_queue

On 01/23/2017 04:29 PM, Christoph Hellwig wrote: > Return an errno value instead of the passed in queue so that the callers > don't have to keep track of two queues, and move the assignment of the > request_fn and lock to the caller as passing them as argument doesn't > simplify anything. While

Re: [PATCH 01/16] block: fix elevator init check

On 01/23/2017 04:29 PM, Christoph Hellwig wrote: > We can't initalize the elevator fields for flushes as flush share space > in struct request with the elevator data. But currently we can't > commnicate that a request is a flush through blk_get_request as we > can only pass READ or WRITE, and the

[PATCH] blk-mq-sched: fix possible crash if changing scheduler fails

From: Omar Sandoval In elevator_switch(), we free the old scheduler's tags and then initialize the new scheduler. If initializing the new scheduler fails, we fall back to the old scheduler, but our tags have already been freed. There's no reason to free the sched_tags only to

Re: [RFC PATCH v2 0/2] block: fix backing_dev_info lifetime

Hello Dan, Am Freitag, 6. Januar 2017, 17:02:51 BRST schrieb Dan Williams: > v1 of these changes [1] was a one line change to bdev_get_queue() to > prevent a shutdown crash when del_gendisk() races the final > __blkdev_put(). > > While it is known at del_gendisk() time that the queue is still

[PATCH] block: remove outdated part of blkdev_issue_flush() comment

From: Eric Biggers blkdev_issue_flush() is now always synchronous, and it no longer has a flags argument. So remove the part of the comment about the WAIT flag. Signed-off-by: Eric Biggers --- block/blk-flush.c | 3 +-- 1 file changed, 1

[PATCH] block: correct documentation for blkdev_issue_discard() flags

From: Eric Biggers BLKDEV_IFL_* flags no longer exist; blkdev_issue_discard() now actually takes BLKDEV_DISCARD_* flags. Signed-off-by: Eric Biggers --- block/blk-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/10] blk-mq: add hctx->{state,flags} to debugfs

From: Omar Sandoval hctx->state could come in handy for bugs where the hardware queue gets stuck in the stopped state, and hctx->flags is just useful to know. Signed-off-by: Omar Sandoval --- block/blk-mq-debugfs.c | 42

[PATCH 07/10] blk-mq: move tags and sched_tags info from sysfs to debugfs

From: Omar Sandoval These are very tied to the blk-mq tag implementation, so exposing them to sysfs isn't a great idea. Move the debugging information to debugfs and add basic entries for the number of tags and the number of reserved tags to sysfs. Signed-off-by: Omar Sandoval

[PATCH 09/10] blk-mq: move hctx io_poll, stats, and dispatched from sysfs to debugfs

From: Omar Sandoval These statistics _might_ be useful to userspace, but it's better not to commit to an ABI for these yet. Also, the dispatched file in sysfs couldn't be cleared, so make it clearable like the others in debugfs. Signed-off-by: Omar Sandoval ---

[PATCH 10/10] blk-mq: move hctx and ctx counters from sysfs to debugfs

From: Omar Sandoval These counters aren't as out-of-place in sysfs as the other stuff, but debugfs is a slightly better home for them. Signed-off-by: Omar Sandoval --- block/blk-mq-debugfs.c | 181 +

[PATCH 04/10] blk-mq: add extra request information to debugfs

From: Omar Sandoval The request pointers by themselves aren't super useful. Signed-off-by: Omar Sandoval --- block/blk-mq-debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index

[PATCH 06/10] blk-mq: export software queue pending map to debugfs

From: Omar Sandoval This is useful for debugging problems where we've gotten stuck with requests in the software queues. Signed-off-by: Omar Sandoval --- block/blk-mq-debugfs.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PATCH 08/10] blk-mq: add tags and sched_tags bitmaps to debugfs

From: Omar Sandoval These can be used to debug issues like tag leaks and stuck requests. Signed-off-by: Omar Sandoval --- block/blk-mq-debugfs.c | 50 ++ 1 file changed, 50 insertions(+) diff --git

[PATCH 05/10] sbitmap: add helpers for dumping to a seq_file

From: Omar Sandoval This is useful debugging information that will be used in the blk-mq debugfs directory. Signed-off-by: Omar Sandoval --- include/linux/sbitmap.h | 34 lib/sbitmap.c | 83

[PATCH 03/10] blk-mq: move hctx->dispatch and ctx->rq_list from sysfs to debugfs

From: Omar Sandoval These lists are only useful for debugging; they definitely don't belong in sysfs. Putting them in debugfs also removes the limitation of a single page of output. Signed-off-by: Omar Sandoval --- block/blk-mq-debugfs.c | 106

[PATCH 00/10] blk-mq: move debugging information from sysfs to debugfs

From: Omar Sandoval This series ends our abuse of sysfs and puts all of the debugging information in debugfs instead. This has a few benefits: 1. Removes the possibility of userspace being stupid and relying on something in sysfs that we only exposed for debugging. 2. Lifts

[PATCH 01/10] blk-mq: create debugfs directory tree

From: Omar Sandoval In preparation for putting blk-mq debugging information in debugfs, create a directory tree mirroring the one in sysfs: # tree -d /sys/kernel/debug/block /sys/kernel/debug/block |-- nvme0n1 | `-- mq | |-- 0 | | `-- cpu0

Re: [PATCH 4/6] blk-mq: Update queue map when changing queue count

Looks fine except for the nitpick pointed out by Sagi: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/6] nvme/pci: Start queues after tagset is updated

Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6] irq/affinity: Assign all online CPUs to vectors

On Wed, Jan 04, 2017 at 05:41:06PM -0500, Keith Busch wrote: > This patch makes sure all online CPUs are assigned to vectors in > cases where the nodes don't have the same number of online CPUs. > The calculation for how many vectors needs to be assigned should account > for the number of CPUs for

Re: [PATCH] block: Initialize cfqq->ioprio_class in cfq_get_queue()

On 01/23/2017 09:17 AM, Alexander Potapenko wrote: > On Mon, Jan 23, 2017 at 5:03 PM, Andrey Ryabinin > wrote: >> 2017-01-23 17:06 GMT+03:00 Alexander Potapenko : >>> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of >>>

Re: [PATCHSET v4] blk-mq-scheduling framework

On 01/23/2017 10:04 AM, Paolo Valente wrote: > >> Il giorno 18 gen 2017, alle ore 17:21, Jens Axboe ha scritto: >> >> On 01/18/2017 08:14 AM, Paolo Valente wrote: >>> according to the function blk_mq_sched_put_request, the >>> mq.completed_request hook seems to always be invoked

Re: BUG: KASAN: Use-after-free

On Mon, Jan 23, 2017 at 05:07:52PM +0100, Matias Bjørling wrote: > Hi, > > I could use some help verifying an use-after-free bug that I am seeing > after the new direct I/O work went in. > > When issuing a direct write io using libaio, a bio is referenced in the > blkdev_direct_IO path, and then

Re: [PATCHSET v4] blk-mq-scheduling framework

> Il giorno 18 gen 2017, alle ore 17:21, Jens Axboe ha scritto: > > On 01/18/2017 08:14 AM, Paolo Valente wrote: >> according to the function blk_mq_sched_put_request, the >> mq.completed_request hook seems to always be invoked (if set) for a >> request for which the

Re: [PATCH] block: Initialize cfqq->ioprio_class in cfq_get_queue()

On Mon, Jan 23, 2017 at 5:03 PM, Andrey Ryabinin wrote: > 2017-01-23 17:06 GMT+03:00 Alexander Potapenko : >> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of >> uninitialized memory in cfq_init_cfqq(): >> >>

BUG: KASAN: Use-after-free

Hi, I could use some help verifying an use-after-free bug that I am seeing after the new direct I/O work went in. When issuing a direct write io using libaio, a bio is referenced in the blkdev_direct_IO path, and then put again in the blkdev_bio_end_io path. However, there is a case where the

Re: [PATCH] block: Initialize cfqq->ioprio_class in cfq_get_queue()

2017-01-23 17:06 GMT+03:00 Alexander Potapenko : > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in cfq_init_cfqq(): > > == > BUG: KMSAN: use of unitialized memory >

Re: [PATCH 4/4] nbd: add a nbd-control interface

On Mon, Jan 23, 2017 at 10:03 AM, Greg KH wrote: On Mon, Jan 23, 2017 at 09:57:52AM -0500, Josef Bacik wrote: On Mon, Jan 23, 2017 at 9:52 AM, Greg KH wrote: > On Mon, Jan 23, 2017 at 09:42:08AM -0500, Josef Bacik wrote: > > > > >

Re: [PATCH] block: Initialize cfqq->ioprio_class in cfq_get_queue()

On 01/23/2017 08:49 AM, Alexander Potapenko wrote: > On Mon, Jan 23, 2017 at 4:30 PM, Jens Axboe wrote: >> On 01/23/2017 07:06 AM, Alexander Potapenko wrote: >>> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of >>> uninitialized memory in cfq_init_cfqq(): >>>

Re: [PATCH] block: Initialize cfqq->ioprio_class in cfq_get_queue()

On Mon, Jan 23, 2017 at 4:30 PM, Jens Axboe wrote: > On 01/23/2017 07:06 AM, Alexander Potapenko wrote: >> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of >> uninitialized memory in cfq_init_cfqq(): >> >>

Re: split scsi passthrough fields out of struct request

On Mon, Jan 23, 2017 at 08:39:44AM -0700, Jens Axboe wrote: > I'd like to get this in sooner rather than later, so I'll spend some > time reviewing and testing it start this week. I'm assuming you are > targeting 4.11 with this change, right? Yes. -- To unsubscribe from this list: send the line

Re: split scsi passthrough fields out of struct request

On 01/23/2017 08:29 AM, Christoph Hellwig wrote: > Hi all, > > this series splits the support for SCSI passthrough commands from the > main struct request used all over the block layer into a separate > scsi_request structure that drivers that want to support SCSI passthough > need to embedded as

[PATCH 12/16] scsi: remove __scsi_alloc_queue

Instead do an internal export of __scsi_init_queue for the transport classes that export BSG nodes. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_lib.c | 19 --- drivers/scsi/scsi_transport_fc.c| 6 --

[PATCH 08/16] scsi_dh_hp_sw: switch to scsi_execute_req_flags()

From: Hannes Reinecke Switch to scsi_execute_req_flags() instead of using the block interface directly. This will set REQ_QUIET and REQ_PREEMPT, but this is okay as we're evaluating the errors anyway and should be able to send the command even if the device is quiesced.

[PATCH 16/16] block: don't assign cmd_flags in __blk_rq_prep_clone

These days we have the proper flags set since request allocation time. Signed-off-by: Christoph Hellwig --- block/blk-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index fe5cc98..93a9e0b 100644 --- a/block/blk-core.c +++

[PATCH 01/16] block: fix elevator init check

We can't initalize the elevator fields for flushes as flush share space in struct request with the elevator data. But currently we can't commnicate that a request is a flush through blk_get_request as we can only pass READ or WRITE, and the low-level code looks at the possible NULL bio to check

Re: [PATCH] block: Initialize cfqq->ioprio_class in cfq_get_queue()

On 01/23/2017 07:06 AM, Alexander Potapenko wrote: > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in cfq_init_cfqq(): > > == > BUG: KMSAN: use of unitialized memory > ... > Call

[PATCH 14/16] block/bsg: move queue creation into bsg_setup_queue

Simply the boilerplate code needed for bsg nodes a bit. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- block/bsg-lib.c | 21 +++-- drivers/scsi/scsi_transport_fc.c| 36

[PATCH 11/16] scsi: remove scsi_cmd_dma_pool

There is no need for GFP_DMA allocations of the scsi_cmnd structures themselves, all that might be DMAed to or from is the actual payload, or the sense buffers. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi.c | 15 +-- 1 file changed, 1 insertion(+), 14

[PATCH 13/16] scsi: allocate scsi_cmnd structures as part of struct request

Rely on the new block layer functionality to allocate additional driver specific data behind struct request instead of implementing it in SCSI itѕelf. Signed-off-by: Christoph Hellwig --- drivers/scsi/hosts.c | 20 +-- drivers/scsi/scsi.c | 319

[PATCH 15/16] block: split scsi_request out of struct request

And require all drivers that want to support BLOCK_PC to allocate it as the first thing of their private data. To support this the legacy IDE and BSG code is switched to set cmd_size on their queues to let the block layer allocate the additional space. Signed-off-by: Christoph Hellwig

[PATCH 04/16] dm: remove incomple BLOCK_PC support

DM tries to copy a few fields around for BLOCK_PC requests, but given that no dm-target ever wires up scsi_cmd_ioctl BLOCK_PC can't actually be sent to dm. Signed-off-by: Christoph Hellwig --- drivers/md/dm-rq.c | 16 1 file changed, 16 deletions(-) diff --git

[PATCH 06/16] scsi_dh_rdac: switch to scsi_execute_req_flags()

From: Hannes Reinecke Switch to scsi_execute_req_flags() and scsi_get_vpd_page() instead of open-coding it. Using scsi_execute_req_flags() will set REQ_QUIET and REQ_PREEMPT, but this is okay as we're evaluating the errors anyway and should be able to send the command even if the

[PATCH 09/16] scsi: remove gfp_flags member in scsi_host_cmd_pool

When using the slab allocator we already decide at cache creation time if an allocation comes from a GFP_DMA pool using the SLAB_CACHE_DMA flag, and there is no point passing the kmalloc-family only GFP_DMA flag to kmem_cache_alloc. Drop all the infrastructure for doing so. Signed-off-by:

[PATCH 05/16] dm: always defer request allocation to the owner of the request_queue

DM already calls blk_mq_alloc_request on the request_queue of the underlying device if it is a blk-mq device. But now that we allow drivers to allocate additional data and initialize it ahead of time we need to do the same for all drivers. Doing so and using the new cmd_size infrastructure in

[PATCH 07/16] scsi_dh_emc: switch to scsi_execute_req_flags()

From: Hannes Reinecke Switch to scsi_execute_req_flags() and scsi_get_vpd_page() instead of open-coding it. Using scsi_execute_req_flags() will set REQ_QUIET and REQ_PREEMPT, but this is okay as we're evaluating the errors anyway and should be able to send the command even if the

split scsi passthrough fields out of struct request

Hi all, this series splits the support for SCSI passthrough commands from the main struct request used all over the block layer into a separate scsi_request structure that drivers that want to support SCSI passthough need to embedded as the first thing into their request-private data, similar to

[PATCH 02/16] block: simplify blk_init_allocated_queue

Return an errno value instead of the passed in queue so that the callers don't have to keep track of two queues, and move the assignment of the request_fn and lock to the caller as passing them as argument doesn't simplify anything. While we're at it also remove two pointless NULL assignments,

Re: blk-throttle: Move three assignments for the variable "ret" in tg_set_max()

On 01/23/2017 05:06 AM, SF Markus Elfring wrote: >>> We have got different preferences for the placement of error code settings. >> Yes we do, so what's the point? Both are OK. > > Can a function implementation be executed a bit faster in the case > that error codes will usually only matter if

Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment

On 01/23/2017 02:20 AM, Johannes Thumshirn wrote: > On Sun, Jan 22, 2017 at 09:33:08AM +0100, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 21 Jan 2017 22:15:33 +0100 >> >> The script "checkpatch.pl" pointed information out like the following. >> >>

Re: [PATCH 4/4] nbd: add a nbd-control interface

On Mon, Jan 23, 2017 at 09:57:52AM -0500, Josef Bacik wrote: > On Mon, Jan 23, 2017 at 9:52 AM, Greg KH wrote: > > On Mon, Jan 23, 2017 at 09:42:08AM -0500, Josef Bacik wrote: > > > > > > > > > On Sat, Jan 21, 2017 at 4:05 AM, Greg KH > > >

Re: __blk_mq_tag_busy() weirdness

On 01/23/2017 07:07 AM, Hannes Reinecke wrote: > Hi Jens, > > while hunting yet another queue stall I've been looking at > __blk_mq_tag_busy(): > > bool __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx) > { > if (!test_bit(BLK_MQ_S_TAG_ACTIVE, >state) && >

Re: [PATCH 4/4] nbd: add a nbd-control interface

On Mon, Jan 23, 2017 at 9:52 AM, Greg KH wrote: On Mon, Jan 23, 2017 at 09:42:08AM -0500, Josef Bacik wrote: On Sat, Jan 21, 2017 at 4:05 AM, Greg KH wrote: > On Fri, Jan 20, 2017 at 04:56:52PM -0500, Josef Bacik wrote: > > This

Re: [PATCH 4/4] nbd: add a nbd-control interface

On Mon, Jan 23, 2017 at 09:42:08AM -0500, Josef Bacik wrote: > > > On Sat, Jan 21, 2017 at 4:05 AM, Greg KH wrote: > > On Fri, Jan 20, 2017 at 04:56:52PM -0500, Josef Bacik wrote: > > > This patch mirrors the loop back device behavior with a few > > > changes.

Urgent Please,,

Good Day Dear, My name is Ms. Joyes Dadi, I am glad you are reading this letter and I hope we will start our communication and I know that this message will look strange, surprising and probably unbelievable to you, but it is the reality. I want to make a donation of money to you. I contact you

[PATCH 6/8] lightnvm: cleanup nvm transformation functions

Going from target specific ppa addresses to device was accomplished by first converting target to generic ppa addresses and generic to device addresses. The conversion was either open-coded or used the built-in nvm_trans_* and nvm_map_* functions for conversion. Simplify the interface and cleanup

[PATCH 5/8] lightnvm: make nvm_map_* return void

The only check there was done was a debugging check. Remove it and replace the return value with void to reduce error checking. Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 41 + 1 file changed, 9 insertions(+), 32

[PATCH 3/8] lightnvm: remove nvm_submit_ppa* functions

The nvm_submit_ppa* functions are no longer needed after gennvm and core have been merged. Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 109 --- include/linux/lightnvm.h | 4 -- 2 files changed, 113 deletions(-)

[PATCH 0/8] lightnvm: cleanups and support for vector ioctls

A couple of patches. The first seven patches is cleanup patches, that cleans up the codebase for when pblk is added to the kernel, and prepare the code such that a device can be used as a normal block device (as long as the access rules are respected). The last patch adds ioctls for vectored

[PATCH 4/8] lightnvm: remove nvm_get_bb_tbl and nvm_set_bb_tbl

Since the merge of gennvm and core, there is no longer a need for the device specific bad block functions. Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 40 include/linux/lightnvm.h | 2 -- 2 files changed, 4

[PATCH 8/8] lightnvm: add ioctls for vector I/Os

Enable user-space to issue vector I/O commands through ioctls. To issue a vector I/O, the ppa list with addresses is also required and must be mapped for the controller to access. For each ioctl, the result and status bits are returned as well, such that user-space can retrieve the open-channel

Re: [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max()

On Mon, Jan 23, 2017 at 11:00:15AM +0100, SF Markus Elfring wrote: > >> @@ -1327,27 +1327,30 @@ static ssize_t tg_set_max(struct kernfs_open_file > >> *of, > >>break; > >>ctx.body += len; > >> > >> - ret = -EINVAL; > >>p = tok; > >>

Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment

On Sun, Jan 22, 2017 at 09:33:08AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 21 Jan 2017 22:15:33 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > ERROR: do not use assignment in if condition > > Thus

Re: [PATCH 1/5] blk-throttle: Move three assignments for the variable "ret" in tg_set_max()

On Sun, Jan 22, 2017 at 09:31:29AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 21 Jan 2017 21:23:06 +0100 > > A local variable was set to an error code before a concrete error situation > was detected. Thus move the corresponding assignments