RE: Boot regression (was "Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements")

> From: h...@lst.de [mailto:h...@lst.de] > Sent: Thursday, February 9, 2017 02:03 > To: Jens Axboe > Cc: Dexuan Cui ; Bart Van Assche > ; h...@suse.com; h...@suse.de; Martin K. > Petersen ; h...@lst.de;

Re: [PATCHv6 03/37] page-flags: relax page flag policy for few flags

On Thu, Jan 26, 2017 at 02:57:45PM +0300, Kirill A. Shutemov wrote: > These flags are in use for filesystems with backing storage: PG_error, > PG_writeback and PG_readahead. Oh ;-) Then I amend my comment on patch 1 to be "patch 3 needs to go ahead of patch 1" ;-) > Signed-off-by: Kirill A.

Re: [PATCHv6 01/37] mm, shmem: swich huge tmpfs to multi-order radix-tree entries

On Thu, Jan 26, 2017 at 02:57:43PM +0300, Kirill A. Shutemov wrote: > +++ b/include/linux/pagemap.h > @@ -332,6 +332,15 @@ static inline struct page *grab_cache_page_nowait(struct > address_space *mapping, > mapping_gfp_mask(mapping)); > } > > +static inline struct page

Re: [PATCH] block: sed-opal: reduce stack size of ioctl handler

On Wed, Feb 08, 2017 at 02:58:28PM -0700, Scott Bauer wrote: > On Wed, Feb 08, 2017 at 10:15:28PM +0100, Arnd Bergmann wrote: > > When CONFIG_KASAN is in use, the sed_ioctl function uses unusually large > > stack, > > as each possible ioctl argument gets its own stack area plus redzone: > > > >

Re: Boot regression (was "Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements")

On Wed, Feb 08, 2017 at 10:43:59AM -0700, Jens Axboe wrote: > I've changed the subject line, this issue has nothing to do with the > issue that Hannes was attempting to fix. Nothing really useful in the thread. Dexuan, can you throw in some prints to see which command times out?

Boot regression (was "Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements")

On 02/08/2017 03:48 AM, Dexuan Cui wrote: >> From: Jens Axboe [mailto:ax...@kernel.dk] >> Sent: Wednesday, February 8, 2017 00:09 >> To: Dexuan Cui ; Bart Van Assche >> ; h...@suse.com; h...@suse.de >> Cc: h...@lst.de; linux-ker...@vger.kernel.org;

Re: [PATCH] bfq-mq: cause deadlock by executing exit_icq body immediately

On Wed, Feb 08, 2017 at 11:39:24AM +0100, Paolo Valente wrote: > > > Il giorno 08 feb 2017, alle ore 11:33, Omar Sandoval > > ha scritto: > > > > On Wed, Feb 08, 2017 at 11:03:01AM +0100, Paolo Valente wrote: > >> > >>> Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval

Re: [PATCH 08/24] btrfs: Convert to separately allocated bdi

On Thu, Feb 02, 2017 at 06:34:06PM +0100, Jan Kara wrote: > Allocate struct backing_dev_info separately instead of embedding it > inside superblock. This unifies handling of bdi among users. > > CC: Chris Mason > CC: Josef Bacik > CC: David Sterba

[PATCH 3/4] block: optionally merge discontiguous discard bios into a single request

Add a new merge strategy that merges discard bios into a request until the maximum number of discard ranges (or the maximum discard size) is reached from the plug merging code. I/O scheduler merging is not wired up yet but might also be useful, although not for fast devices like NVMe which are

support for multi-range discard requests V3

Hi all, this series adds support for merging discontiguous discard bios into a single request if the driver supports it. This reduces the number of discards sent to the device by about a factor of 5-6 for typical workloads on NVMe, and for slower devices that use I/O scheduling the number will

[PATCH 1/4] block: move req_set_nomerge to blk.h

This makes it available outside of blk-merge.c, and inlining such a trivial helper seems pretty useful to start with. Signed-off-by: Christoph Hellwig --- block/blk-merge.c | 7 --- block/blk.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 3/4] block: optionally merge discontiguous discard bios into a single request

On Wed, Feb 08, 2017 at 06:54:24PM +0800, Ming Lei wrote: > > + struct bio *bio) > > +{ > > + unsigned short segments = blk_rq_nr_discard_segments(req); > > + > > + if (segments >= queue_max_discard_segments(q)) > > + goto no_merge; > > + if

[PATCH 4/4] nvme: support ranged discard requests

NVMe supports up to 256 ranges per DSM command, so wire up support for ranged discards up to that limit. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/core.c | 30 +++--- include/linux/nvme.h | 2 ++ 2 files changed, 25 insertions(+), 7

Re: [PATCH 4/4] nvme: support ranged discard requests

On Wed, Feb 08, 2017 at 01:32:22PM +, Andrey Kuzmin wrote: > On Wed, Feb 8, 2017, 16:14 Christoph Hellwig wrote: > > > NVMe supports up to 255 ranges per DSM command, > > > 256 per spec, with number of ranges being zero-based. You're right. I'll do another round of the

[PATCH 4/4] nvme: support ranged discard requests

NVMe supports up to 255 ranges per DSM command, so wire up support for ranged discards up to that limit. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/core.c | 28 +--- include/linux/nvme.h | 2 ++ 2 files changed, 23 insertions(+), 7

[PATCH 3/4] block: optionally merge discontiguous discard bios into a single request

Add a new merge strategy that merges discard bios into a request until the maximum number of discard ranges (or the maximum discard size) is reached from the plug merging code. I/O scheduler merging is not wired up yet but might also be useful, although not for fast devices like NVMe which are

[PATCH 1/4] block: move req_set_nomerge to blk.h

This makes it available outside of blk-merge.c, and inlining such a trivial helper seems pretty useful to start with. Signed-off-by: Christoph Hellwig --- block/blk-merge.c | 7 --- block/blk.h | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 22/24] ubifs: Convert to separately allocated bdi

Am 02.02.2017 um 18:34 schrieb Jan Kara: > Allocate struct backing_dev_info separately instead of embedding it > inside the superblock. This unifies handling of bdi among users. > > CC: Richard Weinberger > CC: Artem Bityutskiy > CC: Adrian Hunter

Re: [PATCH] bfq-mq: cause deadlock by executing exit_icq body immediately

> Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval ha > scritto: > > On Tue, Feb 07, 2017 at 06:33:46PM +0100, Paolo Valente wrote: >> Hi, >> this patch is meant to show that, if the body of the hook exit_icq is >> executed >> from inside that hook, and not as

Re: [PATCH] bfq-mq: cause deadlock by executing exit_icq body immediately

On Wed, Feb 08, 2017 at 11:03:01AM +0100, Paolo Valente wrote: > > > Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval > > ha scritto: > > > > On Tue, Feb 07, 2017 at 06:33:46PM +0100, Paolo Valente wrote: > >> Hi, > >> this patch is meant to show that, if the body of

Re: [PATCH] bfq-mq: cause deadlock by executing exit_icq body immediately

> Il giorno 08 feb 2017, alle ore 11:33, Omar Sandoval ha > scritto: > > On Wed, Feb 08, 2017 at 11:03:01AM +0100, Paolo Valente wrote: >> >>> Il giorno 07 feb 2017, alle ore 22:45, Omar Sandoval >>> ha scritto: >>> >>> On Tue, Feb 07, 2017 at

RE: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements

> From: Jens Axboe [mailto:ax...@kernel.dk] > Sent: Wednesday, February 8, 2017 00:09 > To: Dexuan Cui ; Bart Van Assche > ; h...@suse.com; h...@suse.de > Cc: h...@lst.de; linux-ker...@vger.kernel.org; linux-block@vger.kernel.org; > j...@kernel.org

Re: [PATCH 0/4 v2] BDI lifetime fix

On Wed 08-02-17 08:51:42, Jan Kara wrote: > On Tue 07-02-17 12:21:01, Tejun Heo wrote: > > Hello, > > > > On Tue, Feb 07, 2017 at 01:33:31PM +0100, Jan Kara wrote: > > > > We can see above that inode->i_wb is in r31, and the machine crashed at > > > > 0xc03799a0 so it was trying to

Re: [PATCH 0/4 v2] BDI lifetime fix

On Tue 07-02-17 12:21:01, Tejun Heo wrote: > Hello, > > On Tue, Feb 07, 2017 at 01:33:31PM +0100, Jan Kara wrote: > > > We can see above that inode->i_wb is in r31, and the machine crashed at > > > 0xc03799a0 so it was trying to dereference wb and crashed. > > > r31 is NULL in the crash