Re: [PATCH 10/10] block: Fix oops scsi_disk_get()

2017-02-11 Thread Tejun Heo
On Thu, Feb 09, 2017 at 01:44:33PM +0100, Jan Kara wrote: > When device open races with device shutdown, we can get the following > oops in scsi_disk_get(): > > [11863.044351] general protection fault: [#1] SMP > [11863.045561] Modules linked in: scsi_debug xfs libcrc32c netconsole btrfs > r

Re: [PATCH 09/10] kobject: Export kobject_get_unless_zero()

2017-02-11 Thread Tejun Heo
On Thu, Feb 09, 2017 at 01:44:32PM +0100, Jan Kara wrote: > Make the function available for outside use and fortify it against NULL > kobject. > > Signed-off-by: Jan Kara Acked-by: Tejun Heo Cc Greg? Thanks. -- tejun

Re: [PATCH 08/10] block: Fix oops in locked_inode_to_wb_and_lock_list()

2017-02-11 Thread Tejun Heo
Hello, Jan. On Thu, Feb 09, 2017 at 01:44:31PM +0100, Jan Kara wrote: > When block device is closed, we call inode_detach_wb() in __blkdev_put() > which sets inode->i_wb to NULL. That is contrary to expectations that > inode->i_wb stays valid once set during the whole inode's lifetime and > leads

Re: [PATCH 05/10] writeback: Generalize and standardize I_SYNC waiting function

2017-02-11 Thread Tejun Heo
On Thu, Feb 09, 2017 at 01:44:28PM +0100, Jan Kara wrote: > __inode_wait_for_writeback() waits for I_SYNC on inode to get cleared. > There's nothing specific regarting I_SYNC for that function. Generalize > it so that we can use it also for I_WB_SWITCH bit. Also the function > uses __wait_on_bit()

Re: [PATCH 04/10] block: Move bdi_unregister() to del_gendisk()

2017-02-11 Thread Tejun Heo
On Thu, Feb 09, 2017 at 01:44:27PM +0100, Jan Kara wrote: > Commit 6cd18e711dd8 "block: destroy bdi before blockdev is > unregistered." moved bdi unregistration (at that time through > bdi_destroy()) from blk_release_queue() to blk_cleanup_queue() because > it needs to happen before blk_unregister_

Re: [PATCH 03/10] block: Revalidate i_bdev reference in bd_aquire()

2017-02-11 Thread Tejun Heo
On Thu, Feb 09, 2017 at 04:54:17PM +0100, Jan Kara wrote: > From aaf612333753b948a96aebe4a2f8066ed45ef164 Mon Sep 17 00:00:00 2001 > From: Jan Kara > Date: Thu, 9 Feb 2017 12:16:30 +0100 > Subject: [PATCH 03/10] block: Revalidate i_bdev reference in bd_aquire() > > When a device gets removed, blo

Re: [PATCH 02/10] block: Unhash also block device inode for the whole device

2017-02-11 Thread Tejun Heo
On Thu, Feb 09, 2017 at 01:44:25PM +0100, Jan Kara wrote: > Iteration over partitions in del_gendisk() omits part0. Add > bdev_unhash_inode() call for the whole device. Otherwise if the device > number gets reused, bdev inode will be still associated with the old > (stale) bdi. > > Signed-off-by:

Re: [PATCH 01/10] block: Move bdev_unhash_inode() after invalidate_partition()

2017-02-11 Thread Tejun Heo
On Thu, Feb 09, 2017 at 01:44:24PM +0100, Jan Kara wrote: > Move bdev_unhash_inode() after invalidate_partition() as > invalidate_partition() looks up bdev and will unnecessarily recreate it > if bdev_unhash_inode() destroyed it. Also use part_devt() when calling > bdev_unhash_inode() instead of ma

Re: [Nbd] [PATCH] nbd: set the logical and physical blocksize properly

2017-02-11 Thread Alex Bligh
> On 11 Feb 2017, at 12:43, Wouter Verhelst wrote: > >>> Interesting. Some input into the info extension (re blocksizes) would >>> definitely be appreciated. >>> >> >> What do you mean? Right now the client is just calling NBD_SET_BLKSIZE >> with 4k blocksize since all of our devices are 4k d

Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup

2017-02-11 Thread James Bottomley
On Mon, 2017-02-06 at 21:09 -0700, Jens Axboe wrote: > On 02/06/2017 05:14 PM, James Bottomley wrote: > > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: > > > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig > > > wrote: > > > > Dan, > > > > > > > > can you please quote your emails? I c

RE: [PATCH 00/16] multiqueue for MMC/SD third try

2017-02-11 Thread Avri Altman
> > The iozone results seem a bit consistent and all values seem to be noisy and > not say much. I don't know why really, maybe the test is simply not relevant, > the tests don't seem to be significantly affected by any of the patches, so > let's focus on the dd and find tests. Maybe use a more s

Re: [Nbd] [PATCH] nbd: set the logical and physical blocksize properly

2017-02-11 Thread Wouter Verhelst
On Fri, Feb 10, 2017 at 04:47:42PM -0500, Josef Bacik wrote: > On Fri, 2017-02-10 at 21:07 +0100, Alex Bligh wrote: > > > > > > On 10 Feb 2017, at 19:06, Josef Bacik wrote: > > > > > > We noticed when trying to do O_DIRECT to an export on the server > > > side > > > that we were getting requests