Re: [PATCH v2] don't forget to call pd_online_fn when activate policy

2017-03-10 Thread Jens Axboe
> On Mar 10, 2017, at 8:46 PM, zhouchengming wrote: > >> On 2017/3/10 23:12, Jens Axboe wrote: >>> On 03/08/2017 07:20 PM, Zhou Chengming wrote: >>> When we activate policy on the request_queue, we will create policy_date >>> for all the existing blkgs of the

[PATCH v3] don't forget to call pd_online_fn when activate policy

2017-03-10 Thread Zhou Chengming
When we activate policy on the request_queue, we will create policy_date for all the existing blkgs of the request_queue, so we should call pd_init_fn() and pd_online_fn() on these newly created policy_data. Signed-off-by: Zhou Chengming --- block/blk-cgroup.c | 6

Re: [PATCH v2] don't forget to call pd_online_fn when activate policy

2017-03-10 Thread zhouchengming
On 2017/3/10 23:12, Jens Axboe wrote: On 03/08/2017 07:20 PM, Zhou Chengming wrote: When we activate policy on the request_queue, we will create policy_date for all the existing blkgs of the request_queue, so we should call pd_init_fn() and pd_online_fn() on these newly created policy_data.

Re: [dm-devel] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2017-03-10 Thread Eric Wheeler
On Thu, 5 Jan 2017, Mike Snitzer wrote: > On Thu, Dec 29 2016 at 11:08pm -0500, > Eric Wheeler wrote: > > > On Sat, 17 Dec 2016, Mike Snitzer wrote: > > > On Fri, Dec 16 2016 at 5:29pm -0500, > > > Eric Wheeler wrote: > > > > On Wed,

Re: [PATCH v2] blk: improve order of bio handling in generic_make_request()

2017-03-10 Thread NeilBrown
On Fri, Mar 10 2017, Lars Ellenberg wrote: >> --- a/block/blk-core.c >> +++ b/block/blk-core.c >> @@ -1975,7 +1975,14 @@ generic_make_request_checks(struct bio *bio) >> */ >> blk_qc_t generic_make_request(struct bio *bio) >> { >> - struct bio_list bio_list_on_stack; >> + /* >> +

Re: [PATCH 06/16] mmc: core: replace waitqueue with worker

2017-03-10 Thread Jens Axboe
On 03/10/2017 07:21 AM, Adrian Hunter wrote: >> Essentially I take out that thread and replace it with this one worker >> introduced in this very patch. I agree the driver can block in many ways >> and that is why I need to have it running in process context, and this >> is what the worker

Re: [LFS/MM TOPIC][LFS/MM ATTEND]: - Storage Stack and Driver Testing methodology.

2017-03-10 Thread Bart Van Assche
On Tue, 2017-01-10 at 22:40 +, Chaitanya Kulkarni wrote: > Participants:- > -- > I'd like to invite developers from different subsystems to discuss an > approach towards  > a unified testing methodology for storage stack and device drivers belongs to  > different subsystems. >

Re: [PATCH v2] blk: improve order of bio handling in generic_make_request()

2017-03-10 Thread Lars Ellenberg
On Fri, Mar 10, 2017 at 04:07:58PM +0100, Jack Wang wrote: > On 10.03.2017 15:55, Mikulas Patocka wrote: > > On Fri, 10 Mar 2017, Mike Snitzer wrote: > >> On Fri, Mar 10 2017 at 7:34am -0500, > >> Lars Ellenberg wrote: > >> > --- a/block/blk-core.c > +++

Re: blk_integrity_revalidate() clears BDI_CAP_STABLE_WRITES

2017-03-10 Thread Ilya Dryomov
On Thu, Mar 2, 2017 at 4:24 AM, Martin K. Petersen wrote: >> "Ilya" == Ilya Dryomov writes: > > Ilya, > > Ilya> Given the above, I'm not sure what the baseline is -- > Ilya> blk_integrity code isn't invoked for data-only lbafs. Could nvme >

Re: [PATCH v2] blk: improve order of bio handling in generic_make_request()

2017-03-10 Thread Mike Snitzer
On Fri, Mar 10 2017 at 10:07am -0500, Jack Wang wrote: > > > On 10.03.2017 15:55, Mikulas Patocka wrote: > > > > > > On Fri, 10 Mar 2017, Mike Snitzer wrote: > > > >> On Fri, Mar 10 2017 at 7:34am -0500, > >> Lars Ellenberg wrote: >

Re: [PATCH v2] blk: improve order of bio handling in generic_make_request()

2017-03-10 Thread Jack Wang
On 10.03.2017 15:55, Mikulas Patocka wrote: > > > On Fri, 10 Mar 2017, Mike Snitzer wrote: > >> On Fri, Mar 10 2017 at 7:34am -0500, >> Lars Ellenberg wrote: >> --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1975,7 +1975,14 @@

Re: [PATCH v2] don't forget to call pd_online_fn when activate policy

2017-03-10 Thread Jens Axboe
On 03/08/2017 07:20 PM, Zhou Chengming wrote: > When we activate policy on the request_queue, we will create policy_date > for all the existing blkgs of the request_queue, so we should call > pd_init_fn() and pd_online_fn() on these newly created policy_data. > > Signed-off-by: Zhou Chengming

Re: [PATCH v2] blk: improve order of bio handling in generic_make_request()

2017-03-10 Thread Lars Ellenberg
> --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -1975,7 +1975,14 @@ generic_make_request_checks(struct bio *bio) > */ > blk_qc_t generic_make_request(struct bio *bio) > { > - struct bio_list bio_list_on_stack; > + /* > +* bio_list_on_stack[0] contains bios submitted

Re: [PATCH 0/4 v2] block: Fixes for bdi handling

2017-03-10 Thread Jan Kara
On Thu 09-03-17 09:41:01, Jens Axboe wrote: > On 03/09/2017 03:16 AM, Jan Kara wrote: > > Hi! > > > > this is a second revision of the series fixing the most urgent bugs that > > were > > introduced by commit 165a5e22fafb "block: Move bdi_unregister() to > > del_gendisk()" and by 0dba1314d4f8

Re: [PATCH RFC 22/39] mmc: block: Prepare CQE data

2017-03-10 Thread Adrian Hunter
On 10/03/17 00:39, Linus Walleij wrote: > On Fri, Mar 3, 2017 at 1:22 PM, Adrian Hunter wrote: >> On 15/02/17 15:49, Linus Walleij wrote: >>> On Fri, Feb 10, 2017 at 1:55 PM, Adrian Hunter >>> wrote: >>> Enhance mmc_blk_data_prep() to