Re: Status of pwritev2/preadv2 in glibc?

On 25/04/2017 18:23, Stephen Bates wrote: > >> I am working on it btw [1] > > Thanks for working on this Adhemerval! > >> PS: resending with cc to all. > > Can you cc linux-block when you submit the patchset? Sure, I am just finishing the sanity tests on the supported architectures.

Re: [resend PATCH v2 00/33] dax: introduce dax_operations

On Fri, Apr 21, 2017 at 6:06 PM, Dan Williams wrote: > [ adding akpm, sfr, and jens ] > > I applied this series and pushed it out for the nvdimm.git branch that > gets auto pulled into -next. The set is still awaiting acks from > device-mapper, ext4, xfs, and vfs (for

Re: [PATCH v5 05/10] blk-mq: Unregister debugfs attributes earlier

On Tue, Apr 25, 2017 at 10:24:48PM +, Bart Van Assche wrote: > On Tue, 2017-04-25 at 14:30 -0700, Omar Sandoval wrote: > > On Tue, Apr 25, 2017 at 01:37:40PM -0700, Bart Van Assche wrote: > > > One of the debugfs attributes allows to run a queue. Since running > > > a queue after a queue has

Re: [PATCH v5 05/10] blk-mq: Unregister debugfs attributes earlier

On 04/25/2017 03:24 PM, Bart Van Assche wrote: > On Tue, 2017-04-25 at 14:30 -0700, Omar Sandoval wrote: >> On Tue, Apr 25, 2017 at 01:37:40PM -0700, Bart Van Assche wrote: >>> One of the debugfs attributes allows to run a queue. Since running >>> a queue after a queue has entered the "dead" state

Re: [PATCH v5 05/10] blk-mq: Unregister debugfs attributes earlier

On Tue, 2017-04-25 at 14:30 -0700, Omar Sandoval wrote: > On Tue, Apr 25, 2017 at 01:37:40PM -0700, Bart Van Assche wrote: > > One of the debugfs attributes allows to run a queue. Since running > > a queue after a queue has entered the "dead" state is not allowed > > and triggers a use-after-free,

Re: [PATCH v5 10/10] scsi: Implement blk_mq_ops.show_rq()

On Tue, 2017-04-25 at 14:39 -0700, Omar Sandoval wrote: > On Tue, Apr 25, 2017 at 01:37:45PM -0700, Bart Van Assche wrote: > > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. > > Only thing I noticed was that the

Re: [PATCH v5 05/10] blk-mq: Unregister debugfs attributes earlier

On 04/25/2017 02:30 PM, Omar Sandoval wrote: > On Tue, Apr 25, 2017 at 01:37:40PM -0700, Bart Van Assche wrote: >> One of the debugfs attributes allows to run a queue. Since running >> a queue after a queue has entered the "dead" state is not allowed >> and triggers a use-after-free, unregister

Re: [PATCH v5 10/10] scsi: Implement blk_mq_ops.show_rq()

On Tue, Apr 25, 2017 at 01:37:45PM -0700, Bart Van Assche wrote: > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Only thing I noticed was that the only other caller I see has buf[70]. No idea if that's a meaningful

Re: [PATCH v5 09/10] blk-mq: Add blk_mq_ops.show_rq()

On Tue, Apr 25, 2017 at 01:37:44PM -0700, Bart Van Assche wrote: > This new callback function will be used in the next patch to show > more information about SCSI requests. Reviewed-by: Omar Sandoval > Signed-off-by: Bart Van Assche > Cc: Omar

Re: [PATCH v5 05/10] blk-mq: Unregister debugfs attributes earlier

On Tue, Apr 25, 2017 at 01:37:40PM -0700, Bart Van Assche wrote: > One of the debugfs attributes allows to run a queue. Since running > a queue after a queue has entered the "dead" state is not allowed > and triggers a use-after-free, unregister the debugfs attributes > before a queue reaches the

Re: Status of pwritev2/preadv2 in glibc?

> I am working on it btw [1] Thanks for working on this Adhemerval! > PS: resending with cc to all. Can you cc linux-block when you submit the patchset? Stephen

Re: [PATCH v5 04/10] blk-mq: Only unregister hctxs for which registration succeeded

On Tue, Apr 25, 2017 at 01:37:39PM -0700, Bart Van Assche wrote: > Hctx unregistration involves calling kobject_del(). kobject_del() > must not be called if kobject_add() has not been called. Hence in > the error path only unregister hctxs for which registration succeeded. > > Signed-off-by: Bart

[PATCH v5 02/10] blk-mq: Let blk_mq_debugfs_register() look up the queue name

A later patch will move the call of blk_mq_debugfs_register() to a function to which the queue name is not passed as an argument. To avoid having to add a 'name' argument to multiple callers, let blk_mq_debugfs_register() look up the queue name. Signed-off-by: Bart Van Assche

[PATCH v5 10/10] scsi: Implement blk_mq_ops.show_rq()

Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. Signed-off-by: Bart Van Assche Cc: Martin K. Petersen Cc: James Bottomley

[PATCH v5 09/10] blk-mq: Add blk_mq_ops.show_rq()

This new callback function will be used in the next patch to show more information about SCSI requests. Signed-off-by: Bart Van Assche Cc: Omar Sandoval Cc: Hannes Reinecke --- block/blk-mq-debugfs.c | 6 +- include/linux/blk-mq.h

[PATCH v5 01/10] blk-mq: Register /queue/mq after having registered /queue

A later patch in this series will modify blk_mq_debugfs_register() such that it uses q->kobj.parent to determine the name of a request queue. Hence make sure that that pointer is initialized before blk_mq_debugfs_register() is called. To avoid lock inversion, protect sysfs / debugfs registration

[PATCH v5 05/10] blk-mq: Unregister debugfs attributes earlier

One of the debugfs attributes allows to run a queue. Since running a queue after a queue has entered the "dead" state is not allowed and triggers a use-after-free, unregister the debugfs attributes before a queue reaches the "dead" state. Signed-off-by: Bart Van Assche

[PATCH v5 06/10] blk-mq: Move the "state" debugfs attribute one level down

Move the "state" attribute from the top level to the "mq" directory as requested by Omar. Signed-off-by: Bart Van Assche Reviewed-by: Omar Sandoval Reviewed-by: Hannes Reinecke --- block/blk-mq-debugfs.c | 9 + 1 file changed,

[PATCH v5 00/10] blk-mq debugfs patches for kernel v4.12

Hello Jens, Please consider the ten patches in this series for kernel v4.12. These patches improve blk-mq debugfs support. Thanks, Bart. Changes compared to v4: - Modified patch 4 such that debugfs registration failures no longer cause block device registration to fail. - Modified patch 8

[PATCH v5 08/10] blk-mq: Show operation, cmd_flags and rq_flags names

Show the operation name, .cmd_flags and .rq_flags as names instead of numbers. Signed-off-by: Bart Van Assche Reviewed-by: Omar Sandoval Reviewed-by: Hannes Reinecke --- block/blk-mq-debugfs.c | 72

[PATCH v5 07/10] blk-mq: Make blk_flags_show() callers append a newline character

This patch does not change any functionality but makes it possible to produce a single line of output with multiple flag-to-name translations. Signed-off-by: Bart Van Assche Reviewed-by: Omar Sandoval Reviewed-by: Hannes Reinecke ---

Get back to me

Good day. Did you receive the business proposal I sent to you yesterday? I was waiting for your reply but I am not sure if you receive the message. If for some reason you did not receive my previous email, I can resend the message to you. Please confirm as this is very urgent and important.

Re: [PATCH] lpfc: Fix memory corruption of the lpfc_ncmd->list pointers

On Tue, Apr 25, 2017 at 10:58:44AM -0700, Christoph Hellwig wrote: > On Fri, Apr 21, 2017 at 05:49:08PM -0700, jsmart2...@gmail.com wrote: > > This is a nvme-specific bug. The patch was cut against the > > linux-block tree, for-4.12/block tree. It should be pulled in through > > that tree. > > It

Re: [PATCH] lpfc: Fix memory corruption of the lpfc_ncmd->list pointers

On Fri, Apr 21, 2017 at 05:49:08PM -0700, jsmart2...@gmail.com wrote: > This is a nvme-specific bug. The patch was cut against the > linux-block tree, for-4.12/block tree. It should be pulled in through > that tree. It conflicts with your nvme changes that are in the nvme-4.12. Can you respin it?

Re: [PATCH] nvme/scsi: Consider LBA format in IO splitting calculation

Applied to nvme-4.12.

Re: [PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

From: Christoph Hellwig Sent: 25 April 2017 09:41 To: Javier Gonzalez; Matias Bjørling Cc: linux-n...@lists.infradead.org Subject: Re: [PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io Javier, Matias: can I get a

Re: [PATCH -next] lightnvm: fix possible memory leak in pblk_bb_discovery()

On 04/25/2017 09:15 AM, Wei Yongjun wrote: > From: Wei Yongjun > > 'blks' is malloced in pblk_bb_discovery() and should be freed > before leaving from the nvm_get_tgt_bb_tbl() error handling cases, > otherwise it will cause memory leak. Also skip assign blks to >

Re: [PATCH v3 10/20] fuse: set mapping error in writepage_locked when it fails

On Tue, 2017-04-25 at 13:19 +0200, Jan Kara wrote: > On Tue 25-04-17 06:35:13, Jeff Layton wrote: > > On Tue, 2017-04-25 at 10:17 +0200, Jan Kara wrote: > > > On Mon 24-04-17 13:14:36, Jeff Layton wrote: > > > > On Mon, 2017-04-24 at 18:04 +0200, Jan Kara wrote: > > > > > On Mon 24-04-17 09:22:49,

Re: [PATCH -next] lightnvm: fix possible memory leak in pblk_bb_discovery()

> On 25 Apr 2017, at 18.15, Wei Yongjun wrote: > > From: Wei Yongjun > > 'blks' is malloced in pblk_bb_discovery() and should be freed > before leaving from the nvm_get_tgt_bb_tbl() error handling cases, > otherwise it will cause memory leak. Also

Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq()

Bart, >> I was merely objecting to the fact that we already have umpteen existing >> interfaces for displaying SCSI command information. > Do you perhaps want me to change the for-loop into a call to > __scsi_format_command()? If possible, I would love to see some commonality in the

Re: [PATCH v4 09/10] blk-mq: Add blk_mq_ops.show_rq()

On 04/25/2017 08:16 AM, Hannes Reinecke wrote: > On 04/24/2017 11:51 PM, Bart Van Assche wrote: >> On Mon, 2017-04-24 at 09:32 +0200, Hannes Reinecke wrote: >>> On 04/22/2017 01:40 AM, Bart Van Assche wrote: --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h @@ -121,6 +121,12

[PATCH -next] lightnvm: fix possible memory leak in pblk_bb_discovery()

From: Wei Yongjun 'blks' is malloced in pblk_bb_discovery() and should be freed before leaving from the nvm_get_tgt_bb_tbl() error handling cases, otherwise it will cause memory leak. Also skip assign blks to rlun->bb_list when error. Fixes: a4bd217b4326 ("lightnvm:

Re: [PATCH v4 09/10] blk-mq: Add blk_mq_ops.show_rq()

On Tue, 2017-04-25 at 17:16 +0200, Hannes Reinecke wrote: > On 04/24/2017 11:51 PM, Bart Van Assche wrote: > > On Mon, 2017-04-24 at 09:32 +0200, Hannes Reinecke wrote: > > > On 04/22/2017 01:40 AM, Bart Van Assche wrote: > > > > --- a/include/linux/blk-mq.h > > > > +++ b/include/linux/blk-mq.h >

Re: [PATCH v4 09/10] blk-mq: Add blk_mq_ops.show_rq()

On 04/24/2017 11:51 PM, Bart Van Assche wrote: > On Mon, 2017-04-24 at 09:32 +0200, Hannes Reinecke wrote: >> On 04/22/2017 01:40 AM, Bart Van Assche wrote: >>> --- a/include/linux/blk-mq.h >>> +++ b/include/linux/blk-mq.h >>> @@ -121,6 +121,12 @@ struct blk_mq_ops { >>> softirq_done_fn

Re: Status of pwritev2/preadv2 in glibc?

On 24/04/2017 14:55, Stephen Bates wrote: > >> So far, no one has submitted a patch. > > OK, unless I hear that someone else is working on one I will take a look at > this. > >> I hope the off_t parameter is passed exactly the same way as for pwritev >> and its 64-bit variant, for all

Re: [PATCH v3 10/20] fuse: set mapping error in writepage_locked when it fails

On Tue 25-04-17 06:35:13, Jeff Layton wrote: > On Tue, 2017-04-25 at 10:17 +0200, Jan Kara wrote: > > On Mon 24-04-17 13:14:36, Jeff Layton wrote: > > > On Mon, 2017-04-24 at 18:04 +0200, Jan Kara wrote: > > > > On Mon 24-04-17 09:22:49, Jeff Layton wrote: > > > > > This ensures that we see errors

Re: [PATCH v3 10/20] fuse: set mapping error in writepage_locked when it fails

On Tue, 2017-04-25 at 10:17 +0200, Jan Kara wrote: > On Mon 24-04-17 13:14:36, Jeff Layton wrote: > > On Mon, 2017-04-24 at 18:04 +0200, Jan Kara wrote: > > > On Mon 24-04-17 09:22:49, Jeff Layton wrote: > > > > This ensures that we see errors on fsync when writeback fails. > > > > > > > >

Re: bfq-mq performance comparison to cfq

Hi, sorry if I jump into this interesting conversation, but I felt some people might have missed this and might be interested as well (even if from a slightly different POW). Let me Cc them (Patrick, Morten, Peter, Joel, Andres). On 19/04/17 09:02, Paolo Valente wrote: > > > Il giorno 19 apr

Re: [PATCH v3 10/20] fuse: set mapping error in writepage_locked when it fails

On Mon 24-04-17 13:14:36, Jeff Layton wrote: > On Mon, 2017-04-24 at 18:04 +0200, Jan Kara wrote: > > On Mon 24-04-17 09:22:49, Jeff Layton wrote: > > > This ensures that we see errors on fsync when writeback fails. > > > > > > Signed-off-by: Jeff Layton > > > > Hum, but do