Re: [PATCH v2] cfq-iosched: fix the delay of cfq_group's vdisktime under iops mode

Hi Jens, I didn't found the patch in your linux-block git tree and the vanilla git tree. Maybe you have forgot this CFQ fix ? Regards, Tao On 2017/3/9 19:22, Hou Tao wrote: > On 2017/3/8 22:05, Jan Kara wrote: >> On Wed 08-03-17 20:16:55, Hou Tao wrote: >>> When adding a cfq_group into the cfq

Re: [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue

On Tue, May 30, 2017 at 04:54:47PM +, Bart Van Assche wrote: > On Tue, 2017-05-30 at 08:22 +0800, Ming Lei wrote: > > On Sun, May 28, 2017 at 04:10:09PM +, Bart Van Assche wrote: > > > I really would like to see the blk_queue_quiesced() tests as close as > > > possible to > > > the

Re: [PATCH v2 3/8] blk-mq: use the introduced blk_mq_unquiesce_queue()

On Tue, May 30, 2017 at 03:12:41PM +, Bart Van Assche wrote: > On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote: > > --- a/drivers/scsi/scsi_lib.c > > +++ b/drivers/scsi/scsi_lib.c > > @@ -3030,7 +3030,10 @@ scsi_internal_device_unblock(struct scsi_device > > *sdev, > > return

Re: [PATCH v2 3/8] blk-mq: use the introduced blk_mq_unquiesce_queue()

On Tue, May 30, 2017 at 12:04:02PM -0700, Eduardo Valentin wrote: > On Sat, May 27, 2017 at 10:21:21PM +0800, Ming Lei wrote: > > blk_mq_unquiesce_queue() is used for unquiescing the > > queue explicitly, so replace blk_mq_start_stopped_hw_queues() > > with it. > > > > Cc:

Re: [PATCH] blk-mq: Take tagset lock when updaing hw queues

Keith Busch writes: > The tagset lock needs to be held when iterating the tag_list, so a > lockdep assert was added when updating number of hardware queues. The > drivers calling this API, however, were unaware of the new requirement, > so are failing the assertion. > >

Re: [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue

On Sun, 2017-05-28 at 18:44 +0800, Ming Lei wrote: > First it is really a fix, and then a improvement, so could you tell me > where is wrong with the title and the description? Hello Ming, Can you explain me why you want to keep the blk_mq_stop_hw_queues() call in nvme_suspend_queue()? Since

Re: [PATCH v2 3/8] blk-mq: use the introduced blk_mq_unquiesce_queue()

On Sat, May 27, 2017 at 10:21:21PM +0800, Ming Lei wrote: > blk_mq_unquiesce_queue() is used for unquiescing the > queue explicitly, so replace blk_mq_start_stopped_hw_queues() > with it. > > Cc: linux-n...@lists.infradead.org > Cc: linux-s...@vger.kernel.org > Cc: dm-de...@redhat.com >

[PATCH] blk-mq: Take tagset lock when updaing hw queues

The tagset lock needs to be held when iterating the tag_list, so a lockdep assert was added when updating number of hardware queues. The drivers calling this API, however, were unaware of the new requirement, so are failing the assertion. This patch takes the lock within the blk-mq function so

Re: WARNING triggers at blk_mq_update_nr_hw_queues during nvme_reset_work

Keith Busch writes: > On Tue, May 30, 2017 at 02:00:44PM -0300, Gabriel Krisman Bertazi wrote: >> Since the merge window for 4.12, one of the machines in Intel's CI >> started to hit the WARN_ON below at blk_mq_update_nr_hw_queues during an >> nvme_reset_work. The issue

Re: WARNING triggers at blk_mq_update_nr_hw_queues during nvme_reset_work

On Tue, 2017-05-30 at 13:55 -0400, Keith Busch wrote: > On Tue, May 30, 2017 at 02:00:44PM -0300, Gabriel Krisman Bertazi wrote: > > Since the merge window for 4.12, one of the machines in Intel's CI > > started to hit the WARN_ON below at blk_mq_update_nr_hw_queues during an > > nvme_reset_work.

Re: [PATCH 08/19] block: Introduce request_queue.initialize_rq_fn()

On Sun, 2017-05-28 at 10:37 +0200, Christoph Hellwig wrote: > Oh, and btw - for the mq case we don't want to use the function > pointer directly in the queue, but in blk_mq_ops, so that we have > all the mq methods in one place. Hello Christoph, Are you sure of this? All other function pointers

Re: WARNING triggers at blk_mq_update_nr_hw_queues during nvme_reset_work

On Tue, May 30, 2017 at 02:00:44PM -0300, Gabriel Krisman Bertazi wrote: > Since the merge window for 4.12, one of the machines in Intel's CI > started to hit the WARN_ON below at blk_mq_update_nr_hw_queues during an > nvme_reset_work. The issue persists with the latest 4.12-rc3, and full > dmesg

Re: [PATCH 4/5] blk-mq-debugfs: Show busy requests

On 05/30/2017 11:24 AM, Bart Van Assche wrote: >> [ ... ] >> During this small window, the request can be freed and reallocated >> in another I/O path, then use-after-free is caused. > > A similar remark applies to all request queue debugfs attributes: the > queue state can change immediately

Re: [PATCH 4/5] blk-mq-debugfs: Show busy requests

On Sat, 2017-05-27 at 11:16 +0800, Ming Lei wrote: > What is the real motivation for this debug interface, could Bart explain > a bit? As mentioned in the description of this patch, the purpose of this patch is to allow anyone who is working on a block driver to figure out whether or not a

Re: [PATCH 4/5] blk-mq-debugfs: Show busy requests

On Sat, 2017-05-27 at 08:54 +0800, Ming Lei wrote: > On Thu, May 25, 2017 at 04:38:09PM -0700, Bart Van Assche wrote: > > Requests that got stuck in a block driver are neither on > > blk_mq_ctx.rq_list nor on any hw dispatch queue. Make these > > visible in debugfs through the "busy" attribute. >

Re: [PATCH v2 5/8] blk-mq: update comments on blk_mq_quiesce_queue()

On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote: > /** > - * blk_mq_quiesce_queue() - wait until all ongoing queue_rq calls have > finished > + * blk_mq_quiesce_queue() - wait until all ongoing dispatching have finished > * @q: request queue. > * Hello Ming, The concept of dispatching

Re: [PATCH v2 6/8] blk-mq: don't stop queue for quiescing

On Tue, 2017-05-30 at 08:27 +0800, Ming Lei wrote: > On Sun, May 28, 2017 at 04:03:20PM +, Bart Van Assche wrote: > > On Sun, 2017-05-28 at 18:50 +0800, Ming Lei wrote: > > > On Sat, May 27, 2017 at 09:49:27PM +, Bart Van Assche wrote: > > > > On Sat, 2017-05-27 at 22:21 +0800, Ming Lei

Re: [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue

On Tue, 2017-05-30 at 08:22 +0800, Ming Lei wrote: > On Sun, May 28, 2017 at 04:10:09PM +, Bart Van Assche wrote: > > I really would like to see the blk_queue_quiesced() tests as close as > > possible to > > the blk_mq_hctx_stopped() tests. But I agree that we need a way to document > >

Re: [PATCH 1/3] cfq-iosched: Mark cfq_clear_cfqq_*() as __maybe_unused

Christoph, On Sun, May 28, 2017 at 12:49 AM, Christoph Hellwig wrote: > On Fri, May 26, 2017 at 02:22:35PM -0700, Matthias Kaehlcke wrote: >> This fixes the following warning when building with clang: >> >> block/cfq-iosched.c:449:1: error: unused function

Re: [PATCH 09/10] xfs: nowait aio support

On 05/29/2017 03:33 AM, Christoph Hellwig wrote: > On Sun, May 28, 2017 at 09:38:26PM -0500, Goldwyn Rodrigues wrote: >> >> >> On 05/28/2017 04:31 AM, Christoph Hellwig wrote: >>> Despite my previous reviewed-by tag this will need another fix: >>> >>> xfs_file_iomap_begin needs to return EAGAIN

Re: [PATCH 3/3] cfq-iosched: Delete unused function min_vdisktime()

On 05/26/2017 03:22 PM, Matthias Kaehlcke wrote: > This fixes the following warning when building with clang: > > block/cfq-iosched.c:970:19: error: unused function 'min_vdisktime' > [-Werror,-Wunused-function] I have applied this one for 4.13, as that is just dead code. I don't

Re: [PATCH v2 2/8] block: introduce flag of QUEUE_FLAG_QUIESCED

On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote: > This flag is introduced for fixing & improving the quiescing code. Hello Ming, Since the quiescing code works fine, a better description would be that the purpose of this flag is to allow block drivers to use both the queue stopping and queue

Re: [PATCH v2 1/8] blk-mq: introduce blk_mq_unquiesce_queue

On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote: > + * blk_mq_unquiesce_queue() - pair of blk_mq_quiesce_queue() Sorry but that comment is incomprehensible to me. Did you perhaps mean "counterpart" instead of "pair"? Bart.

Re: [PATCH v2 3/8] blk-mq: use the introduced blk_mq_unquiesce_queue()

On Sat, 2017-05-27 at 22:21 +0800, Ming Lei wrote: > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -3030,7 +3030,10 @@ scsi_internal_device_unblock(struct scsi_device *sdev, > return -EINVAL; > > if (q->mq_ops) { > -

Re: [PATCH] nbd: add FUA op support

On 05/25/2017 09:55 PM, Shaun McDowell wrote: > NBD userland client and server have FUA (forced unit access) support > and flags defined. Make NBD kernel module recognize NBD_FLAG_SEND_FUA, > enable FUA on the queue, and forward FUA requests to the server. Queued up for 4.13, thanks. -- Jens

Re: [PATCH v2 1/2] nbd: nbd_reset() call in nbd_dev_add() is redundant

On 05/23/2017 09:49 AM, Ilya Dryomov wrote: > There is nothing to clear -- nbd_device has just been allocated. > Fold nbd_reset() into its other caller, nbd_config_put(). Added 1+2 for 4.12. -- Jens Axboe

Re: [PATCH] ligtnvm: if LUNs are already allocated fix return

On Mon, May 29, 2017 at 11:05 AM, Rakesh Pandit wrote: > Hi Matias, > > On Mon, May 15, 2017 at 06:31:58AM +, Javier Gonzalez wrote: >> > >> > On 13 May 2017, at 21.50, Rakesh Pandit wrote: >> > >> > While creating new device with NVM_DEV_CREATE if LUNs

Re: [PATCH] nbd: add FUA op support

On Thu, May 25, 2017 at 11:55:54PM -0400, Shaun McDowell wrote: > NBD userland client and server have FUA (forced unit access) support > and flags defined. Make NBD kernel module recognize NBD_FLAG_SEND_FUA, > enable FUA on the queue, and forward FUA requests to the server. > > Signed-off-by:

Re: [PATCH v2 2/2] nbd: don't leak nbd_config

On Tue, May 23, 2017 at 05:49:55PM +0200, Ilya Dryomov wrote: > nbd_config is allocated in nbd_alloc_config(), but never freed. > > Fixes: 5ea8d10802ec ("nbd: separate out the config information") > Signed-off-by: Ilya Dryomov Reviewed-by: Josef Bacik

Re: [PATCH v2 1/2] nbd: nbd_reset() call in nbd_dev_add() is redundant

On Tue, May 23, 2017 at 05:49:54PM +0200, Ilya Dryomov wrote: > There is nothing to clear -- nbd_device has just been allocated. > Fold nbd_reset() into its other caller, nbd_config_put(). > > Signed-off-by: Ilya Dryomov Reviewed-by: Josef Bacik Thanks,

Re: [PATCH 01/22] Revert "afs: Move UUID struct to linux/uuid.h"

Christoph Hellwig wrote: > This reverts commit ff548773106ec7f8031bc6172e0234bd2a02c19c. > > The V1 uuid intrepreatation in struct form isn't really useful to the > rest of the kernel, and not really compatible to it either, so move it > back to AFS instead of polluting the global