Re: [PATCH 01/19] bcache: Fix leak of bdev reference

2017-09-05 Thread Coly Li
On 2017/9/5 下午2:43, Christoph Hellwig wrote: > On Tue, Sep 05, 2017 at 01:30:04AM +0800, Coly Li wrote: >> >> When you mentioned "whole chunk of code", do you mean the following >> block of code ? >> >> >> 1960 if (IS_ERR(bdev)) { >> = start of whole chunk of code >>

Re: [PATCH V6 00/18] blk-throttle: add .low limit

2017-09-05 Thread Joseph Qi
Hi Shaohua, On 17/9/6 05:02, Shaohua Li wrote: > On Thu, Aug 31, 2017 at 09:24:23AM +0200, Paolo VALENTE wrote: >> >>> Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li ha scritto: >>> >>> Hi, >>> >>> cgroup still lacks a good iocontroller. CFQ works well for hard disk, but >>> not

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-05 Thread Omar Sandoval
On Wed, Sep 06, 2017 at 09:24:49AM +1000, Dave Chinner wrote: > On Tue, Sep 05, 2017 at 03:18:51PM -0700, Omar Sandoval wrote: > > On Wed, Sep 06, 2017 at 08:06:31AM +1000, Dave Chinner wrote: > > > On Tue, Sep 05, 2017 at 09:00:26AM -0600, Jens Axboe wrote: > > > > On 09/05/2017 01:37 AM, Chandan

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-05 Thread Omar Sandoval
On Wed, Sep 06, 2017 at 08:06:31AM +1000, Dave Chinner wrote: > On Tue, Sep 05, 2017 at 09:00:26AM -0600, Jens Axboe wrote: > > On 09/05/2017 01:37 AM, Chandan Rajendra wrote: > > > On Tuesday, September 5, 2017 12:12:08 PM IST Omar Sandoval wrote: > > >> On Mon, Sep 04, 2017 at 11:31:39PM -0700,

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-05 Thread Eric Sandeen
On 9/5/17 5:10 PM, Dave Chinner wrote: > On Tue, Sep 05, 2017 at 09:17:42AM -0500, Eric Sandeen wrote: >> >> >> On 9/5/17 1:44 AM, Dave Chinner wrote: >>> On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote: On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote:

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-05 Thread Dave Chinner
On Tue, Sep 05, 2017 at 09:00:26AM -0600, Jens Axboe wrote: > On 09/05/2017 01:37 AM, Chandan Rajendra wrote: > > On Tuesday, September 5, 2017 12:12:08 PM IST Omar Sandoval wrote: > >> On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote: > >>> On Tue, Sep 05, 2017 at 11:14:42AM

[PATCH] loop: set physical block size to logical block size

2017-09-05 Thread Omar Sandoval
From: Omar Sandoval Commit 6c6b6f28b333 ("loop: set physical block size to PAGE_SIZE") caused mkfs.xfs to barf on ppc64 [1]. Always using PAGE_SIZE as the physical block size still makes the most sense semantically, but let's just lie and always set it to the same value as the

Re: [PATCH V6 00/18] blk-throttle: add .low limit

2017-09-05 Thread Shaohua Li
On Thu, Aug 31, 2017 at 09:24:23AM +0200, Paolo VALENTE wrote: > > > Il giorno 15 gen 2017, alle ore 04:42, Shaohua Li ha scritto: > > > > Hi, > > > > cgroup still lacks a good iocontroller. CFQ works well for hard disk, but > > not > > much for SSD. This patch set try to add a

Re: [PATCH V7 00/10] mmc: Add Command Queue support

2017-09-05 Thread Ulf Hansson
On 5 September 2017 at 10:10, Adrian Hunter wrote: > On 05/09/17 10:24, Ulf Hansson wrote: >> [...] >> > > I can send blk-mq support for legacy requests in a few days if you like, > but > I want to hear a better explanation of why you are delaying CQE

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-05 Thread Jens Axboe
On 09/05/2017 01:37 AM, Chandan Rajendra wrote: > On Tuesday, September 5, 2017 12:12:08 PM IST Omar Sandoval wrote: >> On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote: >>> On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote: Linux kernel commit

[GIT PULL] First set of block changes for 4.14-rc1

2017-09-05 Thread Jens Axboe
Hi Linus, This is the first pull request for 4.14, containing most of the code changes. It's a quiet series this round, which I think we needed after the churn of the last few series. This pull request contains: - Fix for a registration race in loop, from Anton Volkov. - Overflow complaint fix

Archiving linux-block

2017-09-05 Thread Bart Van Assche
Hello, Since gmane.org is no longer operational linux-block messages are no longer archived. I think it's useful to archive linux-block messages because it makes it possible to review past discussions, especially for people who are not subscribed to the list. How about activating archival by

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-05 Thread Eric Sandeen
On 9/5/17 1:44 AM, Dave Chinner wrote: > On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote: >> On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote: >>> Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set >>> physical block size to PAGE_SIZE) now

Re: BFQ + dm-mpath

2017-09-05 Thread Bart Van Assche
On Tue, 2017-09-05 at 09:56 +0200, Paolo Valente wrote: > Ok, my suspects seem confirmed: the path dm_mq_queue_rq -> map_request > -> setup_clone -> blk_rq_prep_clone creates a cloned request without > invoking e->type->ops.mq.prepare_request for the target elevator e. > The cloned request is

Re: [PATCH V7 00/10] mmc: Add Command Queue support

2017-09-05 Thread Adrian Hunter
On 05/09/17 10:24, Ulf Hansson wrote: > [...] > I can send blk-mq support for legacy requests in a few days if you like, but I want to hear a better explanation of why you are delaying CQE support. >>> >>> That would be very nice, however be aware of that we are in the merge

Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

2017-09-05 Thread Chandan Rajendra
On Tuesday, September 5, 2017 12:12:08 PM IST Omar Sandoval wrote: > On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote: > > On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote: > > > Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set > > > physical

Re: [PATCH V7 00/10] mmc: Add Command Queue support

2017-09-05 Thread Ulf Hansson
[...] >>> >>> I can send blk-mq support for legacy requests in a few days if you like, but >>> I want to hear a better explanation of why you are delaying CQE support. >> >> That would be very nice, however be aware of that we are in the merge >> window, so I am not picking new material for 4.14

Re: [PATCH 01/19] bcache: Fix leak of bdev reference

2017-09-05 Thread Coly Li
On 2017/9/5 下午2:43, Christoph Hellwig wrote: > On Tue, Sep 05, 2017 at 01:30:04AM +0800, Coly Li wrote: >> >> When you mentioned "whole chunk of code", do you mean the following >> block of code ? >> >> >> 1960 if (IS_ERR(bdev)) { >> = start of whole chunk of code >>

Re: [PATCH 01/19] bcache: Fix leak of bdev reference

2017-09-05 Thread Christoph Hellwig
On Tue, Sep 05, 2017 at 01:30:04AM +0800, Coly Li wrote: > > When you mentioned "whole chunk of code", do you mean the following > block of code ? > > > 1960 if (IS_ERR(bdev)) { > = start of whole chunk of code > 1961 if (bdev == ERR_PTR(-EBUSY)) { >