Re: [GIT PULL] Block fixes for 4.19-rc6

[Greg Kroah-Hartman]

On Sat, Sep 29, 2018 at 03:12:25PM -0600, Jens Axboe wrote:
> Hi Greg,
> 
> A set of fixes that should go into this release. This pull request
> contains:
> 
> - A fix (hopefully) for the persistent grants for xen-blkfront. A
>   previous fix from this series wasn't complete, hence reverted, and
>   this one should hopefully be it. (Boris Ostrovsky)
> 
> - Fix for an elevator drain warning with SMR devices, which is triggered
>   when you switch schedulers (Damien)
> 
> - bcache deadlock fix (Guoju Fang)
> 
> - Fix for the block unplug tracepoint, which has had the timer/explicit
>   flag reverted since 4.11 (Ilya)
> 
> - Fix a regression in this series where the blk-mq timeout hook is
>   invoked with the RCU read lock held, hence preventing it from blocking
>   (Keith)
> 
> - NVMe pull from Christoph, with a single multipath fix (Susobhan Dey)
> 
> Please pull!
> 
> 
>   git://git.kernel.dk/linux-block.git tags/for-linus-20180929

Now pulled, thanks.

greg k-h

[GIT PULL] Block fixes for 4.19-rc6

[Jens Axboe]

Hi Greg,

A set of fixes that should go into this release. This pull request
contains:

- A fix (hopefully) for the persistent grants for xen-blkfront. A
  previous fix from this series wasn't complete, hence reverted, and
  this one should hopefully be it. (Boris Ostrovsky)

- Fix for an elevator drain warning with SMR devices, which is triggered
  when you switch schedulers (Damien)

- bcache deadlock fix (Guoju Fang)

- Fix for the block unplug tracepoint, which has had the timer/explicit
  flag reverted since 4.11 (Ilya)

- Fix a regression in this series where the blk-mq timeout hook is
  invoked with the RCU read lock held, hence preventing it from blocking
  (Keith)

- NVMe pull from Christoph, with a single multipath fix (Susobhan Dey)

Please pull!


  git://git.kernel.dk/linux-block.git tags/for-linus-20180929



Boris Ostrovsky (1):
  xen/blkfront: When purging persistent grants, keep them in the buffer

Damien Le Moal (1):
  block: fix deadline elevator drain for zoned block devices

Guoju Fang (1):
  bcache: add separate workqueue for journal_write to avoid deadlock

Ilya Dryomov (1):
  blk-mq: I/O and timer unplugs are inverted in blktrace

Jens Axboe (2):
  Revert "xen/blkfront: When purging persistent grants, keep them in the 
buffer"
  Merge branch 'nvme-4.19' of git://git.infradead.org/nvme into for-linus

Juergen Gross (1):
  xen/blkfront: correct purging of persistent grants

Keith Busch (1):
  blk-mq: Allow blocking queue tag iter callbacks

Susobhan Dey (1):
  nvme: properly propagate errors in nvme_mpath_init

 block/blk-mq-tag.c| 13 -
 block/blk-mq.c|  4 ++--
 block/elevator.c  |  2 +-
 drivers/block/xen-blkfront.c  |  4 ++--
 drivers/md/bcache/bcache.h|  1 +
 drivers/md/bcache/journal.c   |  6 +++---
 drivers/md/bcache/super.c |  8 
 drivers/nvme/host/multipath.c |  6 --
 8 files changed, 25 insertions(+), 19 deletions(-)

-- 
Jens Axboe

Re: [PATCH -next] lightnvm: pblk: fix error handling of pblk_lines_init()

[Matias Bjørling]

On 9/26/18 8:29 AM, Hans Holmberg wrote:

On Wed, Sep 26, 2018 at 7:47 AM Wei Yongjun  wrote:


In the too many bad blocks error handling case, we should release all
the alloced resources instead direct return, otherwise it will cause
memory leak.

Fixes: 2deeefc02dff ("lightnvm: pblk: fail gracefully on line alloc. failure")
Signed-off-by: Wei Yongjun 
---
  drivers/lightnvm/pblk-init.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 537e98f..a26f4e6 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -1083,7 +1083,8 @@ static int pblk_lines_init(struct pblk *pblk)

 if (!nr_free_chks) {
 pblk_err(pblk, "too many bad blocks prevent for sane 
instance\n");
-   return -EINTR;
+   ret = -EINTR;
+   goto fail_free_lines;
 }

 pblk_set_provision(pblk, nr_free_chks);



Looks good to me.

Reviewed-by: Hans Holmberg 



Thanks. Applied for 4.20.