Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Jens Axboe
On 10/3/18 4:51 PM, Bart Van Assche wrote: > On Wed, 2018-10-03 at 16:12 -0600, Jens Axboe wrote: >> On 10/3/18 3:42 PM, Bart Van Assche wrote: >>> On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: /* + * Show "busy" requests - these are the requests owned by the block

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Bart Van Assche
On Wed, 2018-10-03 at 16:12 -0600, Jens Axboe wrote: > On 10/3/18 3:42 PM, Bart Van Assche wrote: > > On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: > > > /* > > > + * Show "busy" requests - these are the requests owned by the block > > > driver. > > > + * The test

Re: [PATCH] block: Finish renaming REQ_DISCARD into REQ_OP_DISCARD

2018-10-03 Thread Jens Axboe
On 10/3/18 2:56 PM, Bart Van Assche wrote: > From: Bart Van Assche > > Some time ago REQ_DISCARD was renamed into REQ_OP_DISCARD. Some comments > and documentation files were not updated however. Update these comments > and documentation files. See also commit 4e1b2d52a80d ("block, fs, >

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Jens Axboe
On 10/3/18 3:42 PM, Bart Van Assche wrote: > On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: >> On Fri, 2018-01-12 at 15:05 -0700, Jens Axboe wrote: >>> On 1/12/18 3:00 PM, Bart Van Assche wrote: On Fri, 2018-01-12 at 14:55 -0700, Jens Axboe wrote: > On 1/12/18 2:52 PM, Bart Van

Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started

2018-10-03 Thread Bart Van Assche
On Fri, 2018-01-12 at 22:11 +, Bart Van Assche wrote: > On Fri, 2018-01-12 at 15:05 -0700, Jens Axboe wrote: > > On 1/12/18 3:00 PM, Bart Van Assche wrote: > > > On Fri, 2018-01-12 at 14:55 -0700, Jens Axboe wrote: > > > > On 1/12/18 2:52 PM, Bart Van Assche wrote: > > > > > When debugging

Re: [PATCH v2] block: fix rdma queue mapping

2018-10-03 Thread Sagi Grimberg
Can we please make forward progress on this? Christoph, Sagi: it seems you think /proc/irq/$IRP/smp_affinity shouldn't be allowed if drivers support managed affinity. Is that correct? Perhaps that can be codified and be a way forward? IE: Somehow allow the admin to choose either "managed

[PATCH] block: Finish renaming REQ_DISCARD into REQ_OP_DISCARD

2018-10-03 Thread Bart Van Assche
From: Bart Van Assche Some time ago REQ_DISCARD was renamed into REQ_OP_DISCARD. Some comments and documentation files were not updated however. Update these comments and documentation files. See also commit 4e1b2d52a80d ("block, fs, drivers: remove REQ_OP compat defs and related code").

Re: [PATCH v2] block: fix rdma queue mapping

2018-10-03 Thread Steve Wise
On 8/24/2018 9:17 PM, Sagi Grimberg wrote: > >>> nvme-rdma attempts to map queues based on irq vector affinity. >>> However, for some devices, completion vector irq affinity is >>> configurable by the user which can break the existing assumption >>> that irq vectors are optimally arranged over

Re: [PATCH] block: BFQ default for single queue devices

2018-10-03 Thread Paolo Valente
> Il giorno 02 ott 2018, alle ore 14:43, Linus Walleij > ha scritto: > > This sets BFQ as the default scheduler for single queue > block devices (nr_hw_queues == 1) if it is available. This > affects notably MMC/SD-cards but notably also UBI and > the loopback device. > > I have been