Re: [PATCH v2 00/11] Convert floppy drivers to blk-mq

2018-10-13 Thread Finn Thain 
On Thu, 11 Oct 2018, Omar Sandoval wrote:

> From: Omar Sandoval 
> 
> Hi,
> 
> This series converts the various floppy drivers to blk-mq. Save for the
> last one (floppy), they're compile-tested only. If I've Cc'd you, it's
> because I think you might be able to test the changes. Please test if
> you can, or let me know if there's a way to use QEMU/some other emulator
> to test. The full series is available at [1]. Thanks!
> 

I built your mq-conversions branch (425e985d1937) and asked Stan to test 
this on his Centris 650. There are no regressions in the swim driver.

-- 

> Changes from v1:
> 
> - Drop "swim3: end whole request on error" and "floppy: end whole
>   request on error".
> - Handle errors on individual bios correctly in the other drivers.
> 
> Cc: Benjamin Herrenschmidt 
> Cc: Finn Thain 
> Cc: Laurent Vivier 
> 
> 1: https://github.com/osandov/linux/tree/mq-conversions.
> 
> Omar Sandoval (11):
>   swim: fix cleanup on setup error
>   swim: convert to blk-mq
>   swim3: add real error handling in setup
>   swim3: convert to blk-mq
>   amiflop: fold headers into C file
>   amiflop: clean up on errors during setup
>   amiflop: convert to blk-mq
>   ataflop: fold headers into C file
>   ataflop: fix error handling during setup
>   ataflop: convert to blk-mq
>   floppy: convert to blk-mq
> 
>  arch/m68k/include/asm/atafd.h|  13 --
>  arch/m68k/include/asm/atafdreg.h |  80 
>  drivers/block/amiflop.c  | 328 +++
>  drivers/block/ataflop.c  | 283 +++---
>  drivers/block/floppy.c   |  74 ---
>  drivers/block/swim.c | 114 ++-
>  drivers/block/swim3.c| 219 ++---
>  include/linux/amifd.h|  63 --
>  include/linux/amifdreg.h |  82 
>  9 files changed, 590 insertions(+), 666 deletions(-)
>  delete mode 100644 arch/m68k/include/asm/atafd.h
>  delete mode 100644 arch/m68k/include/asm/atafdreg.h
>  delete mode 100644 include/linux/amifd.h
>  delete mode 100644 include/linux/amifdreg.h
> 
>

[PATCH] partitions/ldm: Off by one in ldm_relative()

2018-10-13 Thread Dan Carpenter 
The > should be >= or otherwise we could end up reading one element
beyond the end of the array.

Signed-off-by: Dan Carpenter 
---
 block/partitions/ldm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/partitions/ldm.c b/block/partitions/ldm.c
index 16766f267559..f48bcd2f5226 100644
--- a/block/partitions/ldm.c
+++ b/block/partitions/ldm.c
@@ -636,7 +636,7 @@ static int ldm_relative(const u8 *buffer, int buflen, int 
base, int offset)
 {
 
base += offset;
-   if (!buffer || offset < 0 || base > buflen) {
+   if (!buffer || offset < 0 || base >= buflen) {
if (!buffer)
ldm_error("!buffer");
if (offset < 0)
-- 
2.18.0

Re: [GIT PULL] Block fix for 4.19-rc

2018-10-13 Thread Greg Kroah-Hartman 
On Fri, Oct 12, 2018 at 01:16:28PM -0600, Jens Axboe wrote:
> Hi Greg,
> 
> Just a single fix that should go in, fixing a regression introduced in
> the blk-wbt code.
> 
> Please pull!
> 
> 
>   git://git.kernel.dk/linux-block.git tags/for-linus-20181012

Now merged, thanks.

greg k-h