Re: [PATCH] blk-mq: place trace_block_getrq() in correct place

2018-10-23 Thread jianchao.wang
On 10/23/18 10:30 PM, Xiaoguang Wang wrote: > trace_block_getrq() is to indicate a request struct has been allcoated > for queue, so put it in right place. > > Signed-off-by: Xiaoguang Wang > --- > block/blk-mq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] block: fix rdma queue mapping

2018-10-23 Thread Sagi Grimberg
Sagi - From what I can tell, i40iw is also exposed to this same issue if the IRQ affinity is configured by user. managed affinity does not allow setting smp_affinity from userspace.

Re: [PATCH v2] block: fix rdma queue mapping

2018-10-23 Thread Shiraz Saleem
On Tue, Oct 23, 2018 at 03:25:06PM -0600, Sagi Grimberg wrote: > > Christoph, Sagi: it seems you think /proc/irq/$IRP/smp_affinity > shouldn't be allowed if drivers support managed affinity. Is that > correct? > >>> > >>> Not just shouldn't, but simply can't. > >>> > But as

RE: [PATCH v2] block: fix rdma queue mapping

2018-10-23 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg > Sent: Tuesday, October 23, 2018 4:25 PM > To: Steve Wise ; 'Christoph Hellwig' > > Cc: linux-block@vger.kernel.org; linux-r...@vger.kernel.org; linux- > n...@lists.infradead.org; 'Max Gurtovoy' > Subject: Re: [PATCH v2] block: fix rdma

Re: [PATCH v2] block: fix rdma queue mapping

2018-10-23 Thread Sagi Grimberg
Christoph, Sagi: it seems you think /proc/irq/$IRP/smp_affinity shouldn't be allowed if drivers support managed affinity. Is that correct? Not just shouldn't, but simply can't. But as it stands, things are just plain borked if an rdma driver supports ib_get_vector_affinity() yet the admin

Re: [PATCH 1/2] loop/006: Add test for setting partscan flag

2018-10-23 Thread Omar Sandoval
On Tue, Oct 23, 2018 at 12:05:12PM +0200, Jan Kara wrote: > On Mon 22-10-18 15:52:55, Omar Sandoval wrote: > > On Thu, Oct 18, 2018 at 12:31:46PM +0200, Jan Kara wrote: > > > Add test for setting partscan flag. > > > > > > Signed-off-by: Jan Kara > > > > Sorry I didn't notice this earlier, but

Re: [PATCH blktests] common/rc: allow the loop driver to be built into the kernel

2018-10-23 Thread Omar Sandoval
On Tue, Oct 23, 2018 at 08:56:24AM -0400, Theodore Y. Ts'o wrote: > On Mon, Oct 22, 2018 at 04:08:30PM -0700, Omar Sandoval wrote: > > On Mon, Oct 22, 2018 at 06:50:04AM -0400, Theodore Ts'o wrote: > > > A number of kernel modules used by blktests must be compiled as > > > modules, since the

[PATCH] blk-mq: place trace_block_getrq() in correct place

2018-10-23 Thread Xiaoguang Wang
trace_block_getrq() is to indicate a request struct has been allcoated for queue, so put it in right place. Signed-off-by: Xiaoguang Wang --- block/blk-mq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index e3c39ea8e17b..93aec25f1340

RE: [PATCH v2] block: fix rdma queue mapping

2018-10-23 Thread Steve Wise
> >> Christoph, Sagi: it seems you think /proc/irq/$IRP/smp_affinity > >> shouldn't be allowed if drivers support managed affinity. Is that correct? > > > > Not just shouldn't, but simply can't. > > > >> But as it stands, things are just plain borked if an rdma driver > >> supports

Re: [PATCH blktests] common/rc: allow the loop driver to be built into the kernel

2018-10-23 Thread Theodore Y. Ts'o
On Mon, Oct 22, 2018 at 04:08:30PM -0700, Omar Sandoval wrote: > On Mon, Oct 22, 2018 at 06:50:04AM -0400, Theodore Ts'o wrote: > > A number of kernel modules used by blktests must be compiled as > > modules, since the module needs to be loaded with specific options, or > > part of the test is to

Re: [PATCH 1/2] loop/006: Add test for setting partscan flag

2018-10-23 Thread Jan Kara
On Mon 22-10-18 15:52:55, Omar Sandoval wrote: > On Thu, Oct 18, 2018 at 12:31:46PM +0200, Jan Kara wrote: > > Add test for setting partscan flag. > > > > Signed-off-by: Jan Kara > > Sorry I didn't notice this earlier, but loop/001 already does a > partition rescan (via losetup -P). Does that

Re: [PATCH v2] block: fix rdma queue mapping

2018-10-23 Thread Sagi Grimberg
Christoph, Sagi: it seems you think /proc/irq/$IRP/smp_affinity shouldn't be allowed if drivers support managed affinity. Is that correct? Not just shouldn't, but simply can't. But as it stands, things are just plain borked if an rdma driver supports ib_get_vector_affinity() yet the admin