Re: [PATCH 08/24] btrfs: Convert to separately allocated bdi

2017-02-08 Thread David Sterba
On Thu, Feb 02, 2017 at 06:34:06PM +0100, Jan Kara wrote: > Allocate struct backing_dev_info separately instead of embedding it > inside superblock. This unifies handling of bdi among users. > > CC: Chris Mason <c...@fb.com> > CC: Josef Bacik <jba...@fb.com> > CC:

Re: [PATCH 8/8] nowait aio: btrfs

2017-04-18 Thread David Sterba
tion > + Writing beyond end of file which is not allocated > > Signed-off-by: Goldwyn Rodrigues <rgold...@suse.com> Acked-by: David Sterba <dste...@suse.com> > + if ((iocb->ki_flags & IOCB_NOWAIT) && > + (iocb->ki_

Re: [PATCH v2] btrfs: Correct assignment of pos

2017-07-07 Thread David Sterba
sequence in the fast path. > > Changes since v1: > - Moved pos higher up to encompass check_can_nocow() call. > > Fixes: edf064e7c6fe ("btrfs: nowait aio support") > Signed-off-by: Goldwyn Rodrigues <rgold...@suse.com> Acked-by: David Sterba <dste...@suse.com>

[PATCH] block: note about cloned bios and bio_for_each_segment_all

2017-07-14 Thread David Sterba
: https://patchwork.kernel.org/patch/9839267/ The cloned/bi_vcnt behaviour seems tobe implementation dependent and is not documented, so this patch at least warns about this one particular case but this might still be insufficient. CC: linux-block@vger.kernel.org Signed-off-by: David Sterba <d

Re: [PATCH] block: note about cloned bios and bio_for_each_segment_all

2017-07-14 Thread David Sterba
On Fri, Jul 14, 2017 at 09:47:30PM +0800, Ming Lei wrote: > On Fri, Jul 14, 2017 at 9:40 PM, David Sterba <dste...@suse.com> wrote: > > We've switched to cloned bios in btrfs and hit a nasty bug leading to > > corruptions, when cloned bios are iterated by bio_for_each_segm

Re: [PATCH] block: note about cloned bios and bio_for_each_segment_all

2017-07-14 Thread David Sterba
On Fri, Jul 14, 2017 at 08:22:31AM -0600, Jens Axboe wrote: > /* > * drivers should _never_ use the all version - the bio may have been split > - * before it got to the driver and the driver won't own all of it > + * before it got to the driver and the driver won't own all of it. > + * > + *

Re: Commit edf064e7c (btrfs: nowait aio support) breaks shells

2017-07-10 Thread David Sterba
On Fri, Jul 07, 2017 at 08:09:28PM -0600, Jens Axboe wrote: > On 07/07/2017 07:51 PM, Goldwyn Rodrigues wrote: > > On 07/04/2017 05:16 PM, Jens Axboe wrote: > >> > >> Please expedite getting this upstream, asap. > > > > I have posted an updated patch [1] and it is acked by David. Would you > >

Re: [PATCH] btrfs: use new block error code

2017-06-21 Thread David Sterba
<dan.carpen...@oracle.com> Acked-by: David Sterba <dste...@suse.com> The patch depends on the blk_status_t patchset, so I expect that it's going to be merged to that.

Re: [PATCH v2 00/51] block: support multipage bvec

2017-06-26 Thread David Sterba
/btrfs: convert to bio_for_each_segment_all_sp() Acked-by: David Sterba <dste...@suse.com> for all the btrfs patches.

Re: dedicated error codes for the block layer

2017-05-18 Thread David Sterba
On Thu, May 18, 2017 at 03:17:57PM +0200, Christoph Hellwig wrote: > This series introduces a new blk_status_t error code type for the block > layer so that we can have tigher control and explicit semantics for > block layer errors. > > All but the last three patches are cleanups that lead to the

Re: [PATCH 05/13] fs: remove the unused error argument to dio_end_io()

2017-05-29 Thread David Sterba
On Fri, May 26, 2017 at 11:56:12AM +0300, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.com> For the btrfs bits Acked-by: David Sterba <dste...@suse.com>

Re: dedicated error codes for the block layer V2

2017-05-29 Thread David Sterba
btrfs bits in patch 13 Acked-by: David Sterba <dste...@suse.com>

Re: [ANNOUNCE] fsperf: a simple fs/block performance testing framework

2017-10-09 Thread David Sterba
On Fri, Oct 06, 2017 at 05:09:57PM -0400, Josef Bacik wrote: > One thing that comes up a lot every LSF is the fact that we have no general > way > that we do performance testing. Every fs developer has a set of scripts or > things that they run with varying degrees of consistency, but nothing

Re: [PATCH 00/13] convert block layer to bioset_init()/mempool_init()

2018-05-21 Thread David Sterba
On Mon, May 21, 2018 at 08:19:58AM -0600, Jens Axboe wrote: > On 5/21/18 8:03 AM, Mike Snitzer wrote: > > On Sun, May 20 2018 at 6:25pm -0400, > > Kent Overstreet wrote: > > > >> Jens - this series does the rest of the conversions that Christoph wanted, > >> and > >>

Re: [PATCH V5 10/33] btrfs: use segment_last_page to get bio's last page

2018-05-24 Thread David Sterba
On Thu, May 24, 2018 at 05:01:15PM +0800, Ming Lei wrote: > Preparing for supporting multipage bvec. Could you please also CC the cover letter so we have a chance to learn what multipage bvec means or what are the changes between the iterations? I found it in the archives, but a copy to

Re: [PATCH 2/2] loop: use interruptible lock in ioctls

2018-03-28 Thread David Sterba
On Mon, Mar 26, 2018 at 05:04:21PM -0700, Matthew Wilcox wrote: > On Mon, Mar 26, 2018 at 04:16:26PM -0700, Omar Sandoval wrote: > > Even after the previous patch to drop lo_ctl_mutex while calling > > vfs_getattr(), there are other cases where we can end up sleeping for a > > long time while