Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI

2018-05-23 Thread Jens Axboe
On 5/23/18 2:52 PM, Kees Cook wrote: > On Wed, May 23, 2018 at 7:31 AM, Jens Axboe wrote: >> On 5/23/18 8:25 AM, Christoph Hellwig wrote: >>> On Wed, May 23, 2018 at 08:13:56AM -0600, Jens Axboe wrote: >>>>> Should I move to code to a new drivers/scsi/scsi_sense.c

Re: [PATCH 3/6] block: Create scsi_sense.h for SCSI and ATAPI

2018-05-23 Thread Jens Axboe
On 5/23/18 3:20 PM, Randy Dunlap wrote: > On 05/23/2018 02:14 PM, Jens Axboe wrote: >> On 5/23/18 2:52 PM, Kees Cook wrote: >>> On Wed, May 23, 2018 at 7:31 AM, Jens Axboe wrote: >>>> On 5/23/18 8:25 AM, Christoph Hellwig wrote: >>>>> On Wed, May 2

Re: [PATCH] block drivers/block: Use octal not symbolic permissions

2018-05-23 Thread Jens Axboe
on via: > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace > > Miscellanea: > > o Wrapped modified multi-line calls to a single line where appropriate > o Realign modified multi-line calls to open parenthesis Honestly, I see this as pretty needless churn. -- Jens Axboe

Re: [PATCH] nbd: set discard granularity properly

2018-05-23 Thread Jens Axboe
Applied, thanks. -- Jens Axboe

Re: [PATCH V2] blk-mq: avoid to starve tag allocation after allocation process migrates

2018-05-23 Thread Jens Axboe
On 5/23/18 4:09 PM, Ming Lei wrote: > On Thu, May 24, 2018 at 1:48 AM, Omar Sandoval wrote: >> On Wed, May 23, 2018 at 05:32:31PM +0800, Ming Lei wrote: >>> On Tue, May 22, 2018 at 09:59:17PM -0600, Jens Axboe wrote: >>>> On 5/19/18 1:44 AM, Ming Lei wrote: >&g

Re: [PATCH] block drivers/block: Use octal not symbolic permissions

2018-05-24 Thread Jens Axboe
On 5/23/18 4:35 PM, Joe Perches wrote: > On Wed, 2018-05-23 at 15:27 -0600, Jens Axboe wrote: >> On 5/23/18 2:05 PM, Joe Perches wrote: >>> Convert the S_ symbolic permissions to their octal equivalents as >>> using octal and not symbolic permissions is preferred b

[GIT PULL] Two block related fixes for 4.17-rc

2018-05-24 Thread Jens Axboe
): loop: clear wb_err in bd_inode when detaching backing file Jens Axboe (1): sr: pass down correctly sized SCSI sense buffer drivers/block/loop.c| 1 + drivers/scsi/sr_ioctl.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) -- Jens Axboe

Re: [PATCH V4] blk-mq: avoid to starve tag allocation after allocation process migrates

2018-05-24 Thread Jens Axboe
longer explanation you gave would be nice to have in the commit > message, but maybe Jens can add that when he applies it. Exactly, I had planned on augmenting the commit message since I don't think the above really explains it. I'll do that and get it applied. -- Jens Axboe

Re: [PATCH] block drivers/block: Use octal not symbolic permissions

2018-05-24 Thread Jens Axboe
On 5/24/18 7:01 AM, Joe Perches wrote: > On Thu, 2018-05-24 at 06:47 -0600, Jens Axboe wrote: >> On 5/23/18 4:35 PM, Joe Perches wrote: >>> On Wed, 2018-05-23 at 15:27 -0600, Jens Axboe wrote: >>>> On 5/23/18 2:05 PM, Joe Perches wrote: >>>>> Conve

Re: [PATCH] Block: null_blk: add blocking description and remove lightnvm

2018-05-25 Thread Jens Axboe
On 5/25/18 8:40 AM, Liu Bo wrote: > - The description of 'blocking' is missing in null_blk.txt > > - The 'lightnvm' parameter has been removed in null_blk.c > > This updates both in null_blk.txt. Thanks, applied. -- Jens Axboe

Re: [RESEND PATCH V5 00/33] block: support multipage bvec

2018-05-25 Thread Jens Axboe
#x27;t received much review yet. So as far as I'm concerned, we can kick off the 4.19 block branch with iterated versions of this patchset. -- Jens Axboe

Re: [PATCH 0/2][RFC] block: default to deadline for SMR devices

2018-05-25 Thread Jens Axboe
a few years ago I finally managed to kill drivers changing the scheduler manually. Why can't this go into a udev (or similar) rule? That's where it belongs, imho. -- Jens Axboe

Re: [PATCH 0/2][RFC] block: default to deadline for SMR devices

2018-05-25 Thread Jens Axboe
On 5/25/18 4:18 PM, Jeff Moyer wrote: > Hi, Jens, > > Jens Axboe writes: > >> On 5/25/18 3:14 PM, Jeff Moyer wrote: >>> Bryan Gurney reported I/O errors when using dm-zoned with a host-managed >>> SMR device. It turns out he was using CFQ, which is the def

Re: [RESEND PATCH V5 00/33] block: support multipage bvec

2018-05-27 Thread Jens Axboe
On 5/27/18 1:23 AM, Ming Lei wrote: > On Fri, May 25, 2018 at 10:30:46AM -0600, Jens Axboe wrote: >> On 5/24/18 10:53 PM, Kent Overstreet wrote: >>> On Fri, May 25, 2018 at 11:45:48AM +0800, Ming Lei wrote: >>>> Hi, >>>> >>>> This patchset

Re: [PATCH] block: Add block level changes for inline encryption

2018-05-28 Thread Jens Axboe
scrutinized heavily and need strong justification. 2) Without an actual use case, any change is always denied. This is just a stand-alone patch. On top of that, you have it inside BLK_CGROUP, which is probably not what you want. -- Jens Axboe

Re: [PATCH v2 0/4] bcache patches for 4.18

2018-05-28 Thread Jens Axboe
mprovement > series. > > There are still some patches waiting for peer review. Once they get > reviewed and it is still in good timing, I will submit them in next waves. Applied, thanks Coly. -- Jens Axboe

Re: check_disk_size_change tidyups

2018-05-29 Thread Jens Axboe
On 5/29/18 8:42 AM, Christoph Hellwig wrote: > Remove the unused export, and suppress the size change message when the > device went away. Applied, thanks. -- Jens Axboe

Re: [GIT PULL] nvme one-liner fix for 4.17

2018-05-29 Thread Jens Axboe
ta LBA supported setting (2018-05-29 20:29:16 +0200) > > > Max Gurtovoy (1): > nvme: fix extended data LBA supported setting Pulled, thanks. -- Jens Axboe

Re: [GIT PULL] nvme updates for 4.18

2018-05-29 Thread Jens Axboe
ked namespaces in the NVMe target > from Chaitanya, in addition to that we mostly small fixes from all the > usual suspects. Pulled, thanks. -- Jens Axboe

Re: [PATCH 0/2][RFC] block: default to deadline for SMR devices

2018-05-30 Thread Jens Axboe
karounds is just silly. They work just fine for probing and reading purposes. There's absolutely no reason why we can't handle these special snowflakes with a udev rule. -- Jens Axboe

Re: [PATCH 0/2][RFC] block: default to deadline for SMR devices

2018-05-30 Thread Jens Axboe
On 5/30/18 9:06 AM, Jeff Moyer wrote: > Hi, Jens, > > Jens Axboe writes: > >> On 5/30/18 2:49 AM, Christoph Hellwig wrote: >>> While I really don't want drivers to change the I/O schedule themselves >>> we have a class of devices (zoned) that don'

Re: [PATCH] nbd: clear DISCONNECT_REQUESTED flag once disconnection occurs.

2018-05-30 Thread Jens Axboe
t; - wake_up(&config->conn_wait); > + wake_up_all(&config->conn_wait); > return 0; > } > sockfd_put(sock); Unless you're using exclusive waits, and you are not, then wake_up() is equivalent to wake_up_all(). -- Jens Axboe

Re: [PATCH 0/2][RFC] block: default to deadline for SMR devices

2018-05-30 Thread Jens Axboe
On 5/30/18 9:45 AM, Jeff Moyer wrote: > Jens Axboe writes: > >> On 5/30/18 9:06 AM, Jeff Moyer wrote: >>> Hi, Jens, >>> >>> Jens Axboe writes: >>> >>>> On 5/30/18 2:49 AM, Christoph Hellwig wrote: >>>>> While I real

Re: [PATCH RESEND] blk-throttle: fix potential NULL pointer dereference in throtl_select_dispatch

2018-05-30 Thread Jens Axboe
On 5/29/18 2:29 AM, Liu Bo wrote: > tg in throtl_select_dispatch is used first and then do check. Since tg > may be NULL, it has potential NULL pointer dereference risk. So fix > it. Applied, thanks. -- Jens Axboe

Re: [PATCH] nbd: clear DISCONNECT_REQUESTED flag once disconnection occurs.

2018-05-30 Thread Jens Axboe
earing the DISCONNECT_REQUESTED flag (and setting the > DISCONNECTED flag) once all connections are closed. Applied, thanks Kevin. -- Jens Axboe

Re: [PATCH] blk-mq: only iterate over inflight requests in blk_mq_tagset_busy_iter

2018-05-30 Thread Jens Axboe
On 5/30/18 10:51 AM, Christoph Hellwig wrote: > We already check for started commands in all callbacks, but we should > also protect against already completed commands. Do this by taking > the checks to common code. Looks good, applied. -- Jens Axboe

Re: [PATCH] blk-throttle: return proper bool type to caller instead of 0/1

2018-05-30 Thread Jens Axboe
On 5/29/18 4:32 AM, Chengguang Xu wrote: > Change to return true/false only for bool type return code. Looks good, applied. -- Jens Axboe

[GIT PULL] Single fix for 4.17 final

2018-05-30 Thread Jens Axboe
Hi Linus, Just a single fix that should make it into this release, fixing a regression with T10-DIF on NVMe. Please pull! git://git.kernel.dk/linux-block.git tags/for-linus-20180530 Jens Axboe (1): Merge branch '

Re: elevator init cleanups

2018-05-31 Thread Jens Axboe
e a bit more controversial. 1-5 are obviously fine, I have no problem taking those. For #6, I see where you are going with this, obviously. I'd like to defer that one a bit, to ensure there aren't any nasty corner cases or issues with it. -- Jens Axboe

Re: [GIT PULL] nvme updates for 4.18

2018-06-01 Thread Jens Axboe
changes since commit 5de815a7eedfacf593817ef34634eaa9b75a1482: > > block: remove parent device reference from struct bsg_class_device > (2018-05-29 13:00:25 -0600) > > are available in the Git repository at: > > git://git.infradead.org/nvme.git nvme-4.18 Pulled, thanks. -- Jens Axboe

Re: [PATCH] blk-mq: update nr_requests when switching to 'none' scheduler

2018-06-02 Thread Jens Axboe
7; when > switching to 'none'. Looks fine, applied. -- Jens Axboe

[GIT PULL] Block changes for 4.18-rc

2018-06-03 Thread Jens Axboe
k for chunk size before allocating it lightnvm: pass flag on graceful teardown to targets lightnvm: pblk: remove dead function lightnvm: pblk: remove unnecessary bio_get/put lightnvm: pblk: take bitmap alloc. out of critical section Jens Axboe (26): nvme: only reconfigure di

Re: [GIT PULL] Block changes for 4.18-rc

2018-06-04 Thread Jens Axboe
On 6/4/18 9:51 AM, Linus Torvalds wrote: > On Sun, Jun 3, 2018 at 5:42 PM Jens Axboe wrote: >> >> drivers/md/md.c | 61 +-- >> drivers/md/md.h | 4 +- > > So I've pulled this, but I get a new war

Re: [GIT PULL] Block changes for 4.18-rc

2018-06-04 Thread Jens Axboe
'd punt the destructin of mddev but destroy biosets >> synchronously. Can't it do sth like the following? > > Yeah, that looks like the right thing to do. > > Jens/Kent? I agree with Tejun, we already discussed this offline. -- Jens Axboe

Re: [blktests PATCHv2] Fix block/011 to not use sysfs for device disabling

2018-06-04 Thread Jens Axboe
On 6/4/18 4:51 PM, Keith Busch wrote: > The PCI sysfs interface may not be a dependable method for toggling the > PCI device state to trigger the timeouts. This patch goes directly to > the config space to make device failure occur. Reviewed-by: Jens Axboe -- Jens Axboe

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
ssing the Signed-off-by. -- Jens Axboe

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
On 6/5/18 8:30 AM, Josef Bacik wrote: > On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote: >> On 6/4/18 10:40 AM, kvi...@gmail.com wrote: >>> From: Kevin Vigor >>> >>> Existing dev_dbg messages sometimes identify request using request >>> p

[GIT PULL] Block fixes for 4.18-rc

2018-06-05 Thread Jens Axboe
-v2.c | 2 +- drivers/md/dm-io.c| 2 +- drivers/md/dm-kcopyd.c| 2 +- drivers/md/dm-region-hash.c | 2 +- drivers/md/dm-snap.c | 2 +- drivers/md/dm-thin.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) -- Jens Axboe

Re: [PATCH -v2] loop: add recursion validation to LOOP_CHANGE_FD

2018-06-05 Thread Jens Axboe
up to Linus through the block tree, I believe. I'll queue it up, thanks Ted. -- Jens Axboe

Re: [PATCH -next] lightnvm: pblk: make symbol write_buffer_size static

2018-06-05 Thread Jens Axboe
On 6/5/18 3:15 AM, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/lightnvm/pblk-init.c:23:14: warning: > symbol 'write_buffer_size' was not declared. Should it be static? Added, thanks. -- Jens Axboe

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
h the SOB added. -- Jens Axboe

Re: [PATCH] nbd: set discard_alignment to the granularity

2018-06-05 Thread Jens Axboe
ty. Just set our alignment to our > blocksize to make sure discards will actually work properly with 4k > drives. Applied, thanks. -- Jens Axboe

Re: [PATCH] block: always set partition number to '0' in blk_partition_remap()

2018-06-06 Thread Jens Axboe
t;bi_iter.bi_sector += p->start_sect; - bio->bi_partno = 0; trace_block_bio_remap(bio->bi_disk->queue, bio, part_devt(p), bio->bi_iter.bi_sector - p->start_sect); } + bio->bi_partno = 0; ret = 0; out: rcu_read_unlock(); -- Jens Axboe

Re: [PATCH] block: pass failfast and driver-specific flags to flush requests

2018-06-06 Thread Jens Axboe
On 6/6/18 8:21 AM, Hannes Reinecke wrote: > If flush requests are being sent to the device we need to inherit the > failfast and driver-specific flags, too, otherwise I/O will fail. Looks good to me. -- Jens Axboe

Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests

2018-06-06 Thread Jens Axboe
ARE_DEVS not assigned, all md tests will be skipped. > > While I'm very much in support for the idea, please be aware that md > has an own test suite by itself and please Cc the md mailing list as > well. Hopefully this can be the start of migrating over those tests! -- Jens Axboe

Re: [GIT PULL] Block changes for 4.18-rc

2018-06-06 Thread Jens Axboe
and test my > version, which deletes more code :) > > I've already gone to the trouble of coming up with a VM smoketest, so I can > test > yours too... I don't really have a strong opinion on which patch should go in. Kent, care to submit a proper version? We should get this in. -- Jens Axboe

Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()

2018-06-07 Thread Jens Axboe
es blk_partition_remap() will be called on each level. > If (as is the case for native nvme multipathing) one of the lower-level > devices do _not_support partitioning a spurious I/O error is generated. That's better, applied. -- Jens Axboe

Re: [PATCH blktests 1/9] blktests: add hepler functions for new md tests

2018-06-07 Thread Jens Axboe
ice space is our > long term goal. Fully agree. And don't feel bad about not knowing there's an md test suite, I didn't either. Which is one of the reasons why having everything under the blktests umbrella is so important. -- Jens Axboe

[PATCH 0/2] Fix bio_set copy

2018-06-07 Thread Jens Axboe
After a recent change, dm ends up doing a straight copy of a bio_set. This breaks for various items in that bio_set, most notably lists. Provide a proper helper for it, and use it. -- Jens Axboe

[PATCH 2/2] dm: use bioset_init_from_src() to copy bio_set

2018-06-07 Thread Jens Axboe
We can't just copy and clear a bio_set, use the bio helper to setup a new bio_set with the settings from another one. Fixes: 6f1c819c219f ("dm: convert to bioset_init()/mempool_init()") Signed-off-by: Jens Axboe --- drivers/md/dm.c | 22 -- 1 file changed

[PATCH 1/2] block: add bioset_init_from_src() helper

2018-06-07 Thread Jens Axboe
Add a helper that allows a caller to initialize a new bio_set, using the settings from an existing bio_set. Signed-off-by: Jens Axboe --- block/bio.c | 18 ++ include/linux/bio.h | 1 + 2 files changed, 19 insertions(+) diff --git a/block/bio.c b/block/bio.c index

Re: [GIT PULL] nvme fixes for 4.18

2018-06-08 Thread Jens Axboe
27;t want to pull that. I can either apply the patches (trivial), or you can rebase. I'm fine with either. -- Jens Axboe

Re: [PATCH] Signed-off-by: Kitone ELvis Peter

2018-06-08 Thread Jens Axboe
g this up. The subject line is in the message body, the subject line contains your signed-off-by. Please take a look at your email and reason about how to fix this up before trying again. -- Jens Axboe

Re: [PATCH] Signed-off-by: Kitone Elvis Peter

2018-06-08 Thread Jens Axboe
out before you have. And never send out patches that you haven't even compiled. -- Jens Axboe

Re: [PATCH 0/2] Fix bio_set copy

2018-06-08 Thread Jens Axboe
On 6/8/18 12:12 AM, Li Wang wrote: > Jens Axboe mailto:ax...@kernel.dk>> wrote: > > After a recent change, dm ends up doing a straight copy of a > bio_set. This breaks for various items in that bio_set, > most notably lists. Provide a proper helper for it, and

Re: [GIT PULL] nvme fixes for 4.18

2018-06-08 Thread Jens Axboe
On 6/8/18 7:09 AM, Jens Axboe wrote: > On 6/7/18 11:58 PM, Christoph Hellwig wrote: >> Hi Jens, >> >> a few more small fixes for NVMe for this merge window: >> >> The following changes since commit af6c5d5e01ad9f2c9ca38cccaae6b5d67ddd241f: >>

[GIT PULL] Block fixes for 4.18-rc

2018-06-08 Thread Jens Axboe
uests block: always set partition number to '0' in blk_partition_remap() Jens Axboe (2): block: add bioset_init_from_src() helper dm: use bioset_init_from_src() to copy bio_set Johannes Thumshirn (1): nvme: don't hold nvmf_transports_rwsem for more than transport loo

[GIT PULL] Block flush handling fix

2018-06-10 Thread Jens Axboe
Jens Axboe (1): block: fix use-after-free in block flush handling block/blk-flush.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- Jens Axboe

Re: [PATCH 1/1] blk-mq: reinit q->tag_set_list entry only after grace period

2018-06-11 Thread Jens Axboe
is in blk_mq_sched_restart() and loops over all queues in >tag list in order to find hctx to restart. > > Because linked list entry was modified in blk_mq_del_queue_tag_set() > without proper waiting for a grace period, blk_mq_sched_restart() > never ends, spining in list_for_each_entry_rcu_rr(), thus soft lockup. > > Fix is simple: reinit list entry after an RCU grace period elapsed. Good catch, applied. -- Jens Axboe

Re: [PATCH] blkdev_report_zones_ioctl(): Use vmalloc() to allocate large buffers

2018-06-13 Thread Jens Axboe
On 6/13/18 9:20 AM, Bart Van Assche wrote: > On 05/22/18 10:58, Jens Axboe wrote: >> On 5/22/18 9:27 AM, Bart Van Assche wrote: >>> Avoid that complaints similar to the following appear in the kernel log >>> if the number of zones is sufficiently large: >>>

Re: remove nvme_reinit_tagset and blk_mq_tagset_iter

2018-06-14 Thread Jens Axboe
up, presumable because the nvme-fc change isn't upstream yet? That's fine with me, you can add my reviewed-by to the patches. -- Jens Axboe

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Jens Axboe
static int rd_numa_node = NUMA_NO_NODE; > +module_param(rd_numa_node, int, 0444); > +MODULE_PARM_DESC(rd_numa_node, "NUMA node number to allocate RAM disk on."); This could feasibly be 0644, as there would be nothing wrong with altering this at runtime. -- Jens Axboe

Re: remove nvme_reinit_tagset and blk_mq_tagset_iter

2018-06-14 Thread Jens Axboe
On 6/14/18 8:54 AM, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 08:45:07AM -0600, Jens Axboe wrote: >> On 6/14/18 6:30 AM, Christoph Hellwig wrote: >>> Now that nvme-fc moved off the reinit request concept both the core nvme >>> and blk-mq code for it becomes un

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Jens Axboe
On 6/14/18 9:29 AM, Hannes Reinecke wrote: > On Thu, 14 Jun 2018 08:47:33 -0600 > Jens Axboe wrote: > >> On 6/14/18 7:38 AM, Hannes Reinecke wrote: >>> For performance reasons we should be able to allocate all memory >>> from a given NUMA node, s

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Jens Axboe
On 6/14/18 2:32 PM, Adam Manzanares wrote: > > > On 6/14/18 9:09 AM, Hannes Reinecke wrote: >> On Thu, 14 Jun 2018 09:33:35 -0600 >> Jens Axboe wrote: >> >>> On 6/14/18 9:29 AM, Hannes Reinecke wrote: >>>> On Thu, 14 Jun 2018 08:47:33 -0600 >&g

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-14 Thread Jens Axboe
On 6/14/18 2:41 PM, Adam Manzanares wrote: > > > On 6/14/18 1:37 PM, Jens Axboe wrote: >> On 6/14/18 2:32 PM, Adam Manzanares wrote: >>> >>> >>> On 6/14/18 9:09 AM, Hannes Reinecke wrote: >>>> On Thu, 14 Jun 2018 09:33:35 -0600 >>

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-15 Thread Jens Axboe
On 6/15/18 1:30 AM, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 09:33:35AM -0600, Jens Axboe wrote: >> Next question - what does the memory allocator do if we run out of >> memory on the given node? Should we punt to a different node if that >> happens? Slower,

Re: [PATCH] block: remov blk_queue_invalidate_tags

2018-06-15 Thread Jens Axboe
On 6/15/18 5:55 AM, Christoph Hellwig wrote: > This function is entirely unused, so remove it and the tag_queue_busy > member of struct request_queue. Applied, thanks. -- Jens Axboe

Re: [GIT PULL] nvme fixes for 4.18

2018-06-15 Thread Jens Axboe
ddition from Hannes. Pulled, thanks. -- Jens Axboe

Re: [PATCH] brd: Allow ramdisk to be allocated on selected NUMA node

2018-06-15 Thread Jens Axboe
On 6/15/18 3:23 AM, Mel Gorman wrote: > On Thu, Jun 14, 2018 at 02:47:39PM -0600, Jens Axboe wrote: >>>>> Will numactl ... modprobe brd ... solve this problem? >>>> >>>> It won't, pages are allocated as needed. >>>> >>> >>&g

[GIT PULL] Block fixes for 4.18-rc1

2018-06-16 Thread Jens Axboe
ue data on reconnect Jens Axboe (1): Merge branch 'nvme-4.18' of git://git.infradead.org/nvme into for-linus Max Gurtovoy (1): nvme-rdma: fix error flow during mapping request data Roman Pen (1): blk-mq: reinit q->tag_set_list entry only after grace period Documentation/

Re: [PATCH 0/5] Five small zoned block device patches

2018-06-16 Thread Jens Axboe
On 6/15/18 3:55 PM, Bart Van Assche wrote: > Hello Jens, > > In this patch series there are five patches with small improvements for the > zoned block device code. Please consider these patches for the upstream > kernel. Looks fine to me. Are you thinking 4.18 or 4.19? -- Jens Axboe

Re: [PATCH 0/5] Five small zoned block device patches

2018-06-16 Thread Jens Axboe
On 6/16/18 2:58 PM, Bart Van Assche wrote: > On Sat, 2018-06-16 at 12:27 -0600, Jens Axboe wrote: >> On 6/15/18 3:55 PM, Bart Van Assche wrote: >>> Hello Jens, >>> >>> In this patch series there are five patches with small improvements for the >>> z

Re: [PATCH] block: fix timeout changes for legacy request drivers

2018-06-19 Thread Jens Axboe
uest instead to reinstance the previous behavior. > For that __blk_complete_request needs to be exported. Yikes. Looks like blktests only smoke tests blk-mq timeout handling, we should add a test to do the same for !mq. -- Jens Axboe

Re: [PATCH v2] Revert "block: Add warning for bi_next not NULL in bio_endio()"

2018-06-19 Thread Jens Axboe
it 0ba99ca4838b clears that field before > end_clone_bio() has had a chance to inspect that field. Hence revert > commit 0ba99ca4838b. Applied, thanks Bart. -- Jens Axboe

Re: [PATCH v2] Revert "block: Add warning for bi_next not NULL in bio_endio()"

2018-06-19 Thread Jens Axboe
e srp-test software to the blktests framework. That's awesome, would be a great addition! -- Jens Axboe

Re: [PATCH] blk-mq-debugfs: Off by one in blk_mq_rq_state_name()

2018-06-20 Thread Jens Axboe
On 6/20/18 4:45 AM, Dan Carpenter wrote: > If rq_state == ARRAY_SIZE() then we read one element beyond the end of > the blk_mq_rq_state_name_array[] array. Applied, thanks Dan. -- Jens Axboe

Re: [PATCH] block: sed-opal: Fix a couple off by one bugs

2018-06-20 Thread Jens Axboe
On 6/20/18 4:41 AM, Dan Carpenter wrote: > resp->num is the number of tokens in resp->tok[]. It gets set in > response_parse(). So if n == resp->num then we're reading beyond the > end of the data. Applied, thanks Dan. -- Jens Axboe

Re: [PATCH] nbd: Add the nbd NBD_DISCONNECT_ON_CLOSE config flag.

2018-06-20 Thread Jens Axboe
. Applied, thanks. -- Jens Axboe

Re: [GIT PULL] nvme fixes for 4.18

2018-06-22 Thread Jens Axboe
avoid high order allocations > (2018-06-21 18:59:46 +0200) > > > Israel Rukshin (1): > nvme-rdma: Fix command completion race at error recovery > > James Smart (1): > nvme-fc: release io queu

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-22 Thread Jens Axboe
g a new mutex. That >>> way we also no longer need synchronization using WB_shutting_down as the >>> mutex provides it for CONFIG_CGROUP_WRITEBACK case and without >>> CONFIG_CGROUP_WRITEBACK wb_shutdown() can be called only once from >>> bdi_unregister(). >>> >>> Reported-by: syzbot >>> Signed-off-by: Jan Kara >> >> Acked-by: Tejun Heo > > OK, Jens, can you please pick up the fix? Thanks! Applied, thanks! -- Jens Axboe

Re: [RESEND PATCH] lightnvm: pblk: add asynchronous partial read

2018-06-22 Thread Jens Axboe
It can't, not if __GFP_WAIT is set like it is for GFP_KERNEL. -- Jens Axboe

[PATCH] blk-wbt: fix indefinite background writeback sleep

2018-06-22 Thread Jens Axboe
the waitqueue. Fix this so that we only utilize the tail add for the initial sleep, and we don't factor in the wait queue placement after we've slept (and are now using the head addition). Fixes: e34cbd307477 ("blk-wbt: add general throttling mechanism") Signed-off-by: Jens

Re: [PATCH] blk-mq: Fix timeout handling in case the timeout handler returns BLK_EH_DONE

2018-06-22 Thread Jens Axboe
ensure that we're good for 4.18. -- Jens Axboe

Re: [PATCH] blk-wbt: fix indefinite background writeback sleep

2018-06-22 Thread Jens Axboe
On 6/22/18 4:43 PM, Ming Lei wrote: > On Fri, Jun 22, 2018 at 01:26:10PM -0600, Jens Axboe wrote: >> blk-wbt adds waiters to the tail of the waitqueue, and factors in the >> task placement in its decision making on whether or not the current task >> can proceed. This can

Re: [PATCH] blk-wbt: fix indefinite background writeback sleep

2018-06-22 Thread Jens Axboe
On 6/22/18 5:11 PM, Ming Lei wrote: > On Fri, Jun 22, 2018 at 04:51:26PM -0600, Jens Axboe wrote: >> On 6/22/18 4:43 PM, Ming Lei wrote: >>> On Fri, Jun 22, 2018 at 01:26:10PM -0600, Jens Axboe wrote: >>>> blk-wbt adds waiters to the tail of the waitqueue, and factors

Re: [PATCH] blk-wbt: fix indefinite background writeback sleep

2018-06-23 Thread Jens Axboe
On 6/22/18 7:37 PM, Ming Lei wrote: > On Fri, Jun 22, 2018 at 05:13:31PM -0600, Jens Axboe wrote: >> On 6/22/18 5:11 PM, Ming Lei wrote: >>> On Fri, Jun 22, 2018 at 04:51:26PM -0600, Jens Axboe wrote: >>>> On 6/22/18 4:43 PM, Ming Lei wrote: >>>>> O

[GIT PULL] Block fixes for 4.18-rc2

2018-06-23 Thread Jens Axboe
another oops in wb_workfn() Jens Axboe (2): nvme-pci: limit max IO size and segments to avoid high order allocations Merge branch 'nvme-4.18' of git://git.infradead.org/nvme into for-linus Jianchao Wang (1): nvme-pci: move nvme_kill_queues to nvme_remove_dead_ctrl Max

Re: [PATCH] block: Fix transfer when chuck sectors exceeds max

2018-06-26 Thread Jens Axboe
On 6/26/18 9:14 AM, Keith Busch wrote: > A device may have boundary restrictions where the number of sectors > between boundaries exceeds its max transfer size. In this case, we need > to cap the max size to the smaller of the two limits. Applied, with the subject typo fixed. -- Jens Axboe

[PATCH] blk-mq: don't queue more if we get a busy return

2018-06-28 Thread Jens Axboe
long as possible, if we get a BUSY due to the regular out-of-tags condition. Signed-off-by: Jens Axboe diff --git a/block/blk-mq.c b/block/blk-mq.c index b6888ff556cf..d394cdd8d8c6 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1075,6 +1075,9 @@ static bool blk_mq_mark_tag_wait(struct

Re: [PATCH] block: Fix cloning of requests with a special payload

2018-06-28 Thread Jens Axboe
t; smp_call_function_single_interrupt+0x90/0x330 > call_function_single_interrupt+0xf/0x20 > Thanks Bart, applied for 4.18. -- Jens Axboe

Re: [PATCH] block: Make __bio_clone_fast() copy bi_vcnt

2018-06-28 Thread Jens Axboe
ts. Applied - it's correct for the current base. -- Jens Axboe

Re: [PATCH v2] blk-mq: Fix a race condition in blk_mq_mark_tag_wait()

2018-06-28 Thread Jens Axboe
ease see the following patch: >> >> https://marc.info/?l=linux-block&m=152998658713265&w=2 >> >> Then we can avoid to disable irq when acquiring hctx->lock. > > I think it's more a matter of taste than a technical decision to choose > which patch goes upstream. I do think the split lock is cleaner in this case, since it avoids making hctx->lock irq disabling. -- Jens Axboe

Re: [PATCH 1/3] blk-mq: use list_splice_tail() to insert requests

2018-06-28 Thread Jens Axboe
x27;t think it is, since we can be tracing through a variety of different ways. I think it's best to leave this as-is. If this were to be changed, it'd have to be a separate patch anyway, it should not be mixed up with this change. It does need the list_splice_tail_init() as others found out, or you'll leave the source list corrupted. -- Jens Axboe

Re: [PATCH 1/3] blk-mq: use list_splice_tail() to insert requests

2018-06-28 Thread Jens Axboe
gt; __blk_mq_insert_req_list(hctx, rq, false); > trace_block_rq_insert(hctx->queue, rq); > } > } > > This will only call the loop if the trace event "block_rq_insert" has > been activated. It also uses the jump label infrastructure, so that if > statement is a non-conditional branch (static_key_false()). This works for both ftrace and blktrace? -- Jens Axboe

Re: [PATCH] block: Make __bio_clone_fast() copy bi_vcnt

2018-06-28 Thread Jens Axboe
and we should >> take a close look. > > not just cloned bios, any code using bi_vcnt on a bio it didn't create is > wrong. > > so big nack to this patch (I wasn't ccd on it though and it doesn't seem to > have > hit lkml, so I can't find the original patch...) Yeah, you are both right, I was smoking crack. -- Jens Axboe

Re: [PATCH] blk-mq: don't queue more if we get a busy return

2018-06-28 Thread Jens Axboe
On 6/28/18 7:59 PM, Ming Lei wrote: > On Thu, Jun 28, 2018 at 09:46:50AM -0600, Jens Axboe wrote: >> Some devices have different queue limits depending on the type of IO. A >> classic case is SATA NCQ, where some commands can queue, but others >> cannot. If we have NCQ

Re: [PATCH] drbd: Fix drbd_request_prepare() discard handling

2018-06-29 Thread Jens Axboe
On 6/25/18 4:51 PM, Bart Van Assche wrote: > Fix the test that verifies whether bio_op(bio) represents a discard > or write zeroes operation. Compile-tested only. Applied, thanks Bart. -- Jens Axboe

Re: [GIT PULL] nvme fix for 4.18

2018-06-29 Thread Jens Axboe
--- > Sagi Grimberg (1): > nvme-rdma: fix possible double free of controller async event buffer > > drivers/nvme/host/rdma.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Pulled, thanks. -- Jens Axboe

Re: [PATCH] drbd: Do not redefine __must_hold()

2018-06-29 Thread Jens Axboe
On 6/25/18 4:51 PM, Bart Van Assche wrote: > Since __must_hold() is defined in , do not > redefine it in DRBD. Compile-tested only. Applied for 4.19, thanks. -- Jens Axboe

<    1   2   3   4   5   6   7   8   9   10   >