dispatch_from;
unsigned intbusy;
unsigned intnr_ctx;
struct blk_mq_ctx **ctxs;
to eliminate a hole, instead of adding one more.
--
Jens Axboe
On 6/28/18 7:56 PM, Liu Bo wrote:
> Since @blk_debugfs_root couldn't be configured dynamically, we can
> save a few memory allocation if it's not there.
Applied for 4.19, thanks.
--
Jens Axboe
On 6/28/18 7:56 PM, Liu Bo wrote:
> Once one cgroup has io.low configured, @low_valid becomes true and other
> cgroups won't switch it back whatsoever.
Applied for 4.19, thanks.
--
Jens Axboe
/= 2;
> }
Shouldn't we rather ensure that ->bio_cnt_ret_time is initialized to
jiffies?
--
Jens Axboe
On 6/29/18 2:23 PM, Liu Bo wrote:
> On Fri, Jun 29, 2018 at 02:00:01PM -0600, Jens Axboe wrote:
>> On 6/20/18 9:07 PM, Liu Bo wrote:
>>> When a new tg is created, tg->bio_cnt_ret_time is 0, so if the first
>>> IO going thru this tg turns out to be a bad one,
On 6/29/18 2:43 PM, Liu Bo wrote:
> On Fri, Jun 29, 2018 at 02:26:07PM -0600, Jens Axboe wrote:
>> On 6/29/18 2:23 PM, Liu Bo wrote:
>>> On Fri, Jun 29, 2018 at 02:00:01PM -0600, Jens Axboe wrote:
>>>> On 6/20/18 9:07 PM, Liu Bo wrote:
>>>>> When a new
that. That's actually a generic problem, since lots of
drivers need to allocate SG lists. I actually added this debug magic
check back in 2007:
commit d6ec084200c37683278c821338f74ddf21ab80f5
Author: Jens Axboe
Date: Mon Oct 22 20:01:06 2007 +0200
Add CONFIG_DEBUG_SG sg validation
when
gt;mq_map to make it clear.
I'm fine with this change, but the declaration should go into
block/blk-mq.h, it's not a driver API.
--
Jens Axboe
gt;mq_map to make it clear.
Applied for 4.19, thanks.
--
Jens Axboe
On 6/30/18 7:12 AM, Minwoo Im wrote:
> Fix typo in a function blk_mq_alloc_tag_set() comment.
> if if it too large -> if it's too large.
Applied, thanks.
--
Jens Axboe
ristophs comments on
making the weight and factor in caps.
Applying 1-2/3 so far.
--
Jens Axboe
On Jul 2, 2018, at 7:23 PM, Ming Lei wrote:
>
>> On Mon, Jul 02, 2018 at 11:30:17AM -0600, Jens Axboe wrote:
>>> On 7/2/18 3:36 AM, Ming Lei wrote:
>>> It won't be efficient to dequeue request one by one from sw queue,
>>> but we have to do that when q
return;
set_bit(BLK_MQ_S_EWMA, &hctx->state);
}
__blk_mq_update_dispatch_busy(hctx, busy);
}
--
Jens Axboe
On 7/3/18 8:11 AM, Ming Lei wrote:
> On Tue, Jul 03, 2018 at 08:03:23AM -0600, Jens Axboe wrote:
>> On 7/3/18 2:34 AM, Ming Lei wrote:
>>> It won't be efficient to dequeue request one by one from sw queue,
>>> but we have to do that when queue is busy for better
On 7/3/18 8:34 AM, Ming Lei wrote:
> On Tue, Jul 03, 2018 at 08:13:45AM -0600, Jens Axboe wrote:
>> On 7/3/18 8:11 AM, Ming Lei wrote:
>>> On Tue, Jul 03, 2018 at 08:03:23AM -0600, Jens Axboe wrote:
>>>> On 7/3/18 2:34 AM, Ming Lei wrote:
>>>>> It won
y, then only dequeue request one by one from sw queue
> when queue is busy.
Applied, thanks.
--
Jens Axboe
flexible, this
> removes the flag NULLB_DEV_FL_CONFIGURED so that mbps knob can be reset
> when power knob is off, e.g.
>
> echo 0 > /config/nullb/a/power
> echo 40 > /config/nullb/a/mbps
> echo 1 > /config/nullb/a/power
>
> So does other knobs under /config/nullb/a.
Applied for 4.19, thanks.
--
Jens Axboe
Green (1):
loop: Add LOOP_SET_BLOCK_SIZE in compat ioctl
Lars Ellenberg (1):
drbd: fix access after free
drivers/block/drbd/drbd_worker.c | 2 +-
drivers/block/loop.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
Jens Axboe
On 7/11/18 7:30 AM, Josef Bacik wrote:
> max_depth used to be a u64, but I changed it to a unsigned int but
> didn't convert my comparisons over everywhere. Fix by comparing to
> INT_MAX instead of (u64)-1.
Should that be UINT_MAX?
--
Jens Axboe
On 7/11/18 8:28 AM, Josef Bacik wrote:
> On Wed, Jul 11, 2018 at 08:22:28AM -0600, Jens Axboe wrote:
>> On 7/11/18 7:30 AM, Josef Bacik wrote:
>>> max_depth used to be a u64, but I changed it to a unsigned int but
>>> didn't convert my comparisons over everywhere.
On 7/11/18 8:34 AM, Josef Bacik wrote:
> max_depth used to be a u64, but I changed it to a unsigned int but
> didn't convert my comparisons over everywhere. Fix by using UINT_MAX
> everywhere instead of (u64)-1.
Thanks Josef, applied for 4.19.
--
Jens Axboe
+ nr_pages = iov_iter_npages(iter, BIO_MAX_PAGES);
if (!nr_pages)
return 0;
- if (is_sync_kiocb(iocb) && nr_pages <= BIO_MAX_PAGES)
+ if (is_sync_kiocb(iocb))
return __blkdev_direct_IO_simple(iocb, iter, nr_pages);
- return __blkdev_direct_IO(iocb, iter, min(nr_pages, BIO_MAX_PAGES));
+ return __blkdev_direct_IO(iocb, iter, nr_pages);
}
static __init int blkdev_init(void)
--
Jens Axboe
On 7/12/18 10:14 AM, Hannes Reinecke wrote:
> On 07/12/2018 05:08 PM, Jens Axboe wrote:
>> On 7/12/18 8:36 AM, Hannes Reinecke wrote:
>>> Hi Jens, Christoph,
>>>
>>> we're currently hunting down a silent data corruption occurring due to
>>> commit
On 7/12/18 10:20 AM, Jens Axboe wrote:
> On 7/12/18 10:14 AM, Hannes Reinecke wrote:
>> On 07/12/2018 05:08 PM, Jens Axboe wrote:
>>> On 7/12/18 8:36 AM, Hannes Reinecke wrote:
>>>> Hi Jens, Christoph,
>>>>
>>>> we're currently hunting
.c:660:4: warning: format '%llx' expects argument of
> type 'long long unsigned int', but argument 6 has type 'dma_addr_t {aka
> unsigned int}' [-Wformat=]
Applied, thanks.
--
Jens Axboe
On 7/13/18 10:56 AM, Martin Wilck wrote:
> On Thu, 2018-07-12 at 10:42 -0600, Jens Axboe wrote:
>>
>> Hence the patch I sent is wrong, the code actually looks fine. Which
>> means we're back to trying to figure out what is going on here. It'd
>> be great with
On 7/13/18 12:00 PM, Jens Axboe wrote:
> On 7/13/18 10:56 AM, Martin Wilck wrote:
>> On Thu, 2018-07-12 at 10:42 -0600, Jens Axboe wrote:
>>>
>>> Hence the patch I sent is wrong, the code actually looks fine. Which
>>> means we're back to trying to figu
rect_IO()->bio_alloc_bioset()->bvec_alloc()
>> I found that bvec_alloc() will fail if nr_pages > BIO_MAX_PAGES.
>>
>> So why is there the check for 'nr_pages <= BIO_MAX_PAGES' ?
>> It's not that we can handle it in __blkdev_direct_IO() ...
>>
>> Thanks for any clarification.
>
> Maybe you can try the following patch from Christoph to see if it makes a
> difference:
>
> https://marc.info/?l=linux-kernel&m=153013977816825&w=2
That's not a bad idea.
--
Jens Axboe
t really a path with a lot of corner
cases, so it's really weird that we're seeing anything at all. Which is
why I'm suspecting it's something else entirely, but it's really hard to
guesstimate on that with no clues at all.
> However, we're now much closer than we used to be, so I'm confident
> that we'll be able to present more concrete facts soon.
OK, sounds good.
--
Jens Axboe
80713
Tony Battersby (1):
bsg: fix bogus EINVAL on non-data commands
block/bsg.c | 2 --
1 file changed, 2 deletions(-)
--
Jens Axboe
Hi,
Just a heads-up that I'll be out on vacation next week, won't return
until 7/23. I'll still be checking email and collecting patches, but
responses will definitely be slower than usual, and non-urgent stuff
might be deferred until I'm back.
--
Jens Axboe
stuff will block waiting to mark the socket
> dead, and we could be marked complete and still requeue. Instead add a
> flag to the socket so we know whether we've been requeued yet.
Applied 1-2 for 4.18, thanks.
--
Jens Axboe
y
> code.
Applied 1-2 for 4.19.
--
Jens Axboe
g good performance.
>
> This patch improves IOPS and decreases CPU unilization on megaraid_sas,
> per Kashyap's test.
Looks reasonable to me, applied for 4.19.
--
Jens Axboe
On 7/19/18 7:42 PM, Josef Bacik wrote:
> With the change to use UINT_MAX I broke the depth check as any value of
> inflight (ie 0) would be less than (int)UINT_MAX. Fix this by changing
> everything to unsigned int to match the depth.
Applied, thanks.
--
Jens Axboe
of request issue & dispatch.
Applied, thanks.
--
Jens Axboe
On 7/23/18 3:18 PM, Bart Van Assche wrote:
> Commit ca4b2a011948 ("null_blk: add zone support") breaks several
> blktests scripts because it renamed the null_blk kernel module into
> null_blk_mod. Hence rename null_blk_mod back into null_blk.
Thanks Bart, applied.
--
Jens Axboe
On 7/24/18 5:04 AM, Christoph Hellwig wrote:
> To remove invariants that are odd and in the way of multipage biovecs.
Applied for 4.19, thanks.
--
Jens Axboe
On 7/25/18 12:42 AM, Juergen Gross wrote:
> Remove some macros not used anywhere.
Applied, thanks.
--
Jens Axboe
e)
> - RDMA setup/teardown path fixes and refactor (Sagi Grimberg)
> - Command Supported and Effects log support for the NVMe target
>(Chaitanya Kulkarni)
> - buffered I/O support for the NVMe target (Chaitanya Kulkarni)
>
> plus the usual set of cleanups and small enhancements.
Pulled, thanks.
--
Jens Axboe
mq: issue directly if hw queue isn't busy in case of 'none'.
Can you try my current for-next? This should fix it:
commit 8824f62246bef288173a6624a363352f0d4d3b09
Author: Ming Lei
Date: Sun Jul 22 14:10:15 2018 +0800
blk-mq: fail the request in case issue failure
--
Jens Axboe
---
> Hannes Reinecke (2):
> nvmet: fixup crash on NULL device path
> nvmet: only check for filebacking on -ENOTBLK
>
> James Smart (2):
> nvmet-fc: fix target sgl list on large transfers
> nvme: if_ready checks to fail io to deleting controller
Pulled, thanks.
--
Jens Axboe
could be pinned. This also avoids the need for
> cleanup code in the helper - callers will submit the bio with the
> allocated pages, and clean up later as appropriate.
Thanks everyone involved in this, I've queued it up for 4.18.
--
Jens Axboe
io pages and rely on proper
> handling of max_hw_read_sectors (e.g. older FusionIO cards). For
> that reason it could qualify for stable.
Good catch, this looks correct to me. I'm going to shove this
towards 4.19 and mark it stable, that should give us enough testing
time on it.
--
Jens Axboe
split.
Applied for 4.18, thanks.
--
Jens Axboe
ributes a patch to fix a memory leak in bcache. And
> patches from Tang Junhui are for recoganized performance improvement,
> these patches are posted for monthes and good to me.
>
> Please pick the first wave for 4.19. Thanks in advance.
Applied, thanks Coly.
--
Jens Axboe
On 7/25/18 9:46 AM, Max Gurtovoy wrote:
> Currently this function is implemented in the scsi layer, but it's
> actual place should be the block layer since T10-PI is a general
> data integrity feature that is used in the nvme protocol as well.
Applied 1-3 for 4.19.
--
Jens Axboe
On 7/27/18 9:21 AM, Jens Axboe wrote:
> On 7/25/18 9:46 AM, Max Gurtovoy wrote:
>> Currently this function is implemented in the scsi layer, but it's
>> actual place should be the block layer since T10-PI is a general
>> data integrity feature that is used in
On 7/25/18 12:29 PM, Peter Geis wrote:
> On 07/25/2018 02:17 PM, Jens Axboe wrote:
>> On 7/25/18 10:28 AM, Peter Geis wrote:
>>> Good Afternoon,
>>>
>>> I have encountered an issue on both Tegra 2 and Tegra 3 devices
>>> accessing emmc following the 25
-ENOTBLK
James Smart (2):
nvmet-fc: fix target sgl list on large transfers
nvme: if_ready checks to fail io to deleting controller
Jens Axboe (1):
Merge branch 'nvme-4.18' of git://git.infradead.org/nvme into for-linus
Josef Bacik (2):
nbd: don't requeue t
On 7/27/18 3:14 PM, Josef Bacik wrote:
> We need to check in blkcg_bio_issue_check if the bio is flagged as
> QUEUE_ENTERED, because if it is then we've already accounted for the IO
> in the cgroup stats.
That's a bit of a flag overload, I think that at least warrants a
comment.
--
Jens Axboe
>
> The following IO hang is triggered on dbench test on xfs/usb-storage:
>
> dbench -t 20 -s 64
Josef, the key here is likely a queue depth of 1. So if you're running on
sata, then just limit the device depth to 1.
--
Jens Axboe
hat's what you get when it's unmaintained for years.
Add a:
blk_queue_split(queue, &bio);
to kblock.c:kfio_make_request() and see if that helps.
--
Jens Axboe
On 7/28/18 4:12 PM, Max Gurtovoy wrote:
>
>
> On 7/27/2018 6:38 PM, Jens Axboe wrote:
>> On 7/27/18 9:21 AM, Jens Axboe wrote:
>>> On 7/25/18 9:46 AM, Max Gurtovoy wrote:
>>>> Currently this function is implemented in the scsi layer, but it's
>>>
;ll be another request.
Applied, thanks.
--
Jens Axboe
On 7/29/18 3:15 PM, Max Gurtovoy wrote:
> Currently this function is implemented in the scsi layer, but it's
> actual place should be the block layer since T10-PI is a general
> data integrity feature that is used in the nvme protocol as well.
Applied 1-3, thanks.
--
Jens Axboe
stress
> testing. They've been running on our test boxes internally under stress tests
> and seem to have fixed the remaining issues we were seeing. Thanks,
Applied for 4.19, thanks.
--
Jens Axboe
On 8/1/18 8:38 AM, Hannes Reinecke wrote:
> We need to copy the io priority, too; otherwise the clone will run
> with a different priority than the original one.
Looks good, but please make the patch against the block 4.19 branch.
--
Jens Axboe
x27;echo auto > /sys/block/sdN/device/power/control'.
>
> This patch disables runtime-pm for blk-mq really by pm_runtime_disable()
> and fixes all kinds of PM related kernel crash.
Applied, thanks Ming.
--
Jens Axboe
ad of number of the normal part.
>
> This patch fixes the above two cases, and avoids kernel crash caused
> by wrong resizing sbitmap queue.
Applied, thanks.
--
Jens Axboe
ooks good to me, but would be nice to get Tejun onboard with the percpu
change. We'll need his ack to get this applied.
--
Jens Axboe
://git.kernel.dk/linux-block.git tags/for-linus-20180803
Ming Lei (1):
blk-mq: fix blk_mq_tagset_busy_iter
block/blk-mq-tag.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Jens Axboe
t supported
from mainline. Please keep changes like that in mind, that change should
never have been in the "nvme: add ANA support" patch.
--
Jens Axboe
On 8/5/18 1:33 AM, Christoph Hellwig wrote:
> On Sat, Aug 04, 2018 at 12:39:13PM -0600, Jens Axboe wrote:
>> On 8/4/18 2:43 AM, Christoph Hellwig wrote:
>> This one:
>>
>>> Christoph Hellwig (9):
>>> nvme: add ANA support
>>
On 8/6/18 1:31 AM, Christoph Hellwig wrote:
> On Sun, Aug 05, 2018 at 08:27:22AM -0600, Jens Axboe wrote:
>> Right, the change is fine, it's just fighting a similar change
>> in a different branch. I did fix it up (picked in the original change
>> first), please double
On 8/7/18 5:17 PM, Bart Van Assche wrote:
> Hello Jens,
>
> This patch series suppresses the compiler warnings that are reported when
> building the CFQ I/O scheduler with W=1. Please consider these patches for
> kernel v4.19.
Thanks, applied.
--
Jens Axboe
NFIG_BLK_CGROUP
> + {
> + struct blkcg_gq *blkg;
> +
> + rcu_read_lock();
> + blkg = blkg_lookup(&blkcg_root, q);
> + rcu_read_unlock();
> +
> + WARN(blkg,
> + "request queue %p is being released but it has not yet
> been removed from the blkcg controller\n",
> + q);
> + }
> +#endif
This last hunk should go in the cgroup code.
--
Jens Axboe
On 8/8/18 9:04 AM, Bart Van Assche wrote:
> On Wed, 2018-08-08 at 08:41 -0600, Jens Axboe wrote:
>> On 7/30/18 3:10 PM, Bart Van Assche wrote:
>>> +#ifdef CONFIG_BLK_CGROUP
>>> + {
>>> + struct blkcg_gq *blkg;
>>> +
>>> +
x, rested patches are simple or trivial
> IMHO.
>
> Our new bcache developer Shenghui Wang contributes two patches in
> this run. The first one fixes a misleading error message, and the
> second one is a code style clean up.
>
> Thanks in advance for picking them.
Applied, fixed up a typo in your patch #4.
--
Jens Axboe
ix from Tal Shorer.
Thanks, pulled.
--
Jens Axboe
need to be later freed.
>
> bvec_nr_vecs() was not updated accordingly, and thus returns the wrong
> value. Decrement idx before performing the lookup.
Applied, thanks.
--
Jens Axboe
ciated from the
> cgroup controller. This patch avoids that loading the parport_pc, paride and
> pf drivers trigger a kernel crash. Since this patch series fixes a regression,
> please consider these patches for kernel v4.19.
Thanks, applied for 4.19.
--
Jens Axboe
e limit and the
> elapsed jiffies is suboptimal. As the dispatch delay is only calculated
> once the application's iops is (iops limit + 1), it doesn't need to wait
> any longer than the remaining time of the current slice.
Looks good to me - can you resend against my for-4.19/block branch, as
it doesn't apply.
--
Jens Axboe
e limit and the
> elapsed jiffies is suboptimal. As the dispatch delay is only calculated
> once the application's iops is (iops limit + 1), it doesn't need to wait
> any longer than the remaining time of the current slice.
Applied, thanks.
--
Jens Axboe
ive. Sth like the following would be simpler?
>>
>> static inline struct blkcg_gq *blk_queue_root_blkg(struct request_queue *q)
>> {
>> return q->root_blkg;
>> }
>
> That would not only be simpler, it would also avoid that blk_queue_root_blkg()
> returns NULL if bypass mode is enabled and the request queue is still
> associated
> with the block cgroup controller. How do you want to proceed with this change?
Do a followup patch?
--
Jens Axboe
ixes line should be:
Fixes: ea8c5356d390 ("bcache: set max writeback rate when I/O request is idle")
(no Commit). I missed that on some of your earlier commits.
Applied with those edits, and some wording changes.
--
Jens Axboe
. Rename the function into
> blk_queue_root_blkg() as suggested by Tejun.
Applied, thanks.
--
Jens Axboe
don't change them. For example, error message exceeds 80 chars
> line limit.
It's a little late to apply these at this point, since 4.18 will be
released tomorrow. I can queue them up for later in the merge
window, for a post pull.
--
Jens Axboe
On 8/10/18 10:49 PM, Coly Li wrote:
> On 2018/8/11 2:19 AM, Jens Axboe wrote:
>> On 8/10/18 9:45 AM, Coly Li wrote:
>>> Commit ea8c5356d390 ("bcache: set max writeback rate when I/O request
>>> is idle") changes struct bch_ratelimit member rate from u
ntroller initialization
Jens Axboe (6):
Merge branch 'nvme-4.19' of git://git.infradead.org/nvme into
for-4.19/block
t10-pi: provide empty t10_pi_complete() for !CONFIG_BLK_DEV_INTEGRITY
Merge tag 'v4.18-rc6' into for-4.19/block2
Merge branch 'nvme-4.19
link:
>
> https://marc.info/?l=linux-block&m=153221542021033&w=2
Looks good to me, thanks for fixing this. Applied.
--
Jens Axboe
ion_on;
pd->write_congestion_off = write_congestion_off;
+ ret = -ENOMEM;
disk = alloc_disk(1);
if (!disk)
goto out_mem;
--
Jens Axboe
On 8/16/18 8:51 AM, Chengguang Xu wrote:
> Because blk_do_io_stat() only does a judgement about the request
> contributes to IO statistics, it better changes return type to bool.
Applied, thanks.
--
Jens Axboe
HED
> CONFIG_MQ_IOSCHED_DEADLINE=y
> CONFIG_MQ_IOSCHED_KYBER=m
>
> But I left the card reader on the office, so any test would have to
> wait until monday sorry :(
Can someone describe what bmaptools does? IOW, how is it different than
dd? Does it use multiple threads for both reads and writes?
--
Jens Axboe
queue.
Applied, thanks.
--
Jens Axboe
On 8/17/18 11:49 AM, Ricardo Ribalda Delgado wrote:
> Hi Jens
> On Fri, Aug 17, 2018 at 7:41 PM Jens Axboe wrote:
>>
>> On 8/17/18 11:39 AM, Ricardo Ribalda Delgado wrote:
>>> Hello Paolo
>>> On Fri, Aug 17, 2018 at 7:35 PM Paolo Valente
>>> wrot
We need to do this inside the loop as well, or we can allow new
IO to supersede previous IO.
Signed-off-by: Jens Axboe
---
block/blk-wbt.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 853e22492f4e..c9358f1981fb 100644
--- a
One cleanup, and two fixes:
Patch 2 - Ensure that the wait queue active check includes the necessary
memory barrier.
Patch 3 - Ensure that new tasks don't supersede already waiting tasks.
--
Jens Axboe
Check it in one place, instead of in multiple places.
Signed-off-by: Jens Axboe
---
block/blk-wbt.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index bb93c7c2b182..1dd7edce7a99 100644
--- a/block/blk-wbt.c
+++ b
We need the memory barrier before checking the list head,
use the appropriate helper for this. The matching queue
side memory barrier is provided by set_current_state().
Signed-off-by: Jens Axboe
---
block/blk-wbt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
ite() requests to read-only partitions".
Similar patch is already queued up, it'll go into Linus's tree before
-rc1.
--
Jens Axboe
fix code comments style
bcache: add static const prefix to char * array declarations
bcache: move open brace at end of function definitions to next line
bcache: add missing SPDX header
bcache: remove unnecessary space before ioctl function pointer arguments
bcache: add th
>> Changelog:
>> v2: add Fixes tag by Coly Li.
>> v1: initial patch from Shan Hai.
>
> Hi Jens,
>
> Please pick this patch for your next pull request. The change from Shan
> Hai fixes a real issue which is reported and lately verified by Shenghui
> Wang.
Applied - but I fixed up the commit message. Please keep lines at
72 characters for git commits.
--
Jens Axboe
On 8/22/18 1:12 PM, Holger Hoffstätte wrote:
> On 08/22/18 19:28, Jens Axboe wrote:
>> On 8/22/18 8:27 AM, Jens Axboe wrote:
>>> On 8/22/18 6:54 AM, Holger Hoffstätte wrote:
>>>> On 08/22/18 06:10, Jens Axboe wrote:
>>>>> [...]
>>>>> If
On 8/22/18 1:37 PM, Holger Hoffstätte wrote:
> On 08/22/18 21:17, Jens Axboe wrote:
>>> So the obvious suspect is the new return of UINT_MAX from get_limit() to
>>> __wbt_wait(). I first suspected that I mispatched something, but it's all
>>> like in mainline or
On 8/22/18 2:39 PM, Linus Torvalds wrote:
> On Wed, Aug 22, 2018 at 10:54 AM Jens Axboe wrote:
>>
>> - Set of bcache fixes and changes (Coly)
>
> Some of those bcache style fixes look questionable.
>
> Maybe we should push back on some of the checkpatch rules instead
truct rq_wb *rwb,
struct bio *bio)
{
enum wbt_flags flags = 0;
+ if (!rwb_enabled(rwb))
+ return 0;
+
if (bio_op(bio) == REQ_OP_READ) {
flags = WBT_READ;
} else if (wbt_should_throttle(rwb, bio)) {
--
Jens Axboe
)
Please pull!
git://git.kernel.dk/linux-block.git tags/for-linus-20180825
for-linus-20180825
Jens Axboe (4):
blk-wbt: move disable check into get_limit
On 8/27/18 5:31 PM, Chengguang Xu wrote:
> kmem_cache_destroy() can handle NULL pointer correctly, so there is
> no need to check e->icq_cache before calling kmem_cache_destroy().
Applied, thanks.
--
Jens Axboe
On 8/29/18 6:48 AM, Dan Carpenter wrote:
> Sorry, I responded to this patch that this wasn't a real bug, but then
> Scott corrected me that it was.
>
> Anyway, it is a bug and we haven't applied this patch yet.
It is now, apparently I lost track of it too. Thanks Scott.
--
Jens Axboe
201 - 300 of 4862 matches
Mail list logo
