Re: [PATCH 2/5] bcache: Split out crc64 to library

2018-05-22 Thread Andy Shevchenko
On Tue, 2018-05-22 at 18:33 +0800, Coly Li wrote: > On 2018/5/22 5:31 PM, Coly Li wrote: > > From: Andy Shevchenko <andriy.shevche...@linux.intel.com> > > > > For generic use split out crc64 code to a separate module > > in the library folder. >

Re: [PATCH v2] lib/crc64.c: add license information

2018-05-22 Thread Andy Shevchenko
On Tue, 2018-05-22 at 17:01 +0800, Coly Li wrote: > On 2018/5/22 4:54 PM, Coly Li wrote: > > This patch adds MODULE_LICENSE("GPL") to remove a kernel build > > warning > > information. Also as Andy Shevchenko suggested, adds a SPDX header > > into > >

Re: [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL")

2018-05-22 Thread Andy Shevchenko
. In any case it's probably worth to add SPDX header as well. > > Signed-off-by: Coly Li <col...@suse.de> > Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > lib/crc64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/crc64.c

Re: [PATCH 5/6] platform/x86: make device_attribute const

2017-08-30 Thread Andy Shevchenko
ttribute irst_timeout_attr = { > +static const struct device_attribute irst_timeout_attr = { > .attr = { .name = "wakeup_time", .mode = 0600 }, > .show = irst_show_wakeup_time, > .store = irst_store_wakeup_time > -- > 1.9.1 > -- With Best Regards, Andy Shevchenko

Re: [PATCH 15/24] block: remove blk_part_pack_uuid

2017-05-31 Thread Andy Shevchenko
args[0].from, > - entry->fsuuid); > + result = uuid_to_bin(args[0].from, (uuid_t > *)>fsuuid); > uuid_parse() ? -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy

Re: [PATCH 08/24] uuid: rename uuid_to_bin to uuid_parse

2017-05-31 Thread Andy Shevchenko
- return __uuid_to_bin(uuid, u->b, guid_index); > + return __uuid_parse(uuid, u->b, guid_index); >  } > -EXPORT_SYMBOL(guid_to_bin); > +EXPORT_SYMBOL(guid_parse); >   > -int uuid_to_bin(const char *uuid, uuid_t *u) > +int uuid_parse(const char *uuid, uuid_t *u) >  { > - return __uuid_to_bin(uuid, u->b, uuid_index); > + return __uuid_parse(uuid, u->b, uuid_index); >  } > -EXPORT_SYMBOL(uuid_to_bin); > +EXPORT_SYMBOL(uuid_parse); -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy