Re: [PATCH 6/6] scsi: Check sense buffer size at build time

2018-05-23 Thread Sergei Shtylyov
Hello! On 5/22/2018 9:15 PM, Kees Cook wrote: To avoid introducing problems like those fixed in commit f7068114d45e ("sr: pass down correctly sized SCSI sense buffer"), this creates a macro wrapper for scsi_execute() that verifies the size of the sense buffer similar to what was done for

Re: [PATCH 4/6] libata: factor out a ata_identify_page_supported helper

2017-06-05 Thread Sergei Shtylyov
Hello! On 06/04/2017 03:42 PM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig --- drivers/ata/libata-core.c | 59 +-- 1 file changed, 32 insertions(+), 27 deletions(-) diff --git a/drivers/ata/libata-core.c

Re: remove the cmd_type field from struct request

2017-02-01 Thread Sergei Shtylyov
On 2/1/2017 9:53 AM, Hannes Reinecke wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through

Re: remove the cmd_type field from struct request

2017-01-31 Thread Sergei Shtylyov
On 01/31/2017 09:51 PM, James Bottomley wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

2016-08-12 Thread Sergei Shtylyov
On 08/12/2016 02:56 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently we use dev->max_sectors to set max_hw_sectors, which is actually supposed to be a host controller limit (that get set Gets. by the host controller driver like ahci, and if not it would be the

Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices

2016-08-09 Thread Sergei Shtylyov
Hello. On 08/09/2016 05:45 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently block layer limit max_hw_sectors is set to ATA_MAX_SECTORS_LBA48 (65535), for devices with LBA48 support. However, block layer limit max_sectors (which is the effective one; also adjustable,