Re: [PATCH v3 0/3] Fix races between blkcg code and request queue initialization and cleanup

[Bart Van Assche]

On 02/09/18 10:44, Bart Van Assche wrote:

Recently Joseph Qi identified races between the block cgroup code and request
queue initialization and cleanup. This patch series address these races. Please
consider these patches for kernel v4.17.


Hello Joseph,

Can you add your Tested-by or Reviewed-by to the patches in this series?

Thanks,

Bart.

[PATCH v3 0/3] Fix races between blkcg code and request queue initialization and cleanup

[Bart Van Assche]

Hello Jens,

Recently Joseph Qi identified races between the block cgroup code and request
queue initialization and cleanup. This patch series address these races. Please
consider these patches for kernel v4.17.

Thanks,

Bart.

Changes between v2 and v3:
- Added a third patch that fixes a race between the blkcg code and queue
  cleanup.

Changes between v1 and v2:
- Split a single patch into two patches.
- Dropped blk_alloc_queue_node2() and modified all block drivers that call
  blk_alloc_queue_node().

Bart Van Assche (3):
  block: Add a third argument to blk_alloc_queue_node()
  block: Fix a race between the cgroup code and request queue
initialization
  block: Fix a race between request queue removal and the block cgroup
controller

 block/blk-core.c   | 60 +++---
 block/blk-mq.c |  2 +-
 block/blk-sysfs.c  |  7 -
 drivers/block/drbd/drbd_main.c |  3 +--
 drivers/block/null_blk.c   |  3 ++-
 drivers/block/umem.c   |  7 +++--
 drivers/ide/ide-probe.c|  2 +-
 drivers/lightnvm/core.c|  2 +-
 drivers/md/dm.c|  2 +-
 drivers/nvdimm/pmem.c  |  2 +-
 drivers/nvme/host/multipath.c  |  2 +-
 drivers/scsi/scsi_lib.c|  2 +-
 include/linux/blkdev.h |  3 ++-
 13 files changed, 65 insertions(+), 32 deletions(-)

-- 
2.16.1