Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-22 Thread Jens Axboe
On 6/22/18 2:52 AM, Jan Kara wrote: > On Mon 18-06-18 10:40:14, Tejun Heo wrote: >> On Mon, Jun 18, 2018 at 03:46:58PM +0200, Jan Kara wrote: >>> syzbot is reporting NULL pointer dereference at wb_workfn() [1] due to >>> wb->bdi->dev being NULL. And Dmitry confirmed that wb->state was >>>

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-22 Thread Jan Kara
On Mon 18-06-18 10:40:14, Tejun Heo wrote: > On Mon, Jun 18, 2018 at 03:46:58PM +0200, Jan Kara wrote: > > syzbot is reporting NULL pointer dereference at wb_workfn() [1] due to > > wb->bdi->dev being NULL. And Dmitry confirmed that wb->state was > > WB_shutting_down after wb->bdi->dev became

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-19 Thread Jan Kara
On Mon 18-06-18 23:38:12, Tetsuo Handa wrote: > On 2018/06/18 22:46, Jan Kara wrote: > > syzbot is reporting NULL pointer dereference at wb_workfn() [1] due to > > [1] > https://syzkaller.appspot.com/bug?id=e0818ccb7e46190b3f1038b0c794299208ed4206 > > line is missing. > > > wb->bdi->dev being

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-18 Thread Tejun Heo
On Mon, Jun 18, 2018 at 03:46:58PM +0200, Jan Kara wrote: > syzbot is reporting NULL pointer dereference at wb_workfn() [1] due to > wb->bdi->dev being NULL. And Dmitry confirmed that wb->state was > WB_shutting_down after wb->bdi->dev became NULL. This indicates that > unregister_bdi() failed to

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-18 Thread Tetsuo Handa
On 2018/06/18 22:46, Jan Kara wrote: > syzbot is reporting NULL pointer dereference at wb_workfn() [1] due to [1] https://syzkaller.appspot.com/bug?id=e0818ccb7e46190b3f1038b0c794299208ed4206 line is missing. > wb->bdi->dev being NULL. And Dmitry confirmed that wb->state was > WB_shutting_down

[PATCH] bdi: Fix another oops in wb_workfn()

2018-06-18 Thread Jan Kara
syzbot is reporting NULL pointer dereference at wb_workfn() [1] due to wb->bdi->dev being NULL. And Dmitry confirmed that wb->state was WB_shutting_down after wb->bdi->dev became NULL. This indicates that unregister_bdi() failed to call wb_shutdown() on one of wb objects. The problem is in

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-11 Thread Jan Kara
On Mon 11-06-18 09:01:31, Tejun Heo wrote: > Hello, > > On Mon, Jun 11, 2018 at 11:12:48AM +0200, Jan Kara wrote: > > However this is wrong and so is the patch. The problem is in > > cgwb_bdi_unregister() which does cgwb_kill() and thus drops bdi's > > reference to wb structures before going

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-11 Thread Tejun Heo
Hello, On Mon, Jun 11, 2018 at 11:12:48AM +0200, Jan Kara wrote: > However this is wrong and so is the patch. The problem is in > cgwb_bdi_unregister() which does cgwb_kill() and thus drops bdi's > reference to wb structures before going through the list of wbs again and > calling wb_shutdown()

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-06-11 Thread Jan Kara
On Sat 09-06-18 23:00:05, Tetsuo Handa wrote: > From 014c4149f2e24cd26b278b32d5dfda056eecf093 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Sat, 9 Jun 2018 22:47:52 +0900 > Subject: [PATCH] bdi: Fix another oops in wb_workfn() > > syzbot is reporting NULL pointer derefe

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-05-29 Thread Tejun Heo
On Sun, May 27, 2018 at 01:43:45PM +0900, Tetsuo Handa wrote: > Tejun Heo wrote: > > On Sun, May 27, 2018 at 11:21:25AM +0900, Tetsuo Handa wrote: > > > syzbot is still hitting NULL pointer dereference at wb_workfn() [1]. > > > This might be because we overlooked that delayed_work_timer_fn() does

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-05-26 Thread Tetsuo Handa
Tejun Heo wrote: > On Sun, May 27, 2018 at 11:21:25AM +0900, Tetsuo Handa wrote: > > syzbot is still hitting NULL pointer dereference at wb_workfn() [1]. > > This might be because we overlooked that delayed_work_timer_fn() does not > > check WB_registered before calling __queue_work() while

Re: [PATCH] bdi: Fix another oops in wb_workfn()

2018-05-26 Thread Tejun Heo
On Sun, May 27, 2018 at 11:21:25AM +0900, Tetsuo Handa wrote: > From 8a8222698163d1fe180258566e9a3ff43f54fcd9 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> > Date: Sun, 27 May 2018 11:08:20 +0900 > Subject: [PATCH] bdi: Fix another

[PATCH] bdi: Fix another oops in wb_workfn()

2018-05-26 Thread Tetsuo Handa
>From 8a8222698163d1fe180258566e9a3ff43f54fcd9 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> Date: Sun, 27 May 2018 11:08:20 +0900 Subject: [PATCH] bdi: Fix another oops in wb_workfn() syzbot is still hitting NULL pointer dereference at wb_wo