Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen

2018-04-19 Thread h...@lst.de
On Tue, Apr 17, 2018 at 05:35:07PM +, Bart Van Assche wrote: > > Hmm. I think we need to avoid clearing that data and update it using > > RCU instead. Calling blk_queue_enter before submitting bios is > > something that would make zone reporting very different from any > > other block layer

Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen

2018-04-17 Thread Damien Le Moal
Christoph, On 2018/04/17 8:18, Christoph Hellwig wrote: > On Mon, Apr 16, 2018 at 06:00:34PM -0700, Bart Van Assche wrote: >> This patch on itself does not change the behavior of either ioctl. >> However, this patch is necessary to avoid that these ioctls fail >> with -EIO if sd_revalidate_disk()

Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen

2018-04-17 Thread Bart Van Assche
On Tue, 2018-04-17 at 17:18 +0200, Christoph Hellwig wrote: > On Mon, Apr 16, 2018 at 06:00:34PM -0700, Bart Van Assche wrote: > > This patch on itself does not change the behavior of either ioctl. > > However, this patch is necessary to avoid that these ioctls fail > > with -EIO if

Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen

2018-04-17 Thread Bart Van Assche
On Tue, 2018-04-17 at 17:18 +0200, Christoph Hellwig wrote: > On Mon, Apr 16, 2018 at 06:00:34PM -0700, Bart Van Assche wrote: > > This patch on itself does not change the behavior of either ioctl. > > However, this patch is necessary to avoid that these ioctls fail > > with -EIO if

Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen

2018-04-17 Thread Christoph Hellwig
On Mon, Apr 16, 2018 at 06:00:34PM -0700, Bart Van Assche wrote: > This patch on itself does not change the behavior of either ioctl. > However, this patch is necessary to avoid that these ioctls fail > with -EIO if sd_revalidate_disk() is called while these ioctls are > in progress because the

[PATCH] block: Avoid executing a report or reset zones while a queue is frozen

2018-04-16 Thread Bart Van Assche
This patch on itself does not change the behavior of either ioctl. However, this patch is necessary to avoid that these ioctls fail with -EIO if sd_revalidate_disk() is called while these ioctls are in progress because the current zoned block command code temporarily clears data that is needed by