Re: [PATCH] block: Make writeback throttling defaults consistent for SQ devices

2017-04-19 Thread Jens Axboe
On 04/19/2017 03:33 AM, Jan Kara wrote: > When CFQ is used as an elevator, it disables writeback throttling > because they don't play well together. Later when a different elevator > is chosen for the device, writeback throttling doesn't get enabled > again as it should. Make sure CFQ enables

Re: [PATCH] block: Make writeback throttling defaults consistent for SQ devices

2017-04-19 Thread Jan Kara
On Wed 19-04-17 11:33:27, Jan Kara wrote: > When CFQ is used as an elevator, it disables writeback throttling > because they don't play well together. Later when a different elevator > is chosen for the device, writeback throttling doesn't get enabled > again as it should. Make sure CFQ enables

[PATCH] block: Make writeback throttling defaults consistent for SQ devices

2017-04-19 Thread Jan Kara
When CFQ is used as an elevator, it disables writeback throttling because they don't play well together. Later when a different elevator is chosen for the device, writeback throttling doesn't get enabled again as it should. Make sure CFQ enables writeback throttling (if it should be enabled by

Re: [PATCH] block: Make writeback throttling defaults consistent for SQ devices

2017-04-18 Thread Jan Kara
Hello Bart, On Fri 14-04-17 15:42:53, Bart Van Assche wrote: > On Wed, 2017-04-12 at 10:23 +0200, Jan Kara wrote: > > +#ifndef CONFIG_BLK_WBT_MQ > > + if (q->mq_ops) > > + return; > > +#endif > > +#ifndef CONFIG_BLK_WBT_SQ > > + if (q->request_fn) > > + return; > > +#endif

Re: [PATCH] block: Make writeback throttling defaults consistent for SQ devices

2017-04-14 Thread Bart Van Assche
On Wed, 2017-04-12 at 10:23 +0200, Jan Kara wrote: > +#ifndef CONFIG_BLK_WBT_MQ > + if (q->mq_ops) > + return; > +#endif > +#ifndef CONFIG_BLK_WBT_SQ > + if (q->request_fn) > + return; > +#endif > + > + /* > + * If this fails, we don't get throttling > +