Re: [PATCH] block: drain queue before waiting for q_usage_counter becoming zero

2017-11-22 Thread Ming Lei
On Wed, Nov 22, 2017 at 04:47:48PM +, Bart Van Assche wrote: > On Wed, 2017-11-22 at 13:11 +0800, Ming Lei wrote: > > diff --git a/block/blk-mq.c b/block/blk-mq.c > > index 11097477eeab..3d3797327491 100644 > > --- a/block/blk-mq.c > > +++ b/block/blk-mq.c > > @@ -161,6 +161,8 @@ void

Re: [PATCH] block: drain queue before waiting for q_usage_counter becoming zero

2017-11-22 Thread Bart Van Assche
On Wed, 2017-11-22 at 13:11 +0800, Ming Lei wrote: > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 11097477eeab..3d3797327491 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -161,6 +161,8 @@ void blk_freeze_queue(struct request_queue *q) >* exported to drivers as the only

Re: [PATCH] block: drain queue before waiting for q_usage_counter becoming zero

2017-11-22 Thread Ming Lei
On Wed, Nov 22, 2017 at 08:04:13AM +0100, Hannes Reinecke wrote: > On 11/22/2017 06:11 AM, Ming Lei wrote: > > Now we track legacy requests with .q_usage_counter in commit 055f6e18e08f > > ("block: Make q_usage_counter also track legacy requests"), but that > > commit never runs and drains legacy

Re: [PATCH] block: drain queue before waiting for q_usage_counter becoming zero

2017-11-21 Thread Hannes Reinecke
On 11/22/2017 06:11 AM, Ming Lei wrote: > Now we track legacy requests with .q_usage_counter in commit 055f6e18e08f > ("block: Make q_usage_counter also track legacy requests"), but that > commit never runs and drains legacy queue before waiting for this counter > becoming zero, then IO hang is

[PATCH] block: drain queue before waiting for q_usage_counter becoming zero

2017-11-21 Thread Ming Lei
Now we track legacy requests with .q_usage_counter in commit 055f6e18e08f ("block: Make q_usage_counter also track legacy requests"), but that commit never runs and drains legacy queue before waiting for this counter becoming zero, then IO hang is caused in the test of pulling disk during IO.