Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-09 Thread Kyle Fortin
On Oct 6, 2017, at 6:26 PM, Tim Hansen wrote: > On Fri, Oct 06, 2017 at 01:04:25PM -0600, Jens Axboe wrote: >> On 10/05/2017 12:09 PM, Tim Hansen wrote: >>> mempool_destroy() already checks for a NULL value being passed in, this >>> eliminates duplicate checks. >>> >>>

Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-06 Thread Tim Hansen
On Fri, Oct 06, 2017 at 01:04:25PM -0600, Jens Axboe wrote: > On 10/05/2017 12:09 PM, Tim Hansen wrote: > > mempool_destroy() already checks for a NULL value being passed in, this > > eliminates duplicate checks. > > > > This was caught by running make coccicheck M=block/ on linus' tree on > >

Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-06 Thread Jens Axboe
On 10/05/2017 12:09 PM, Tim Hansen wrote: > mempool_destroy() already checks for a NULL value being passed in, this > eliminates duplicate checks. > > This was caught by running make coccicheck M=block/ on linus' tree on commit > 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this

Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-06 Thread Kyle Fortin
Hi Tim, On Oct 5, 2017, at 2:09 PM, Tim Hansen wrote: > > mempool_destroy() already checks for a NULL value being passed in, this > eliminates duplicate checks. > > This was caught by running make coccicheck M=block/ on linus' tree on commit >

[PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-05 Thread Tim Hansen
mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks. This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch). Signed-off-by: Tim Hansen