Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-09 Thread Jan Kara
On Fri 04-05-18 20:47:29, Tetsuo Handa wrote: > >From 626d33de1b70b11ecaf95a9f83f7644998e54cbb Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> > Date: Wed, 2 May 2018 23:03:48 +0900 > Subject: [PATCH] loop: remember whether sysfs_cre

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-08 Thread Milan Broz
On 05/05/2018 01:49 PM, Tetsuo Handa wrote: > Milan Broz wrote: >>> Do we want to abort LOOP_SET_FD request if sysfs_create_group() failed? >> >> I would prefer failure - there are several utilities that expects attributes >> in >> sysfs to be valid (for example I print info from here in

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-05 Thread Tetsuo Handa
Milan Broz wrote: > On 05/04/2018 04:40 PM, Tetsuo Handa wrote: > > The loop module ignores sysfs_create_group() failure and pretends that > > LOOP_SET_FD request succeeded. I guess that the author of commit > > ee86273062cbb310 ("loop: add some basic read-only sysfs attributes") > > assumed that

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-05 Thread Milan Broz
On 05/04/2018 04:40 PM, Tetsuo Handa wrote: > The loop module ignores sysfs_create_group() failure and pretends that > LOOP_SET_FD request succeeded. I guess that the author of commit > ee86273062cbb310 ("loop: add some basic read-only sysfs attributes") > assumed that it is not a fatal error

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-04 Thread Jens Axboe
2001 >>>>> From: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> >>>>> Date: Wed, 2 May 2018 23:03:48 +0900 >>>>> Subject: [PATCH] loop: remember whether sysfs_create_group() succeeded >>>>> >>>>> syzbot is hitti

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-04 Thread Tetsuo Handa
.sakura.ne.jp> > >>> Date: Wed, 2 May 2018 23:03:48 +0900 > >>> Subject: [PATCH] loop: remember whether sysfs_create_group() succeeded > >>> > >>> syzbot is hitting WARN() triggered by memory allocation fault > >>> inje

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-04 Thread Jens Axboe
2 May 2018 23:03:48 +0900 >>> Subject: [PATCH] loop: remember whether sysfs_create_group() succeeded >>> >>> syzbot is hitting WARN() triggered by memory allocation fault >>> injection [1] because loop module is calling sysfs_remove_group() >>> when sysfs

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-04 Thread Tetsuo Handa
Jens Axboe wrote: > On 5/4/18 5:47 AM, Tetsuo Handa wrote: > >>From 626d33de1b70b11ecaf95a9f83f7644998e54cbb Mon Sep 17 00:00:00 2001 > > From: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> > > Date: Wed, 2 May 2018 23:03:48 +0900 > > Subject: [PATCH] loop:

Re: [PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-04 Thread Jens Axboe
On 5/4/18 5:47 AM, Tetsuo Handa wrote: >>From 626d33de1b70b11ecaf95a9f83f7644998e54cbb Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> > Date: Wed, 2 May 2018 23:03:48 +0900 > Subject: [PATCH] loop: remember whether sysfs_create_group()

[PATCH] loop: remember whether sysfs_create_group() succeeded

2018-05-04 Thread Tetsuo Handa
>From 626d33de1b70b11ecaf95a9f83f7644998e54cbb Mon Sep 17 00:00:00 2001 From: Tetsuo Handa <penguin-ker...@i-love.sakura.ne.jp> Date: Wed, 2 May 2018 23:03:48 +0900 Subject: [PATCH] loop: remember whether sysfs_create_group() succeeded syzbot is hitting WARN() triggered by memory allocat