Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Tue 07-03-17 08:28:23, Omar Sandoval wrote: > On Tue, Mar 07, 2017 at 02:57:30PM +0100, Jan Kara wrote: > > On Mon 06-03-17 12:38:18, Omar Sandoval wrote: > > > Unfortunately, this patch actually seems to have introduced a > > > regression. Reverting the patch fixes it. > > > > > > I'm running

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Tue, Mar 07, 2017 at 02:57:30PM +0100, Jan Kara wrote: > On Mon 06-03-17 12:38:18, Omar Sandoval wrote: > > Unfortunately, this patch actually seems to have introduced a > > regression. Reverting the patch fixes it. > > > > I'm running a QEMU kvm vm with a virtio-scsi device and I get oopses >

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Mon 06-03-17 12:38:18, Omar Sandoval wrote: > On Wed, Mar 01, 2017 at 04:11:09PM +0100, Jan Kara wrote: > > On Tue 28-02-17 23:26:53, Omar Sandoval wrote: > > > On Tue, Feb 28, 2017 at 11:25:28PM -0800, Omar Sandoval wrote: > > > > On Wed, Feb 22, 2017 at 11:24:25AM +0100, Jan Kara wrote: > > >

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

Hello, Jan. On Wed, Mar 01, 2017 at 04:37:00PM +0100, Jan Kara wrote: > > The other thing which came to mind is that the congested->__bdi sever > > semantics. IIRC, that one was also to support the "bdi must go away now" > > behavior. As bdi is refcnted now, I think we can probably just let

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Tue 28-02-17 23:26:53, Omar Sandoval wrote: > On Tue, Feb 28, 2017 at 11:25:28PM -0800, Omar Sandoval wrote: > > On Wed, Feb 22, 2017 at 11:24:25AM +0100, Jan Kara wrote: > > > On Tue 21-02-17 10:19:28, Jens Axboe wrote: > > > > On 02/21/2017 10:09 AM, Jan Kara wrote: > > > > > Hello, > > > > >

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

Hello, On Tue 28-02-17 11:54:41, Tejun Heo wrote: > It generally looks good to me. Thanks for review! > The only worry I have is around wb_shutdown() synchronization and if that > is actually an issue it shouldn't be too difficult to fix. Yeah, I'll have a look at that. > The other thing

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Wed, Feb 22, 2017 at 11:24:25AM +0100, Jan Kara wrote: > On Tue 21-02-17 10:19:28, Jens Axboe wrote: > > On 02/21/2017 10:09 AM, Jan Kara wrote: > > > Hello, > > > > > > this is a second revision of the patch set to fix several different races > > > and > > > issues I've found when testing

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Tue, Feb 28, 2017 at 11:25:28PM -0800, Omar Sandoval wrote: > On Wed, Feb 22, 2017 at 11:24:25AM +0100, Jan Kara wrote: > > On Tue 21-02-17 10:19:28, Jens Axboe wrote: > > > On 02/21/2017 10:09 AM, Jan Kara wrote: > > > > Hello, > > > > > > > > this is a second revision of the patch set to fix

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

Hello, It generally looks good to me. The only worry I have is around wb_shutdown() synchronization and if that is actually an issue it shouldn't be too difficult to fix. The other thing which came to mind is that the congested->__bdi sever semantics. IIRC, that one was also to support the

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Tue 21-02-17 10:19:28, Jens Axboe wrote: > On 02/21/2017 10:09 AM, Jan Kara wrote: > > Hello, > > > > this is a second revision of the patch set to fix several different races > > and > > issues I've found when testing device shutdown and reuse. The first three > > patches are fixes to

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On Tue, Feb 21, 2017 at 9:19 AM, Jan Kara wrote: > On Tue 21-02-17 18:09:45, Jan Kara wrote: >> Hello, >> >> this is a second revision of the patch set to fix several different races and >> issues I've found when testing device shutdown and reuse. The first three >> patches are

Re: [PATCH 0/13 v2] block: Fix block device shutdown related races

On 02/21/2017 10:09 AM, Jan Kara wrote: > Hello, > > this is a second revision of the patch set to fix several different races and > issues I've found when testing device shutdown and reuse. The first three > patches are fixes to problems in my previous series fixing BDI lifetime > issues. >

[PATCH 0/13 v2] block: Fix block device shutdown related races

Hello, this is a second revision of the patch set to fix several different races and issues I've found when testing device shutdown and reuse. The first three patches are fixes to problems in my previous series fixing BDI lifetime issues. Patch 4 fixes issues with reuse of BDI name with scsi