Re: [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Bart Van Assche
On Thu, 2018-11-08 at 10:50 -0700, Jens Axboe wrote: > How about this incremental? > > diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c > index 097e9a67d5f5..87bc5df72d48 100644 > --- a/block/blk-mq-tag.c > +++ b/block/blk-mq-tag.c > @@ -248,7 +248,8 @@ static bool bt_iter(struct sbitmap *bitm

Re: [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Jens Axboe
On 11/8/18 10:47 AM, Jens Axboe wrote: > On 11/8/18 10:35 AM, Bart Van Assche wrote: >> On Thu, 2018-11-08 at 09:31 -0700, Jens Axboe wrote: >>> On 11/8/18 9:28 AM, Bart Van Assche wrote: On Thu, 2018-11-08 at 09:06 -0700, Jens Axboe wrote: > --- a/block/blk-mq-debugfs.c > +++ b/block/

Re: [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Jens Axboe
On 11/8/18 10:35 AM, Bart Van Assche wrote: > On Thu, 2018-11-08 at 09:31 -0700, Jens Axboe wrote: >> On 11/8/18 9:28 AM, Bart Van Assche wrote: >>> On Thu, 2018-11-08 at 09:06 -0700, Jens Axboe wrote: --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -424,13 +424,15 @@ st

Re: [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Bart Van Assche
On Thu, 2018-11-08 at 09:31 -0700, Jens Axboe wrote: > On 11/8/18 9:28 AM, Bart Van Assche wrote: > > On Thu, 2018-11-08 at 09:06 -0700, Jens Axboe wrote: > > > --- a/block/blk-mq-debugfs.c > > > +++ b/block/blk-mq-debugfs.c > > > @@ -424,13 +424,15 @@ struct show_busy_params { > > > * Note: the

Re: [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Jens Axboe
On 11/8/18 9:28 AM, Bart Van Assche wrote: > On Thu, 2018-11-08 at 09:06 -0700, Jens Axboe wrote: >> --- a/block/blk-mq-debugfs.c >> +++ b/block/blk-mq-debugfs.c >> @@ -424,13 +424,15 @@ struct show_busy_params { >> * Note: the state of a request may change while this function is in >> progress,

Re: [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Bart Van Assche
On Thu, 2018-11-08 at 09:06 -0700, Jens Axboe wrote: > --- a/block/blk-mq-debugfs.c > +++ b/block/blk-mq-debugfs.c > @@ -424,13 +424,15 @@ struct show_busy_params { > * Note: the state of a request may change while this function is in > progress, > * e.g. due to a concurrent blk_mq_finish_requ

[PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Jens Axboe
We have this functionality in sbitmap, but we don't export it in blk-mq for users of the tags busy iteration. This can be useful for stopping the iteration, if the caller doesn't need to find more requests. Reviewed-by: Mike Snitzer Signed-off-by: Jens Axboe --- block/blk-mq-debugfs.c | 4 +++-

Re: [PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Mike Snitzer
On Thu, Nov 08 2018 at 10:42am -0500, Jens Axboe wrote: > We have this functionality in sbitmap, but we don't export it in > blk-mq for users of the tags busy iteration. This can be useful > for stopping the iteration, if the caller doesn't need to find > more requests. > > Cc: Mike Snitzer > S

[PATCH 1/2] blk-mq-tag: change busy_iter_fn to return whether to continue or not

2018-11-08 Thread Jens Axboe
We have this functionality in sbitmap, but we don't export it in blk-mq for users of the tags busy iteration. This can be useful for stopping the iteration, if the caller doesn't need to find more requests. Cc: Mike Snitzer Signed-off-by: Jens Axboe --- block/blk-mq-debugfs.c | 4 +++- block/b