Re: [PATCH 2/2] blkcg: init root blkcg_gq under lock

2018-04-26 Thread Tejun Heo
Hello, On Thu, Apr 19, 2018 at 12:06:09PM +0800, Jiang Biao wrote: > The initializing of q->root_blkg is currently outside of queue lock > and rcu, so the blkg may be destroied before the initializing, which > may cause dangling/null references. On the other side, the destroys > of blkg are

[PATCH 2/2] blkcg: init root blkcg_gq under lock

2018-04-18 Thread Jiang Biao
The initializing of q->root_blkg is currently outside of queue lock and rcu, so the blkg may be destroied before the initializing, which may cause dangling/null references. On the other side, the destroys of blkg are protected by queue lock or rcu. Put the initializing inside the queue lock and